[1.12.2] On Item Click not working

[ogrekpl]

Hello guys!

I'm not sure what am I doing wrong  
What I want to do:

- if player got in inventory specify item do:
   - deal dmg to player
   - add new intem to inventory

   - delete item from hand

 

public class ItemFireDiamondFireing extends ItemBase implements IHasModel
{

	public ItemFireDiamondFireing(String name) 
	{
		super(name);
	}
	
	
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) 
	{
		ItemStack item = playerIn.getHeldItem(handIn);
		
		ItemStack itemStackIn = new ItemStack(ItemInit.ITEM_GRINDER_BOWL);
		
		if (playerIn.inventory.hasItemStack(itemStackIn))
		{
			float dmg = 20.0f; // x dmg
			playerIn.setHealth(playerIn.getHealth() - dmg); //Deal x DMG
			
			playerIn.addItemStackToInventory(itemStackIn); // some item 
			
		}
		
		return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);
	}	

 

[Draco18s]

1 hour ago, ogrekpl said:

itemStackIn

This is a bad name for this variable. The "in" portion of the parameters indicate that it was passed in to the function.

 

1 hour ago, ogrekpl said:

return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, item);

If you want to delete the item from their hand, don't return the item.

[DavidM]

1. Define "not working".

2. Currently, your code triggers twice when the player right clicks (fires once on both side). Check if the world is on the desired side before executing your code.

3. Stop using ItemBase and IHasModel. They are bad practices.

4.

float dmg = 20.0f; // x dmg
playerIn.setHealth(playerIn.getHealth() - dmg); //Deal x DMG

Unless you are intentionally setting the player's health to a lower value instead of damaging the player, use Entity#attackEntityFrom instead.

Edited March 24, 2019 by DavidM

[ogrekpl]

Ok i got it. Some my bad implementations in inicialization items. 

Thanks DavidM for Entity#attackEntityFrom and Draco18s, diesieben07  too

 

Additional, I wounder, in what way I can damage item from inventory (decrese durability from 20 to 19 - by 1 point)
 

	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) 
	{
		ItemStack item = playerIn.getHeldItem(handIn);
		ItemStack itemStack = new ItemStack(ItemInit.ITEM_GRINDER_BOWL); // item with durability
		ItemStack itemStackReturn = new ItemStack(ItemInit.ITEM_FIRE_DIAMOND);
		
		if (playerIn.inventory.hasItemStack(itemStack))
		{
			playerIn.attackEntityFrom(DamageSource.ON_FIRE, 3.0f);
			playerIn.addItemStackToInventory(itemStackReturn);	
			int slotNr = playerIn.inventory.findSlotMatchingUnusedItem(itemStack); // find slot nr where is this item i want decrese durability
			
			ItemStack damageItemStack = new ItemStack(***); // here i want to copy item from inventory
			//someItemStack.setItemDamage(someItemStack.getItemDamage() - 1); // decrease durabilit of item that i copied 
			playerIn.inventory.removeStackFromSlot(slotNr); //remove original item
			//add this copied item with 1 less durability
			
			return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, ItemStack.EMPTY);
		}
		else 
		{
			return new ActionResult<ItemStack>(EnumActionResult.FAIL, item);
		}
		
	}	

 

This is my idea but i cant find methods for taking ItemStack from item in inventory(e.g by slot nr)
I hope you know what I need  

Edited March 24, 2019 by ogrekpl

[DavidM]

12 minutes ago, ogrekpl said:

Additional, I wounder, in what way I can damage item from inventory (decrese durability from 20 to 19 - by 1 point)

ItemStack#damageItem.

 

Also, you still haven't fixed the "firing on both sides" problem.

14 hours ago, DavidM said:

Currently, your code triggers twice when the player right clicks (fires once on both side). Check if the world is on the desired side before executing your code.

 

[ogrekpl]

19 minutes ago, DavidM said:

ItemStack#damageItem.

Yes, but still, I probably need to take specific item, 'coz player might have 10 similar items. I thought I have find one, copy it, damage this copy, remove original and add copied one. Am I correct?

 

19 minutes ago, DavidM said:

Also, you still haven't fixed the "firing on both sides" problem.

Probably I'm too nooby. Why it's triggering twice not once? Item I got in hand is fireing one(ITEM_FIREDIAMOND_FIREING), and by clicking it I get dmg as player and receive stable one (ITEM_FIRE_DIAMOND)

Edited March 24, 2019 by ogrekpl

[Draco18s]

16 hours ago, diesieben07 said:

No. It is a workaround for the deficiencies in the deobfuscation toolchain which cannot reliably handle parameters with the same name as a field in the class. That is the sole reason for the "in" suffix.

Oh for fuck's sake diesieben07, you know that's what I meant. I was trying to point out that the name was bad because it was copying a naming schema based on the passed in parameters without thinking about what that schema meant.