[SOLVED, 1.12.] How to make a "dynamic light"?

[cinsiian]

Hello. Basically I maded an item that basically is lantern. I wanna ask if you know a way to make a dynamic light, a light that follows the player only if the lantern is in the main or in the second hand.

How can I do that without using the api from Dynamic Lights?

Thank you

Edited June 11, 2019 by cinsiian

[cinsiian]

Do I need a custom renderer?

[cinsiian]

I can do this like in a PlayerMoveEvent?

[cinsiian]

how can i check if the player's position is changed?

[cinsiian]

Ok I tried creating a tile entity with a timer in it. When the timer is 0 the block should disappear but it doesn work. Maybe i have not coded correctly the tile entity?

https://github.com/cinsiian/MiningFeelings/blob/master/src/main/java/com/cinsiian/miningFeelings/block/tileEntity/LanternLightTileEntity.java

https://github.com/cinsiian/MiningFeelings/blob/master/src/main/java/com/cinsiian/miningFeelings/block/BlockLanternLight.java

 

[DavidM]

Well, you haven't actually... you know... write the "block disappear" part.
 

Moreover, your isTimerEnded does nothing as of now; you are not checking it at all. Besides, whether the timer has ended can be determined by a simple

timer <= 0

instead of creating a new variable.

Edited June 11, 2019 by DavidM

[Cadiboo]

Doing lighting like this is very performance intensive. 

[cinsiian]

  On 6/11/2019 at 12:27 PM, Cadiboo said:

Doing lighting like this is very performance intensive. 

Expand  

I know but its the whole point of a lantern.

[Cadiboo]

Find a better way to do it than you’re doing it now. I would try and do it with

1) OptiFine/DynamicLights integration

2) A shader

3) Placing blocks every second or half second and always having a maximum of 1 lighting block around per lantern. 

[cinsiian]

  On 6/11/2019 at 12:40 PM, Cadiboo said:

Placing blocks every second or half second and always having a maximum of 1 lighting block around per lantern. 

Expand  

I am kinda doing that with my code, if a player is not moving, the game will not replace the block but i have some issues with my tile entity that i cant figure out.

[cinsiian]

  On 6/11/2019 at 12:24 PM, DavidM said:

Well, you haven't actually... you know... write the "block disappear" part.
 

Moreover, your isTimerEnded does nothing as of now; you are not checking it at all. Besides, whether the timer has ended can be determined by a simple

timer <= 0

instead of creating a new variable.

Expand  

Well, I removed the boolean and added the function. Keeps not working.

https://github.com/cinsiian/MiningFeelings/blob/master/src/main/java/com/cinsiian/miningFeelings/block/tileEntity/LanternLightTileEntity.java

[cinsiian]

Solved I just imported the wrong ITickable

[Draco18s]

This is old, old code (circa 1.7.10 originally, updated to work with 1.10), but this will handle the light source, as a block, utilizing as few updates as possible. Any data stored in the ItemStack NBT should be changed to use a capability, but that's all the necessary information.

 

https://github.com/Draco18s/Artifacts/blob/master/main/java/com/draco18s/artifacts/components/ComponentLight.java#L63-L126

 

"That's not an Item!" you say.
"Doesn't fucking matter, its the same function signature that does exist in Item"

You'll just have to figure out what that function looks like now.