My Textures Aren't Loading

[PulseBeat_02]

Hi, I was programming my mod, and I encountered a problem with textures. Recently, I renamed one of the package declarations, and eclipse messed up my class files, deleting the main mod reference file and my event subscriber class. Before, the textures worked, but now, they are just purple and black. Here is my GitHub: https://github.com/PulseBeat02/King-Mammoth-Mod

Edited August 12, 2019 by PulseBeat_02

[Draco18s]

Log file?

[PulseBeat_02]

@Draco18s 

latest.log

Edited August 12, 2019 by PulseBeat_02

[Animefan8888]

23 minutes ago, PulseBeat_02 said:

Hi, I was programming my mod, and I encountered a problem with textures. Recently, I renamed one of the package declarations, and eclipse messed up my class files, deleting the main mod reference file and my event subscriber class. Before, the textures worked, but now, they are just purple and black. Here is my GitHub: https://github.com/PulseBeat02/King-Mammoth-Mod

You never register any models...

[PulseBeat_02]

Ye, that's why I commented it out so it won't run. And by the way, this is what's showing up for me:

 

Edited August 12, 2019 by PulseBeat_02

[Animefan8888]

4 minutes ago, PulseBeat_02 said:

Ye, that's why I commented it out so it won't run.

Uhhh then what is the problem. If you don't register models of course the items look like that.

[PulseBeat_02]

Should the ModItems class contain all of my items and I should make a loop to register them in the registerModels?

[Animefan8888]

1 minute ago, PulseBeat_02 said:

Should the ModItems class contain all of my items and I should make a loop to register them in the registerModels?

Yes that is an appropriate way to do it. You'll also want to do that with all of your Blocks that have Items.

[PulseBeat_02]

@Animefan8888 It looks like the sword texture is loading, but nothing else.

 

 

Here's my updated code:

 

ModItems.java:

package pulsebeat_02.kingmammoth.init;

import pulsebeat_02.kingmammoth.item.MammothCore;
import pulsebeat_02.kingmammoth.item.MammothFur;
import pulsebeat_02.kingmammoth.item.MammothSword;
import pulsebeat_02.kingmammoth.item.armor.ItemKingMammothArmor;
import pulsebeat_02.kingmammoth.item.crown.KingMammothCrown;
import pulsebeat_02.kingmammoth.materials.KingMammothMaterials;

import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraftforge.fml.common.registry.GameRegistry.ObjectHolder;
import pulsebeat_02.kingmammoth.KingMammoth;

@ObjectHolder(KingMammoth.MODID)
public class ModItems {
	
	public static MammothSword mammoth_sword = new MammothSword(ToolMaterial.DIAMOND);
	
	public static ItemKingMammothArmor king_mammoth_boots = new ItemKingMammothArmor(KingMammothMaterials.mammoth_armor, EntityEquipmentSlot.FEET, "king_mammoth_boots");
	public static ItemKingMammothArmor king_mammoth_leggings = new ItemKingMammothArmor(KingMammothMaterials.mammoth_armor, EntityEquipmentSlot.LEGS, "king_mammoth_leggings");
	public static ItemKingMammothArmor king_mammoth_chestplate = new ItemKingMammothArmor(KingMammothMaterials.mammoth_armor, EntityEquipmentSlot.CHEST, "king_mammoth_chestplate");
	
	public static KingMammothCrown king_mammoth_crown = new KingMammothCrown(KingMammothMaterials.crown_model_material, EntityEquipmentSlot.HEAD);
	
	public static MammothFur mammoth_fur = new MammothFur();
	
	public static MammothCore mammoth_core = new MammothCore();

}

 

ModelRegistrationHandler.java:

package pulsebeat_02.kingmammoth.client;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import pulsebeat_02.kingmammoth.KingMammoth;
import pulsebeat_02.kingmammoth.init.ModItems;

@EventBusSubscriber(value = Side.CLIENT, modid = KingMammoth.MODID)
public class ModelRegistrationHandler {

	@SubscribeEvent
	public static void registerModels(ModelRegistryEvent event) {
		
		registerModel(ModItems.mammoth_sword, 0);
		
		registerModel(ModItems.king_mammoth_boots, 1);
		registerModel(ModItems.king_mammoth_leggings, 2);
		registerModel(ModItems.king_mammoth_chestplate, 3);
		
		registerModel(ModItems.king_mammoth_crown, 4);
		
		registerModel(ModItems.mammoth_core, 5);
		
		registerModel(ModItems.mammoth_fur, 6);
		
	}

	private static void registerModel(Item item, int meta) {
		
		ModelLoader.setCustomModelResourceLocation(item, meta,
				new ModelResourceLocation(item.getRegistryName(), "inventory"));
	}

}

 

Still the black and purple textures.

[Animefan8888]

1 minute ago, PulseBeat_02 said:

registerModel(ModItems.king_mammoth_boots, 1);

Why are you giving the models metadata values? You should keep them at 0.

[PulseBeat_02]

@Animefan8888

Changed them all to 0. Still purple and black.

[Animefan8888]

1 minute ago, PulseBeat_02 said:

Changed them all to 0. Still purple and black.

Post the log.

[PulseBeat_02]

debug.loglatest.log

[Animefan8888]

23 minutes ago, PulseBeat_02 said:

debug.log 562.91 kB · 2 downloads latest.log 12.72 kB · 1 download

Is your ModelRegistryEvent getting called?

[PulseBeat_02]

@Animefan8888 After adding a logger statement, i noticed that the logger statement isn't printing something out, which probably means that the code probably did not run, or not being called. How would I fix this?

[Animefan8888]

8 minutes ago, PulseBeat_02 said:

@Animefan8888 After adding a logger statement, i noticed that the logger statement isn't printing something out, which probably means that the code probably did not run, or not being called. How would I fix this?

Can you update your github?

[Draco18s]

1 hour ago, PulseBeat_02 said:

public static MammothSword mammoth_sword = new MammothSword(ToolMaterial.DIAMOND);

Don't use static initializers. Because they can be called at unpredictable times, Forge won't necessarily associate them with the correct mod.

[PulseBeat_02]

@Animefan8888 Updated it

@DaemonUmbra If I remove the static initializer, I can't register the model because it's in a separate class. Getters and Setters perhaps?

[DaemonUmbra]

1 minute ago, PulseBeat_02 said:

If I remove the static initializer, I can't register the model because it's in a separate class. Getters and Setters perhaps?

First, nice tab complete.

Second, I don't think that's how it works.

[Animefan8888]

20 minutes ago, PulseBeat_02 said:

Updated it

Ok the problem is the items you are registering are not the same items you are registering models for. Read up on the ObjectHolder annotation on the forge docs. 

[Draco18s]

10 hours ago, PulseBeat_02 said:

If I remove the static initializer, I can't register the model because it's in a separate class. Getters and Setters perhaps?

That would be wrong. First, the object holder annotation will fill the values in for you, and second you can initialize them with a value from anywhere you like, you just can do that from a static place. The fields can still be static, but you can't call new there.

[PulseBeat_02]

Ahh, I see what you are all saying. After adding @ObjectHolder("name here") to all the items, the textures were finally fixed and working. Thank you!

[Draco18s]

2 hours ago, PulseBeat_02 said:

Ahh, I see what you are all saying. After adding @ObjectHolder("name here") to all the items, the textures were finally fixed and working. Thank you!

You can also just apply it to a class. But it requires that the field names match the object's registry name exactly (except for cAse).