Jump to content

Recommended Posts

Posted (edited)
7 minutes ago, LoganJohnG said:

Block block = state.getBlock();

switch (block.getRegistryName().toString()) {

Oh jesus christ. There are like five better ways to do this.

 

Just two I can think of

 

block instanceof DoorBlock && block.getMaterial() == Material.WOOD

block == Blocks.ACACIA_DOOR || <the rest>

 

Just because something can be expressed as a string doesn't mean you should.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Thanks cleaned up the strings.

 

	@SubscribeEvent
	public void handleRightClickBlock(RightClickBlock event) {
		final BlockPos pos = event.getPos();
		final World world = event.getWorld();
		new java.util.Timer().schedule(new java.util.TimerTask() {
			@Override
			public void run() {
				IBlockState blockState = world.getBlockState(pos);
				if (null != blockState) {
					StateImplementation state = (StateImplementation) blockState;
					Block block = state.getBlock();
					if (block == Blocks.ACACIA_DOOR || block == Blocks.BIRCH_DOOR || block == Blocks.DARK_OAK_DOOR
							|| block == Blocks.IRON_DOOR || block == Blocks.JUNGLE_DOOR || block == Blocks.SPRUCE_DOOR
							|| block == Blocks.OAK_DOOR) {
						for (IProperty<?> p : state.getPropertyKeys()) {
							if (p.getName().equals("open")) {
								if ((boolean) state.getValue(p)) {
									System.out.println("Door is open");
								} else {
									System.out.println("Door is closed");
								}
								break;
							}
						}

					}
				}
			}
		}, 250 // ms
		);
	}

 

Posted
7 minutes ago, Tim Graupmann said:

for (IProperty<?> p : state.getPropertyKeys()) { if (p.getName().equals("open")) {

And instead of this you could do state.getValue(BlockStateProperties.OPEN) if you are in 1.14.4

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Congrats, you're learning things about outdated versions of both Minecraft and Forge

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Posted

And an oddball outdated version none the less.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)

Okay here's the first part. I checked into a public repository.

https://github.com/tgraupmann/MinecraftChromaMod

 

Currently it's just doing some print logging when events happen. I have another Chroma RGB to integrate once I have the events in place.

 

I'll see about upgrading Minecraft Forge next...

 

This is where the interesting code is.

https://github.com/tgraupmann/MinecraftChromaMod/blob/master/src/main/java/com/example/examplemod/MyForgeEventHandler.java

 

Grabbing the sample source and upgrading gradle, running the setup/etc.

https://mcforge.readthedocs.io/en/latest/gettingstarted/

 

Edited by Tim Graupmann
Posted (edited)

Okay it seems like the Minecraft Forge has trouble building with Oracle's JAVA.

 

C:\Users\timot\Downloads\forge-1.12.2-14.23.5.2844-mdk>gradlew.bat setupDecompWorkspace
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/2.14/userguide/gradle_daemon.html.
This mapping 'snapshot_20171003' was designed for MC 1.12! Use at your own peril.
#################################################
         ForgeGradle 2.3-SNAPSHOT-7764e3e
  https://github.com/MinecraftForge/ForgeGradle
#################################################
                 Powered by MCP
             http://modcoderpack.com
     by: Searge, ProfMobius, R4wk, ZeuX
     Fesh0r, IngisKahn, bspkrs, LexManos
#################################################
:deobfCompileDummyTask
:deobfProvidedDummyTask
:getVersionJson
:extractUserdev UP-TO-DATE
:extractDependencyATs SKIPPED
:extractMcpData SKIPPED
:extractMcpMappings SKIPPED
:genSrgs SKIPPED
:downloadClient SKIPPED
:downloadServer SKIPPED
:splitServerJar SKIPPED
:mergeJars SKIPPED
:deobfMcSRG SKIPPED
:decompileMc SKIPPED
:fixMcSources
:applySourcePatches
Patching failed: cp/MethodsReturnNonnullByDefault.java Cannot find hunk target
  1: Cannot find hunk target @ 0
  1/1 failed
:applySourcePatches FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':applySourcePatches'.
> com.cloudbees.diff.PatchException: Cannot find hunk target

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 32.666 secs

 

I upgraded gradle to the latest 5.6.1.

gradlew wrapper --gradle-version=5.6.1
gradlew -v

 

I had those same build errors for the latest MCF stable version, so I went right for the latest.

https://files.minecraftforge.net/maven/net/minecraftforge/forge/index_1.14.4.html

 

gradlew eclipse

 

This runs for a while...

Edited by Tim Graupmann
Posted

And it's working with the upgraded Chroma library.

 

First there's a C++ DLL and I have a tool that parses the C++ header to get all the nice helper functions and comments.

https://github.com/tgraupmann/ChromaAPISync/blob/master/bin/Debug/stdafx.h

 

And then the DLL interface library is generated.

https://github.com/tgraupmann/ChromaAPISync/blob/master/bin/Debug/JChromaLib.java

 

And then the wrapper Java is generated.

https://github.com/tgraupmann/ChromaAPISync/blob/master/bin/Debug/JChromaSDK.java

 

This gets copied over to the Java Chroma library.

https://github.com/tgraupmann/JChroma

 

And then it's ready for the Minecraft mod.

https://github.com/tgraupmann/MinecraftChromaMod/blob/master/src/main/java/com/example/examplemod/MyForgeEventHandler.java

 

This exposes the nice API from the guide to Java.

http://chroma.razer.com/ChromaGuide/

Posted (edited)

Here's a video where you can see it working.

 

 

Source code: https://github.com/tgraupmann/MinecraftChromaMod/blob/master/src/main/java/com/example/examplemod/MyForgeEventHandler.java

 

I'll add more Chroma effects for the various events as I figure things out...

 

Things to figure out:

* Attack with a sword

* Place a block

* Ride in a cart

* Crafting

* Destroy a block
* Climb a ladder

* Get hurt by a creeper

* Kill a pig

* Drink a potion

* Stand near a chicken

* Walk through a portal

* Place a fish

* Swim through bubbles

* Weather snow

* Weather rain

 

Edited by Tim Graupmann
Posted
10 minutes ago, Tim Graupmann said:

Place a block

BlockEvent.EntityPlaceEvent

12 minutes ago, Tim Graupmann said:

Crafting

PlayerEvent.ItemCraftedEvent

 

13 minutes ago, Tim Graupmann said:

Destroy a block

BlockEvent.Break

13 minutes ago, Tim Graupmann said:

Get hurt by a creeper

LivingDamageEvent and check if the LivingDamageEvent#getSource().getTrueSource() is an instance of CreeperEntity

 

15 minutes ago, Tim Graupmann said:

Kill a pig

LivingDeathEvent and check if the LivingDeathEvent#getEntityLiving() is an instance of PigEntity and also check LivingDeathEvent#getSource().getTrueSource() is an instanceof PlayerEntity.

18 minutes ago, Tim Graupmann said:

Stand near a chicken

You would have to use the PlayerTickEvent and use World#getEntitiesWithinAABB to check for ChickenEntity

 

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Thanks for the hints. I'm going to spend a day on those video Chroma widgets. It's hard to see on the side and I'll make it so they appear on top of the game so they can be bigger and easier to see the lighting patterns.

Posted

This is starting to go from "Support and Bug Reports" to "Mods" if you want to make a thread that advertises your mod please do so in the correct subforum instead of your support thread.

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.