[1.14.x] No Optional.Interface?

[eyeonus]

The modules have to be registered during initialization. The loading phase, the part before you get to the main menu. Whatever you want to call it. I call it init because it's 4 letters.

The modules have to be registered at the same time every other Minecraft item has to be registered, because otherwise they don't exist in the game and can't be crafted.

If it's something you want players to be able to craft, it has to be registered.

The distinction being made between "module" and "item" in my earlier post is to prevent confusion between talking about the item in MPS that acts as an interface to an item on another mod, and the item in the other mod. The modules ARE STILL ITEMS as far as Minecraft is concerned.

 

You can't pass an ItemStack to a method that doesn't take an ItemStack parameter.

 

I never said you can pass an item.

 

[Animefan8888]

2 minutes ago, eyeonus said:

The modules have to be registered at the same time every other Minecraft item has to be registered, because otherwise they don't exist in the game and can't be crafted.

Well you have to register all of these Module Items anyways. Don't conditionally register them.

3 minutes ago, eyeonus said:

You can't pass an ItemStack to a method that doesn't take an ItemStack parameter.

ItemUseContext has an ItemStack inside it. And ItemUseContext is what is passed to Item#onItemUse.

[eyeonus]

You are entirely missing the point.

 

I don't get to choose how the items in the mod are activated.

The vast majority, if not all, of the items in the other mods use

ItemStack modItem = playerIn.getHeldItem(handIn)

to determine what item has just been used.

Edited October 5, 2019 by eyeonus

[Animefan8888]

15 minutes ago, eyeonus said:

The vast majority, if not all, of the items in the other mods use

Then you get to be the person to tell them they are doing it wrong. It's passed in as a parameter and should be used as such. The only use case for them to use that method is in Item#onItemRightClick, but once again this doesn't matter. Imagine changing the ItemStack in that slot before before calling their items method. Yes you can totally do that. Just remember to change it back after you call it.

 

onItemRightClick(world, player, hand) {
  originalStack = player.getHeldItem(hand);
  stackWithModuleItem = new ItemStack(getActiveModuleItem(), 1);
  player.setHeldItem(hand, stackWithModuleItem);
  stackWithModuleItem.getItem().onItemRightClick(world, player, hand);
  player.setHeldItem(originalStack);
}

 

[eyeonus]

Yes, well, OnRightClick is exactly the use case I'm talking about, so they aren't doing it wrong.

 

I've already spoken with lehjr about going the Morph-O-Tool route and changing the item to be the item from the other mod. In his opinion, that is entirely too much work to be worth it, especially since in his view it's a unstable solution in laggy servers.

 

He's decided to make anything that requires another mod be in an addon package for the main mod, thus avoiding this problem altogether.

 

Thank you for your time.

[Draco18s]

2 hours ago, eyeonus said:

The vast majority, if not all, of the items in the other mods use

ItemStack modItem = playerIn.getHeldItem(handIn)

Uh. That's a stack, not an item.

[eyeonus]

Yes, thank you for that knee jerk, thoughtless comment that contributes nothing to the conversation.

[Draco18s]

11 hours ago, eyeonus said:

Yes, thank you for that knee jerk, thoughtless comment that contributes nothing to the conversation.

You still have not

16 hours ago, Draco18s said:

explained why you can't pass an ItemStack but can pass an Item.

 

[eyeonus]

16 hours ago, eyeonus said:

I never said you can pass an item.

 

[Draco18s]

5 minutes ago, eyeonus said:

I never said you can pass an item.

Ok. Then you did a bad job of explaining what you CAN do as you just stated over and over what you CAN'T do.

 

In trying to tease out what it is you CAN do from your posts....

 

You know you don't have to extend item and implement an interface on the same class, right? Put the interface stuff off in a soft-dependency area and when the interface methods get called, it can have a reference to your item and pass over (or get) the necessary details to do its thing.

[eyeonus]

No way! I can put code that does different things into different stuff? I never knew that.

</sarcasm>

 

Your comments have been universally useless. Goodbye.

Edited October 5, 2019 by eyeonus