[1.10.2] Object Holder not working

[Meldexun]

Hello,

I annotated my items class with @ObjectHolder(MOD_ID).

But it isn't injecting the item objects into the fields.

Does the ObjectHolder annotation only work for classes as of 1.12.2?

[RaphGamingz]

do you put your mod_id into the object holder? im not sure

[Animefan8888]

6 minutes ago, Meldexun said:

Does the ObjectHolder annotation only work for classes as of 1.12.2?

No.

 

3 minutes ago, RaphGamingz said:

do you put your mod_id into the object holder? im not sure

You should post your code. And yes your modid needs to be present.

[Meldexun]

1 minute ago, Animefan8888 said:

You should post your code.

Sure. Here it is:

@ObjectHolder(BetterDiving.MOD_ID)
public class ModItems {

	public static final Item TITANIUM = null;
	public static final Item COPPER_ORE = null;
	public static final Item SILVER_ORE = null;
	public static final Item LEAD = null;
	public static final Item GOLD = null;

	@EventBusSubscriber
	public static class ItemRegistrationHandler {

		public static final List<Item> ITEMS = new ArrayList<Item>();

		@SubscribeEvent
		public static void registerItems(RegistryEvent.Register<Item> event) {
			final Item[] items = {
					setItemName(new Item(), "titanium"),
					setItemName(new Item(), "copper_ore"),
					setItemName(new Item(), "silver_ore"),
					setItemName(new Item(), "lead"),
					setItemName(new Item(), "gold")
			};

			IForgeRegistry<Item> registry = event.getRegistry();

			for (Item item : items) {
				registry.register(item);
				ITEMS.add(item);
			}
		}

		private static Item setItemName(Item item, String name) {
			return setItemNameAndTab(item, name, BetterDiving.TAB_BETTER_DIVING);
		}

		private static Item setItemNameAndTab(Item item, String name, @Nullable CreativeTabs tab) {
			return item.setUnlocalizedName(name).setRegistryName(BetterDiving.MOD_ID, name).setCreativeTab(tab);
		}
	}

}

 

[Meldexun]

After some testing it seems like i have to annotate every field with @ObjectHolder.

Also looking at Choonster's TestMod3 i saw that he also annotated every field.

Edited October 11, 2019 by Meldexun

[RaphGamingz]

yea

[Draco18s]

25 minutes ago, Meldexun said:

After some testing it seems like i have to annotate every field with @ObjectHolder.

Also looking at Choonster's TestMod3 i saw that he also annotated every field.

Not true. Yes, you can do that, but it is not required.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L174

Just that the name-matching has to be exact (only ignoring case).

Edited October 11, 2019 by Draco18s

[Meldexun]

Probably naming the fields with lowercase letters is the key. But i already added an ObjectHolder annotation to my fields so i will stay with that.

[Draco18s]

1 hour ago, Meldexun said:

Probably naming the fields with lowercase letters is the key.

https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

    public static final Item ENDER_PEARL = null;    // Note that the actual name is "minecraft:ender_pearl", not "minecraft:ENDER_PEARL".
                                                    // However, since constructing a ResourceLocation lowerc

 

[Meldexun]

On 10/12/2019 at 3:05 AM, Draco18s said:

https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

    public static final Item ENDER_PEARL = null;    // Note that the actual name is "minecraft:ender_pearl", not "minecraft:ENDER_PEARL".
                                                    // However, since constructing a ResourceLocation lowerc

 

Well that's 1.12.2 not 1.10.2. Also when lowercasing the names of the fields it works as well as annotating the fields but leaving them uppercase doesn't work.

Edited October 13, 2019 by Meldexun