1.12 BreakEvent and HarvestDropsEvent conflict NPE

[X_Khan_X]

I have an autosmelt class

public class AutosmeltEvent {

	@SubscribeEvent(priority = EventPriority.LOW)
	public static void onAutosmeltUse(HarvestDropsEvent event) {
		EntityPlayer player = (EntityPlayer) event.getHarvester();
		ItemStack hand = player.inventory.getCurrentItem();
		Map<Enchantment, Integer> autosmelt = EnchantmentHelper.getEnchantments(hand);
		if (autosmelt.isEmpty() || !autosmelt.containsKey(InitEnchants.AUTOSMELT))
			return;
		int autosmeltlevel = autosmelt.get(InitEnchants.AUTOSMELT);
		Block block = event.getState().getBlock();
		@SuppressWarnings("unused")
		IBlockState state = event.getState();
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		ItemStack smelt = FurnaceRecipes.instance().getSmeltingResult(new ItemStack(block));
		smelt.setCount(1);
		ItemStack out = smelt.copy();
		if (autosmeltlevel == 1) {
			if (smelt.getItem() == Item.getItemFromBlock(Blocks.AIR) && !player.capabilities.isCreativeMode) {
				world.destroyBlock(pos, true);
			}
			if (block != null) {
				world.setBlockToAir(pos);
				event.getDrops().clear();
				event.getDrops().add(out);
				player.addExperience(1);
			}
		}
	}
}

that works with the enchant and an excavate class

public class ExcavateEvent {

	@SubscribeEvent(priority = EventPriority.NORMAL)
	public static void onExcavateUse(BlockEvent.BreakEvent event) {
		EntityPlayer player = (EntityPlayer) event.getPlayer();
		ItemStack hand = player.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND);
		Map<Enchantment, Integer> excavate = EnchantmentHelper.getEnchantments(hand);
		if (excavate.isEmpty() || !excavate.containsKey(InitEnchants.EXCAVATE))
			return;
		int excavatelevel = excavate.get(InitEnchants.EXCAVATE);
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		Block block = event.getState().getBlock();
		if (excavatelevel > 0) {
			for (int i = 0; i < (excavatelevel + 1); i++) {
				Iterable<BlockPos> it = BlockPos.getAllInBox(pos.add(-i, -i, -i), pos.add(i, i, i));
				for (BlockPos offset2 : it) {
					Block block2 = world.getBlockState(offset2).getBlock();
					if (block2 == block && block2 != Blocks.AIR) {
						try {
							world.destroyBlock(offset2, true);
							hand.damageItem(1, player);
						} catch (Exception e) {
							e.printStackTrace();
						}
					}
				}
			}
		}
	}
}

which gives me problems when I use the excavate enchant (without autosmelt on the pickaxe)

 

java.lang.NullPointerException: null
	at com.mod.modcore.events.enchantment.AutosmeltEvent.onAutosmeltUse(AutosmeltEvent.java:30) ~[AutosmeltEvent.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_17_AutosmeltEvent_onAutosmeltUse_HarvestDropsEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
	at net.minecraftforge.event.ForgeEventFactory.fireBlockHarvesting(ForgeEventFactory.java:321) [ForgeEventFactory.class:?]
	at net.minecraft.block.Block.dropBlockAsItemWithChance(Block.java:721) [Block.class:?]
	at net.minecraft.block.BlockOre.dropBlockAsItemWithChance(BlockOre.java:92) [BlockOre.class:?]
	at net.minecraft.block.Block.dropBlockAsItem(Block.java:710) [Block.class:?]
	at net.minecraft.world.World.destroyBlock(World.java:477) [World.class:?]
	at com.mod.modcore.events.enchantment.ExcavateEvent.onExcavateUse(ExcavateEvent.java:42) [ExcavateEvent.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_ExcavateEvent_onExcavateUse_BreakEvent.invoke(.dynamic) [?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) [ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
	at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:838) [ForgeHooks.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.tryHarvestBlock(PlayerInteractionManager.java:309) [PlayerInteractionManager.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.blockRemoving(PlayerInteractionManager.java:261) [PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:732) [NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) [CPacketPlayerDigging.class:?]
	at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) [CPacketPlayerDigging.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) [PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_221]
	at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_221]
	at net.minecraft.util.Util.runTask(Util.java:53) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_221]

I know, the solution may be very very simple but I dont know why it throw me an error when breaking blocks

 

AutosmeltEvent line 30:

ItemStack hand = player.inventory.getCurrentItem();

 

ExcavateEvent line 42:

world.destroyBlock(offset2, true);

 

[Animefan8888]

32 minutes ago, X_Khan_X said:

@SuppressWarnings("unused") IBlockState state = event.getState();

Why?

 

32 minutes ago, X_Khan_X said:

NullPointerException: null at com.mod.modcore.events.enchantment.AutosmeltEvent.onAutosmeltUse(AutosmeltEvent.java:30)

Something is null on line 30.

[X_Khan_X]

14 minutes ago, Animefan8888 said:

Why?

 

Something is null on line 30.

The suppress warning is useless, need to remove the state.

 

The line 30 is the hand item

 

Edit: System.out.print(event.getHarvester()); prints me and null at the same time

Edited October 28, 2019 by X_Khan_X

[Draco18s]

10 minutes ago, X_Khan_X said:

Edit: System.out.print(event.getHarvester()); prints me and null at the same time

Either:
a) one is client side and one is server side

b) two separate, unrelated events (tall grass getting broken fires a harvest drops event).

 

There might be a reason for this line in my code...

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/ores/OreEventHandler.java#L74

[DavidM]

3 hours ago, X_Khan_X said:

The suppress warning is useless, need to remove the state.

Just remove the unused variable...