onItemRightClick return an item [1.15.1]

[Dr.Nickenstein]

So I want this item to check the block that it hits on right click, and if it is a certain block, it returns a certain item

 

Edited March 11, 2020 by Dr.Nickenstein
forgot the version

[Cerandior]

  On 3/11/2020 at 8:59 PM, Dr.Nickenstein said:

So I want this item to check the block that it hits on right click, and if it is a certain block, it returns a certain item

 

Expand  

Don't do it on the item, do it on the block. If it is your block override onBlockActivated and check if the player is holding your item. If it is a vanilla block use events to achieve the same thing.

[Dr.Nickenstein]

  On 3/11/2020 at 9:47 PM, Cerandior said:

Don't do it on the item, do it on the block. If it is your block override onBlockActivated and check if the player is holding your item. If it is a vanilla block use events to achieve the same thing.

Expand  

How do I do it?

[Cerandior]

This certain block, is it one of your own blocks or is it a vanilla block?

[Dr.Nickenstein]

  On 3/12/2020 at 9:34 AM, Cerandior said:

This certain block, is it one of your own blocks or is it a vanilla block?

Expand  

Yes, it is. It's called "RubberStreamingRubberWoodLog", that's the class that I created.

 

Edited March 12, 2020 by Dr.Nickenstein
unmentioned content

[Cerandior]

  On 3/12/2020 at 9:45 AM, Dr.Nickenstein said:

Yes, it is. It's called "RubberStreamingRubberWoodLog", that's the class that I created.

 

Expand  

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

Edited March 12, 2020 by Cerandior

[Dr.Nickenstein]

  On 3/12/2020 at 10:40 AM, Cerandior said:

Then go to your block class, override onBlockActivated and check there if the player is holding your item. If it is, do stuff. onBlockActivated provides you with the player that right clicked the block and the hand he used, so you have pretty much all you need.

 

Alternatively, you can subscribe to PlayerInteractEvent.RightClickBlock and check there if the player is holding your item.

Expand  

so this? player.getHeldItem(handIn); and then how do i check which item it is?

Edited March 12, 2020 by Dr.Nickenstein

[Cerandior]

  On 3/12/2020 at 10:44 AM, Dr.Nickenstein said:

so this? player.getHeldItem(handIn); and then how do i check which item it is?

Expand  

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

[Dr.Nickenstein]

  On 3/12/2020 at 10:46 AM, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Expand  

Yeah i want this block to drop a certain item when it is right clicked (activated) with another item.

[Dr.Nickenstein]

  On 3/12/2020 at 10:46 AM, Cerandior said:

That will return an itemstack I believe. 
itemstack.getItem() will give you the item and then you use instanceof to check whether that item is the same with what you want or not.

Expand  

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

Edited March 12, 2020 by Dr.Nickenstein

[Cerandior]

  On 3/12/2020 at 10:54 AM, Dr.Nickenstein said:

@Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player,
            Hand handIn, BlockRayTraceResult hit)
    {    
        ItemStack itemstack = player.getHeldItem(handIn);
        itemstack.getItem();
        if
        {
            itemstack = ItemInit.RUBBER_EXTRACTOR.get();
        }
        
    }
   

I've done this, but on itemstack = ItemInit.RUBBER_EXTRACTOR.get(); it gives me an error it says it can't convert from ItemStack to Item. How do I fix it?

The problem is item and itemstack are different things apparently, and the methods work with itemstack. Help

Expand  

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 

Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:

if(condition){
statement
}

 

[Dr.Nickenstein]

  On 3/12/2020 at 11:04 AM, Cerandior said:

 

I have no clue what the hell are you doing there. Don't mean to insult you, but based on that I am assuming you don't have much experience with programming in general.

I'll help you this time and write it for you, but you will not get far if you don't know much programming.
 

Item item = player.getHeldItem(handIn).getItem();

if(item instanceof ItemInit.RUBBER_EXTRACTOR){
	//Do stuff
}

 

What you did wrong before:
1) itemstack.getItem() returns an item and does nothing else. Simply calling it and not assigning the returned value anywhere means that line of code is pretty much useless.

2) That is not how you use if statements. The syntax is:

if(condition){
statement
}

 

Expand  

For the second error, i corrected it later but didn't correct the post with it, for the first one thanks. BTW wehn you do (item instanceof ItemInit.RUBBER_EXTRACTOR)

{

stuff

}

it says rubber extractor isn't a type, and I can't reference any kind of other items

Edited March 12, 2020 by Dr.Nickenstein

[Draco18s]

  On 3/12/2020 at 11:07 AM, Dr.Nickenstein said:

item instanceof ItemInit.RUBBER_EXTRACTOR

Expand  

Sigh.

Let me break this down.

X instanceof Y requires X to be an object and Y to be a Class.

X == Y requires X to be an object (or primative) and Y to be an object (or primative).

Your code, item instanceof ItemInit.RUBBER_EXTRACTOR, has X is an object, Y is an object.