error: code too large

[N/A]

I am making a mod that adds Terraria into Minecraft. To start, I registered all 3991 items into the game. However, when I try and run the game, the build fails with this error: 

C:Myfilesandstuff\ModEventSubscriber.java:13: error: code too large
    public static void onRegisterItems(RegistryEvent.Register<Item> event) {

Any idea for a workaround?

[Ugdhar]

Post logs please, and a link to code, preferably a github repo that can be cloned/build/debugged

[N/A]

  On 4/6/2020 at 6:09 PM, diesieben07 said:

A method in Java can only be 64KB of bytecode.

Your methods are too big.

WTF are you doing? Did you literally write out 3991 items by hand?! Instead of using some kind of loop or something?

Expand  

I used Google Sheets to pull the item names from the wiki, replace the spaces with underscores, and convert all letters to lowercase. Then I used Sheets to add the register item thing around each one and pasted it into IntelliJ

Edited April 6, 2020 by N/A

[N/A]

  On 4/6/2020 at 6:07 PM, Ugdhar said:

Post logs please, and a link to code, preferably a github repo that can be cloned/build/debugged

Expand  

Ok, the github repo is here: https://github.com/SimplyCmd/Terracraft

Also, the only log is right here:

> Task :compileJava
C:\Blablabla\src\main\java\io\github\simplycmd\terracraft\ModEventSubscriber.java:13: error: code too large
    public static void onRegisterItems(RegistryEvent.Register<Item> event) { // Tells Forge that you want this method to be called when it is time for your mod to register its items.
                       ^
1 error

> Task :compileJava FAILED

 

[N/A]

  On 4/6/2020 at 6:11 PM, diesieben07 said:

yeah... dont do that.

Expand  

Hmmm... Is there a way to break it up into multiple files or methods?

Edited April 6, 2020 by N/A

[N/A]

https://en.wikipedia.org/wiki/Don't_repeat_yourself

Edited April 6, 2020 by N/A

[Draco18s]

Also, your names aren't all lower case.

setup(new Item(new Item.Properties()),"IronPickaxe"),

Also, do you really need to add a new iron pickaxe item to Minecraft? We already have one.

And mushrooms, torches, dirt blocks, various swords, axes, ores, arrows, chests...

 

Edit, I think these items are my favorites:

https://github.com/SimplyCmd/Terracraft/blob/master/main/java/io/github/simplycmd/terracraft/ModEventSubscriber.java#L3989-L4000

Edited April 6, 2020 by Draco18s

[N/A]

  On 4/6/2020 at 6:19 PM, Draco18s said:

Also, your names aren't all lower case.

setup(new Item(new Item.Properties()),"IronPickaxe"),

Also, do you really need to add a new iron pickaxe item to Minecraft? We already have one.

And mushrooms, torches, dirt blocks, various swords, axes, ores, arrows, chests...

 

Edit, I think these items are my favorites:

https://github.com/SimplyCmd/Terracraft/blob/master/main/java/io/github/simplycmd/terracraft/ModEventSubscriber.java#L3989-L4000

Expand  

Sorry, that was outdated from last night. I pushed the most recent commit. Just refresh the page

[Animefan8888]

  On 4/6/2020 at 6:17 PM, N/A said:

https://en.wikipedia.org/wiki/Don't_repeat_yourself

Expand  

Yes. Sadly you are repeating yourself an awful lot.

 

Imagine

for (type in tool_types) // COPPER/TIN, IRON/LEAD, etc

    setup(new Item(new Item.Properties()), type + "_pickaxe");

    setup(new Item(new Item.Properties()), type + "_axe");

    // ETC

[N/A]

  On 4/6/2020 at 6:40 PM, Animefan8888 said:

Yes. Sadly you are repeating yourself an awful lot.

 

Imagine

for (type in tool_types) // COPPER/TIN, IRON/LEAD, etc

    setup(new Item(new Item.Properties()), type + "_pickaxe");

    setup(new Item(new Item.Properties()), type + "_axe");

    // ETC

Expand  

Good idea. If I did that, would it fix the error?

[Animefan8888]

  On 4/6/2020 at 6:43 PM, N/A said:

Good idea. If I did that, would it fix the error?

Expand  

If you did it for all types of the items. Like the furniture and the wood, etc.

[N/A]

Ok, thanks for the help!