My mod changes player's height on every tick.

So I use EntityEvent.EyeHeight#SetNewHeight method.

I want to fire the event on every tick.

This cord doesn't work.

What's wrong?

@SubscribeEvent
  public static void sethitboxPlayer(TickEvent.PlayerTickEvent event) {
    float hitboxScale = event.player.getHeight() * scale;
    AxisAlignedBB playerBoundingBox = event.player.getBoundingBox();
    event.player.setBoundingBox(new AxisAlignedBB(playerBoundingBox.minX, playerBoundingBox.minY, playerBoundingBox.minZ, playerBoundingBox.maxX, playerBoundingBox.minY + hitboxScale, playerBoundingBox.maxZ));
    
    Pose pose = event.player.getPose();
    EntitySize size = event.player.getSize(pose);
    net.minecraftforge.event.entity.EntityEvent.EyeHeight evt = new net.minecraftforge.event.entity.EntityEvent.EyeHeight(event.player, pose, size, event.player.getEyeHeight(pose));
    net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(evt);
  }

 

Just because you fired the event doesn't mean Forge is listening. And Forge is never listening to its own events. Events are for mods to listen to and do what they want.

 

(read: that's not how you set the eye height)

Sorry for my lack of explanation.

I set the eye height by this cord.

It works, but it fires only when the pose changes.

Can't I fire Forge events manually in my mod?

@SubscribeEvent
  public static void setEyePlayer(EntityEvent.EyeHeight event) {
    if (event.getEntity() instanceof PlayerEntity) {
      PlayerEntity player = (PlayerEntity) event.getEntity();
      event.setNewHeight(event.getOldHeight() * scale);
    }
  }

 

10 minutes ago, kyazuki said:

Can't I fire Forge events manually in my mod?

You can; however, that is not what you want to do in this case.

Why do you want to change the eye height every tick? What are you trying to achieve?

AFAIK you only need to change the eye height when the event fires, as the event is used for all cases of determining an entity's eye height.

 

31 minutes ago, Draco18s said:

And Forge is never listening to its own events.

I think there are a few exceptions such as ForgeInternalHandler.

Edited April 9, 20205 yr by DavidM

10 minutes ago, kyazuki said:

Can't I fire Forge events manually in my mod?

Yes you can. However you fire the event and your event only sets the events new height. It doesn't actually set the eye height. When the event is normally fired you'll notice that after it has fired forge takes the new eye height from the event and uses that.

3 minutes ago, DavidM said:

I think there are a few exceptions such as ForgeInternalHandler.

Fair enough, but in general, Forge fires events and doesn't listen for them.

  

20 minutes ago, DavidM said:

Why do you want to change the eye height every tick? What are you trying to achieve?

My mod makes player tall as the player walks.

@SubscribeEvent
  public static void calc(TickEvent.PlayerTickEvent event) {
    if (!event.player.world.isRemote()) {
      walkDistance = event.player.distanceWalkedModified / 0.6f;
      scale = walkDistance * 0.001f + minScale;
    }
  }

However, I can't access player's height.

So I change render scale, hitbox and eye height.

@SubscribeEvent
  public static void onRenderPlayerPre(RenderPlayerEvent.Pre event) {
    event.getMatrixStack().push();
    event.getMatrixStack().scale(1.0f, scale, 1.0f);
  }

  @SubscribeEvent
  public static void onRenderPlayerPost(RenderPlayerEvent.Post event) {
    event.getMatrixStack().pop();
  }

@SubscribeEvent
  public static void sethitboxPlayer(TickEvent.PlayerTickEvent event) {
    float hitboxScale = event.player.getHeight() * scale;
    AxisAlignedBB playerBoundingBox = event.player.getBoundingBox();
    event.player.setBoundingBox(new AxisAlignedBB(playerBoundingBox.minX, playerBoundingBox.minY, playerBoundingBox.minZ, playerBoundingBox.maxX, playerBoundingBox.minY + hitboxScale, playerBoundingBox.maxZ));
    //Fire EyeHeightEvent
  }

@SubscribeEvent
  public static void setEyePlayer(EntityEvent.EyeHeight event) {
    if (event.getEntity() instanceof PlayerEntity) {
      PlayerEntity player = (PlayerEntity) event.getEntity();
      event.setNewHeight(event.getOldHeight() * scale);
    }
  }

 

Edited April 9, 20205 yr by kyazuki

You can subscribe to PlayerTickEvent and manually change Entity::eyeHeight to fit your need. After that, simply simulate what Entity#recalculateSize does on the PlayerEntity.

5 minutes ago, DavidM said:

You can subscribe to PlayerTickEvent and manually change Entity::eyeHeight to fit your need. After that, simply simulate what Entity#recalculateSize does on the PlayerEntity.

Entity::eyeHeight is private...

8 minutes ago, kyazuki said:

Entity::eyeHeight is private...

Use reflection.

3 hours ago, DavidM said:

Use reflection.

Thanks!