Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

After I remade my registration system again (for causes see my comments at [1.16.1] The Book of Minecraft Modding - complete guide for beginners), 

the game now crashes with the main problem: java.lang.NullPointerException: Registry Object not present: ores_cores:emoulrite_block

 

debug.log:

debug.log

 

I cut out the imports in the source code

 

RegisterBlocks.java:

package maxi.ores_cores.init;

@EventBusSubscriber(modid = OresCores.MODID, bus = Bus.MOD)
public class RegisterBlocks {

	@SubscribeEvent
	public static void registerBlock(Register<Block> event) {
		
	  event.getRegistry().registerAll(
				
		new SimpleBlock(OresCores.MODID, "emoulrite_block", Properties.create(Material.IRON, MaterialColor.GOLD).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "emoulrite_ore", Properties.create(Material.ROCK, MaterialColor.STONE).sound(SoundType.STONE).hardnessAndResistance(3f, 3f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleBlock(OresCores.MODID, "telerite_block", Properties.create(Material.IRON, MaterialColor.PURPLE).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "telerite_ore", Properties.create(Material.ROCK, MaterialColor.SAND).sound(SoundType.STONE).hardnessAndResistance(4f, 9f).harvestTool(ToolType.PICKAXE).harvestLevel(2))
		
	  );
	}
	
	@SubscribeEvent
	public static void registerItem(Register<Item> event) {
		
	  event.getRegistry().registerAll(
		
		new SimpleBlockItem(Blocks.EMOULRITE_BLOCK, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.EMOULRITE_ORE, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_BLOCK, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_ORE, ItemGroup.BUILDING_BLOCKS)
		
	  );
	}
}

 

SimpleBlock.java (SimpleOreBlock is similar):

package maxi.ores_cores.blocks;

public class SimpleBlock extends Block {

	public SimpleBlock(Properties properties) {
		super(properties);
	}
	
	public SimpleBlock(String modid, String name, Properties properties) {
		super(properties);
		this.setRegistryName(modid, name);
	}
	
}

 

Blocks.java:

package maxi.ores_cores.blocks;

public class Blocks {
	
	public static final Block EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS).get();
	public static final Block EMOULRITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_ore"), ForgeRegistries.BLOCKS).get();
	public static final Block TELERITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_block"), ForgeRegistries.BLOCKS).get();
	public static final Block TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS).get();

}

 

SimpleBlockItem.java:

package maxi.ores_cores.items;

public class SimpleBlockItem extends BlockItem {

	public SimpleBlockItem(Block block, ItemGroup group) {
		super(block, new Properties().group(group));
		this.setRegistryName(block.getRegistryName());
	}

}

 

My guess is that the static fields at Blocks.java are initialized before the block registry event is fired, therefore the blocks that I try to get doesn´t exist.

You created your blocks in the block registry, but you are actually assigning null values in Blocks.java because the block registry is called after.

3 hours ago, Maxi07 said:

public static final Block TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS).get();

  

8 hours ago, diesieben07 said:

You cannot just call get() on your registry objects in a static initializer. They are not initialized by then. In general do not store the result of get(), just call get() when you need the block/item/etc.

Also: You cannot add features in FMLLoadCompleteEvent. Use FMLCommonSetupEvent and DeferredWorkQueue.

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author
9 hours ago, Draco18s said:

In general do not store the result of get(), just call get() when you need the block/item/etc.

Thanks!

  • Maxi07 changed the title to [1.16.1] Block Registration
  • Author
9 hours ago, Draco18s said:

do not store the result of get(), just call get() when you need the block/item/etc.

Now it is crashing again, but a bit differently:

debug.log

 

RegisterBlocks.java:

package maxi.ores_cores.init;

@EventBusSubscriber(modid = OresCores.MODID, bus = Bus.MOD)
public class RegisterBlocks {

	@SubscribeEvent
	public static void registerBlock(Register<Block> event) {
		
	  event.getRegistry().registerAll(
				
		new SimpleBlock(OresCores.MODID, "emoulrite_block", Properties.create(Material.IRON, MaterialColor.GOLD).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "emoulrite_ore", Properties.create(Material.ROCK, MaterialColor.STONE).sound(SoundType.STONE).hardnessAndResistance(3f, 3f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleBlock(OresCores.MODID, "telerite_block", Properties.create(Material.IRON, MaterialColor.PURPLE).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "telerite_ore", Properties.create(Material.ROCK, MaterialColor.SAND).sound(SoundType.STONE).hardnessAndResistance(4f, 9f).harvestTool(ToolType.PICKAXE).harvestLevel(2))
		
	  );
	}
	
	@SubscribeEvent
	public static void registerItem(Register<Item> event) {
		
	  event.getRegistry().registerAll(
		
		new SimpleBlockItem(Blocks.EMOULRITE_BLOCK.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.EMOULRITE_ORE.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_BLOCK.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_ORE.get(), ItemGroup.BUILDING_BLOCKS)
		
	  );
	}
}

 

Blocks.java:

package maxi.ores_cores.blocks;

public class Blocks {
	
	public static final RegistryObject<Block> EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> EMOULRITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_ore"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> TELERITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_block"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);
}

 

Quote

You cannot just call get() on your registry objects in a static initializer. They are not initialized by then

You should only assign their values when they are being registered. (

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

is null when you call it there

)

Edited by poopoodice

  • Author

What part of my code is wrong? The block are initialized in the registry event, and then I try get the block outside the registry event with .get()

  • Author
14 minutes ago, poopoodice said:

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

is null when you call it there

 

14 minutes ago, poopoodice said:

call it

.get() or

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

?

Edited by Maxi07

  • Author
2 minutes ago, poopoodice said:

public static final Block EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS).get();

This is outdated... I dont call .get() there. Only later in the item event (which is fired after the block event). Aren't the advantages of RegistryObject, that the Block is only quarried when I call .get()?

(Sorry for bad english)

  • Author
2 minutes ago, diesieben07 said:

Store the RegistryObject in the fields, not the Blocks.

That is what I do:

48 minutes ago, Maxi07 said:

public static final RegistryObject<Block> EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS);

 

  • Author

I dont know anything about github and repos...

Should I learn it now or are there other ways too?

  • Author
24 minutes ago, diesieben07 said:

You should either use DeferredRegister (which returns RegistryObject)

Do you mean I should switch inertly switch to DeferredRegister? Or what should I change?

  • Author

Now I switched entirely to DeferredRegisters and everything works fine

Edited by Maxi07

  • Maxi07 changed the title to [Solved] [1.16.1] Block Registration

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.