[Solved] [1.16.1] Block Registration

[Maxi07]

After I remade my registration system again (for causes see my comments at [1.16.1] The Book of Minecraft Modding - complete guide for beginners), 

the game now crashes with the main problem: java.lang.NullPointerException: Registry Object not present: ores_cores:emoulrite_block

 

debug.log:

debug.log

 

I cut out the imports in the source code

 

RegisterBlocks.java:

package maxi.ores_cores.init;

@EventBusSubscriber(modid = OresCores.MODID, bus = Bus.MOD)
public class RegisterBlocks {

	@SubscribeEvent
	public static void registerBlock(Register<Block> event) {
		
	  event.getRegistry().registerAll(
				
		new SimpleBlock(OresCores.MODID, "emoulrite_block", Properties.create(Material.IRON, MaterialColor.GOLD).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "emoulrite_ore", Properties.create(Material.ROCK, MaterialColor.STONE).sound(SoundType.STONE).hardnessAndResistance(3f, 3f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleBlock(OresCores.MODID, "telerite_block", Properties.create(Material.IRON, MaterialColor.PURPLE).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "telerite_ore", Properties.create(Material.ROCK, MaterialColor.SAND).sound(SoundType.STONE).hardnessAndResistance(4f, 9f).harvestTool(ToolType.PICKAXE).harvestLevel(2))
		
	  );
	}
	
	@SubscribeEvent
	public static void registerItem(Register<Item> event) {
		
	  event.getRegistry().registerAll(
		
		new SimpleBlockItem(Blocks.EMOULRITE_BLOCK, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.EMOULRITE_ORE, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_BLOCK, ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_ORE, ItemGroup.BUILDING_BLOCKS)
		
	  );
	}
}

 

SimpleBlock.java (SimpleOreBlock is similar):

package maxi.ores_cores.blocks;

public class SimpleBlock extends Block {

	public SimpleBlock(Properties properties) {
		super(properties);
	}
	
	public SimpleBlock(String modid, String name, Properties properties) {
		super(properties);
		this.setRegistryName(modid, name);
	}
	
}

 

Blocks.java:

package maxi.ores_cores.blocks;

public class Blocks {
	
	public static final Block EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS).get();
	public static final Block EMOULRITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_ore"), ForgeRegistries.BLOCKS).get();
	public static final Block TELERITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_block"), ForgeRegistries.BLOCKS).get();
	public static final Block TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS).get();

}

 

SimpleBlockItem.java:

package maxi.ores_cores.items;

public class SimpleBlockItem extends BlockItem {

	public SimpleBlockItem(Block block, ItemGroup group) {
		super(block, new Properties().group(group));
		this.setRegistryName(block.getRegistryName());
	}

}

 

My guess is that the static fields at Blocks.java are initialized before the block registry event is fired, therefore the blocks that I try to get doesn´t exist.

[poopoodice]

You created your blocks in the block registry, but you are actually assigning null values in Blocks.java because the block registry is called after.

[Draco18s]

3 hours ago, Maxi07 said:

public static final Block TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS).get();

  

8 hours ago, diesieben07 said:

You cannot just call get() on your registry objects in a static initializer. They are not initialized by then. In general do not store the result of get(), just call get() when you need the block/item/etc.

Also: You cannot add features in FMLLoadCompleteEvent. Use FMLCommonSetupEvent and DeferredWorkQueue.

 

[Maxi07]

9 hours ago, Draco18s said:

In general do not store the result of get(), just call get() when you need the block/item/etc.

Thanks!

[Maxi07]

9 hours ago, Draco18s said:

do not store the result of get(), just call get() when you need the block/item/etc.

Now it is crashing again, but a bit differently:

debug.log

 

RegisterBlocks.java:

package maxi.ores_cores.init;

@EventBusSubscriber(modid = OresCores.MODID, bus = Bus.MOD)
public class RegisterBlocks {

	@SubscribeEvent
	public static void registerBlock(Register<Block> event) {
		
	  event.getRegistry().registerAll(
				
		new SimpleBlock(OresCores.MODID, "emoulrite_block", Properties.create(Material.IRON, MaterialColor.GOLD).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "emoulrite_ore", Properties.create(Material.ROCK, MaterialColor.STONE).sound(SoundType.STONE).hardnessAndResistance(3f, 3f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleBlock(OresCores.MODID, "telerite_block", Properties.create(Material.IRON, MaterialColor.PURPLE).sound(SoundType.METAL).hardnessAndResistance(5f, 6f).harvestTool(ToolType.PICKAXE).harvestLevel(2)),
		new SimpleOreBlock(OresCores.MODID, "telerite_ore", Properties.create(Material.ROCK, MaterialColor.SAND).sound(SoundType.STONE).hardnessAndResistance(4f, 9f).harvestTool(ToolType.PICKAXE).harvestLevel(2))
		
	  );
	}
	
	@SubscribeEvent
	public static void registerItem(Register<Item> event) {
		
	  event.getRegistry().registerAll(
		
		new SimpleBlockItem(Blocks.EMOULRITE_BLOCK.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.EMOULRITE_ORE.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_BLOCK.get(), ItemGroup.BUILDING_BLOCKS),
		new SimpleBlockItem(Blocks.TELERITE_ORE.get(), ItemGroup.BUILDING_BLOCKS)
		
	  );
	}
}

 

Blocks.java:

package maxi.ores_cores.blocks;

public class Blocks {
	
	public static final RegistryObject<Block> EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> EMOULRITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_ore"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> TELERITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_block"), ForgeRegistries.BLOCKS);
	public static final RegistryObject<Block> TELERITE_ORE = RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);
}

 

[poopoodice]

Quote

You cannot just call get() on your registry objects in a static initializer. They are not initialized by then

You should only assign their values when they are being registered. (

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

is null when you call it there

)

Edited August 6, 2020 by poopoodice

[Maxi07]

What part of my code is wrong? The block are initialized in the registry event, and then I try get the block outside the registry event with .get()

[Maxi07]

14 minutes ago, poopoodice said:

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

is null when you call it there

 

14 minutes ago, poopoodice said:

call it

.get() or

RegistryObject.of(new ResourceLocation(OresCores.MODID, "telerite_ore"), ForgeRegistries.BLOCKS);

?

Edited August 6, 2020 by Maxi07

[poopoodice]

Sorry did not see the updated code.

Edited August 6, 2020 by poopoodice

[Maxi07]

2 minutes ago, poopoodice said:

public static final Block EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS).get();

This is outdated... I dont call .get() there. Only later in the item event (which is fired after the block event). Aren't the advantages of RegistryObject, that the Block is only quarried when I call .get()?

(Sorry for bad english)

[Maxi07]

2 minutes ago, diesieben07 said:

Store the RegistryObject in the fields, not the Blocks.

That is what I do:

48 minutes ago, Maxi07 said:

public static final RegistryObject<Block> EMOULRITE_BLOCK = RegistryObject.of(new ResourceLocation(OresCores.MODID, "emoulrite_block"), ForgeRegistries.BLOCKS);

 

[Maxi07]

I dont know anything about github and repos...

Should I learn it now or are there other ways too?

[Maxi07]

Okay, now I created a new repository and uploaded a few files. I hope this is what you need

https://github.com/07maxi/OresCores

[Maxi07]

24 minutes ago, diesieben07 said:

You should either use DeferredRegister (which returns RegistryObject)

Do you mean I should switch inertly switch to DeferredRegister? Or what should I change?

[FrostDracony]

Yes, pls try using the DeferredRegister. You will find a lot of questions and answers on how this works. If not:
https://thebookofmodding.ml/adding-custom-blocks/

Or on YT:
 

Now try you self.

Edited August 6, 2020 by FrostDracony

[Maxi07]

Now I switched entirely to DeferredRegisters and everything works fine

Edited August 6, 2020 by Maxi07