Jump to content

[1.15.2]insertItem this is wierd


Mightydanp
 Share

Recommended Posts

Ok so this might be simple to explain. This works as intended puts item into that slot
 

if (SlotCircuit.getValidItems().contains(handStack.getItem())) {
                    if (slotHandler.getStackInSlot(0).isEmpty()) {
                        slotHandler.insertItem(0, handStack, false);
                    }
                }

 

Below code doesnt put item in slot but deletes item in hand..... why does it not put item into the slot when i put a line of code after it?
 

if (SlotCircuit.getValidItems().contains(handStack.getItem())) {
                    if (slotHandler.getStackInSlot(0).isEmpty()) {
                        slotHandler.insertItem(0, handStack, false);
                        handStack.shrink(1);
                    }
                }

 

Edited by Mightydanp
add version
Link to comment
Share on other sites

You put the stack into the inventory... and then modify it (shrink).

Once you hand off an itemstack into an inventory, you must no longer touch it. It is now part of that inventory and if you modify it directly, you will break things.


How to do this properly:

First of all you don't need to check the slot before inserting, insertItem returns you the excess if it cannot insert. Simply call insertItem with the hand stack and set the resulting stack into the player's hand. They will then receive whatever is left over after inserting: either nothing, if the stack was inserted as a whole, or something, if the stack could not be inserted at all or only partially.

Link to comment
Share on other sites

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

ItemStack heldItem = player.getHeldItem(hand);
		if(!heldItem.isEmpty()) {
			MillstoneTileEntity te = (MillstoneTileEntity)world.getTileEntity(pos);
			IItemHandler inventory = te.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY, Direction.UP).orElse(null);
			if(inventory == null) return false;
			ItemStack stack = heldItem.copy();
			stack.setCount(1);
			stack = inventory.insertItem(0, stack, true);
			if(stack.isEmpty()) {
				stack = inventory.insertItem(0, heldItem.split(1), false);

Can your code. I dont understand where you remove 1 from handItem

Link to comment
Share on other sites

15 minutes ago, Mightydanp said:

heldItem.split(1)

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

To the surprise of no one: Yes. It splits the stack such that the returned stack has the indicated size (or the original's size, whichever is lower) and the original stack is reduced by that amount (to a minimum of zero).

 

Oh and this:

27 minutes ago, Mightydanp said:

stack = inventory.insertItem(0, stack, true);

Is what checks to see if the item can be inserted, regardless of what stack is currently in the TE's inventory.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

13 minutes ago, Mightydanp said:

Alright what is simulate mean? I looked throw the code but didnt understand exactly what that ment

If you set it to true it will simulate the insertion. It will give you the resulting ItemStack that you would get if it were to do the insertion, but it will not actually modify the inventory.

Link to comment
Share on other sites

  You want to do it for real, or just simulate it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Scenario 1:

Slot 0 contains 10 stone.

You call insertItem with simulate false and 20 stone.

insertItem will return an empty stack and slot 0 will now contain 30 stone.

 

Scenario 2:

Slot 0 contains 10 stone.

You call insertItem with simulate true and 20 stone.

insertItem will return an empty stack and slot 0 will contain 10 stone.

 

Scenario 3:

Slot 0 contains 10 stone.

You call insertItem with simulate false and 30 dirt.

insertItem will return 30 dirt and slot 0 will contain 10 stone.

 

This is not difficult...

Link to comment
Share on other sites

stack = inventory.insertItem(0, stack, true);
			if(stack.isEmpty()) {
				stack = inventory.insertItem(0, heldItem.split(1), false);
Can your code. I dont understand where you remove 1 from handItem

Ok so line 1 will visually put an item in slot 0. Which will make stack empty

This will let it pass the of statement and then you insert the item and split it 

Link to comment
Share on other sites

6 minutes ago, Mightydanp said:

Ok so line 1 will visually put an item in slot 0.

No. The first line calculates what would be left over if the stack were to be inserted.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Yes.

But keep in mind that that is not the only way these methods can be used. That's what it does here because only 1 of whatever item is trying to be inserted at a time. If we wanted to do more than 1, it gets a little trickier, but the general process is still the same:

  1. Attempt to insert
  2. Check if the remainder has a smaller stack size than what we tried to insert
  3. Actually split off and insert only the amount that will fit

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.