Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.5] Help with custom Glass Block
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
Luis_ST

[1.16.5] Help with custom Glass Block

By Luis_ST, January 22 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 22 (edited)

I want to creat a block wich is translucent but disable sky light through the block

i just creat this:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/blocks/TintedGlass.java

but when i stand in a cube of my glass there is a skylight:

 

2021-01-22_08_33_41.thumb.png.ed6aa97ea2d9ec9e3c47961d36471708.png

Edited January 22 by Luis_ST
  • Quote

Share this post


Link to post
Share on other sites

Beethoven92    75

Beethoven92

Beethoven92    75

  • Dragon Slayer
  • Beethoven92
  • Members
  • 75
  • 577 posts
Posted January 24

Override the getOpacity in your glass block class, look at the super method implementation to see how opacity is normally handled. It should be pretty easy to see what to put in your override

  • Quote

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

A little fun project: https://www.curseforge.com/minecraft/mc-mods/two-players-one-horse

Share this post


Link to post
Share on other sites

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 25 (edited)
On 1/24/2021 at 2:25 AM, Beethoven92 said:

Override the getOpacity in your glass block class, look at the super method implementation to see how opacity is normally handled. It should be pretty easy to see what to put in your override

i just looked at it but is this not controlled by method propagatesSkylightDown beacause:

and it dosent work.

   @Deprecated
   public int getOpacity(BlockState state, IBlockReader worldIn, BlockPos pos) {
      if (state.isOpaqueCube(worldIn, pos)) {
         return worldIn.getMaxLightLevel();
      } else {
         return state.propagatesSkylightDown(worldIn, pos) ? 0 : 1;
      }
   }

this is currently my block class:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/blocks/TintedGlass.java

Edited January 25 by Luis_ST
  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 25

You do know what that returned int does, right?

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 25 (edited)
5 hours ago, Draco18s said:

You do know what that returned int does, right?

I think yes the int returned is the light going through the block

so 0 will retrun no light through the block

or is that wrong?

Edited January 25 by Luis_ST
  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 25

Lets check the original function.

"If the block is opaque, return the maximum light value. Otherwise if sky light is supposed to propagate downwards, return 0. Otherwise return 1."

 

🤔

  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 26
8 hours ago, Draco18s said:

If the block is opaque, return the maximum light value.

okay i understand but

8 hours ago, Draco18s said:

Otherwise if sky light is supposed to propagate downwards, return 0. Otherwise return 1.

if i understand this correctly i have to return 0.

 

but when i set the value to 0 it dosent work and when i set it to 1 (for testing) it also dosent work

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 26 (edited)
On 1/22/2021 at 1:35 AM, Luis_ST said:

but disable sky light through the block

7 hours ago, Luis_ST said:

if i understand this correctly i have to return 0.

"supposed to propagate downwards" -> lets sky light through it.

This is clearly not the effect you want. The point wasn't to follow the existing logic to see what the default method returns for your block (because duh, the default logic doesn't work for you), it was to figure out how opaque blocks block skylight.

Edited January 26 by Draco18s
  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 27
16 hours ago, Draco18s said:

This is clearly not the effect you want.

So if 0 is the wrong effect and then i have to use 1 but why it dosent work

 

package net.luis.cave.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.util.Direction;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockReader;

public class TintedGlass extends Block {

	public TintedGlass() {
		
		super(Block.Properties.create(Material.ROCK)
				.zeroHardnessAndResistance()
				.sound(SoundType.GLASS)
				.notSolid());

	}
	
	@Override
	public float getAmbientOcclusionLightValue(BlockState state, IBlockReader worldIn, BlockPos pos) {
		
		return 0.2f;
		
	}
	
	@Override
	public boolean propagatesSkylightDown(BlockState state, IBlockReader reader, BlockPos pos) {
		
		return false;
		
	}
	
	@Override
	public int getOpacity(BlockState state, IBlockReader worldIn, BlockPos pos) {
		
		return 1;
		
	}
	
	@Override
	@SuppressWarnings("deprecation")
	public boolean isSideInvisible(BlockState state, BlockState adjacentBlockState, Direction side) {
		
		return adjacentBlockState.isIn(this) ? true : super.isSideInvisible(state, adjacentBlockState, side);
		
	}

}

 

  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 27 (edited)

THERE ARE MORE VALUES THAN 0 AND 1. I even told you, twice, what to look at.

 

Here's a big blindingly stupid hint:

The value returned from getOpacity is subtracted off the current light value in order to determine how bright the next space is.

Edited January 27 by Draco18s
  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Luis_ST    6

Luis_ST

Luis_ST    6

  • Diamond Finder
  • Luis_ST
  • Members
  • 6
  • 360 posts
Posted January 27

Thanks now it work (sometimes im a bit lost when it comes to understanding things)

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Eksity
      Another freaking "error in currently selected datapacks prevented world from loading"

      By Eksity · Posted 2 minutes ago

      great. Is there anything I can do other than go mod-by-mod and test everything?
    • diesieben07
      Another freaking "error in currently selected datapacks prevented world from loading"

      By diesieben07 · Posted 3 minutes ago

      Well, it looks like some of the mods you have installed are breaking your world. I can't tell from the logs which one it is though.
    • Eksity
      Another freaking "error in currently selected datapacks prevented world from loading"

      By Eksity · Posted 5 minutes ago

      also if I save and quit and try to rejoin it doesn't work
    • Eksity
      Another freaking "error in currently selected datapacks prevented world from loading"

      By Eksity · Posted 7 minutes ago

      I can create a new world, and for some reason there's a survival world that works if I remove all the armor mods I was using for my video. however, all other worlds seem to be broken. I tried re-creating it as well as duplicating the file in minecraft/saves, although I'm not sure if either of those have any effect.
    • diesieben07
      Another freaking "error in currently selected datapacks prevented world from loading"

      By diesieben07 · Posted 12 minutes ago

      Does the same occur with a fresh world?
  • Topics

    • Eksity
      12
      Another freaking "error in currently selected datapacks prevented world from loading"

      By Eksity
      Started 19 hours ago

    • Ariel David
      1
      Do i need minecraft installed

      By Ariel David
      Started 28 minutes ago

    • Skyriis
      12
      [1.16.5] Adding a Button to KeyBindings

      By Skyriis
      Started Wednesday at 11:07 PM

    • Deadlocked47
      1
      Can't get into forge discord

      By Deadlocked47
      Started 21 hours ago

    • IntentScarab
      6
      (SOLVED)[1.16.4] Block entity invalid

      By IntentScarab
      Started 1 hour ago

  • Who's Online (See full list)

    • vemerion
    • Eksity
    • diesieben07
    • Beethoven92
    • gottsch
    • IntentScarab
    • Aviator737
    • KatiePandaEx
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.5] Help with custom Glass Block
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community