Jump to content

Recommended Posts

Posted

I've been making some blocks in my mod, and I need the blocks to face a certain direction when placed, in a similar way to how a column/pillar will allow you to place it sideways so its top is facing the player. I've found some tutorials online, but they either don't work, or I'm given errors that I can't resolve. I'll post the code of what I've got so far.

 

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.HorizontalBlock;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.data.BlockModelFields.Rotation;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.state.DirectionProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.util.Mirror;
import net.minecraftforge.common.ToolType;

public class CoralPillar extends Block {
	
	private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING;
	
	public CoralPillar() {
		super(Block.Properties.create(Material.CORAL)
				.hardnessAndResistance(1.0f, 6.0f)
				.sound(SoundType.STONE)
				.harvestLevel(1)
				.harvestTool(ToolType.PICKAXE));
	}
	
	@Override
	public BlockState getStateForPlacement(BlockItemUseContext context) {
		return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite());
	}
	
	public BlockState rotate(BlockState state, Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}
	
	@Override
	public BlockState mirror(BlockState state, Mirror mirrorIn) {
		return state.rotate(mirrorIn.toRotation(state.get(FACING)));
	}
	
	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		builder.add(FACING);
	}
}

 

The error I'm getting is on line 34, reading "The method rotate(state.get(FACING)) is undefined for the type BlockModelFields.Rotation". I feel like the solution is simple, but I can't figure it out,

Posted (edited)
  On 3/2/2021 at 4:15 PM, ehbean said:

The error I'm getting is on line 34, reading "The method rotate(state.get(FACING)) is undefined for the type BlockModelFields.Rotation". I feel like the solution is simple, but I can't figure it out,

Expand  

the method is wrong yes you have to change it to this one (edit: the reason why you get the error you are using the wrong import)

	@Override
	public BlockState rotate(BlockState state, net.minecraft.util.Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}

and you never set the default state in the block constructor

you have to add:

this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

Edited by Luis_ST
Posted
  On 3/2/2021 at 4:31 PM, Luis_ST said:

the method is correct but you never set the default state in the block constructor

you have to add:

this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

Expand  

So adding that line "this.setDefaultState...." to the public BlockState rotate method doesn't seem to get ride of that error there, but I can avoid even needing to override those four methods by changing "CoralPillar extends Blocks" to "CoralPillar extends RotatedPillarBlock"? Wouldn't I need to change how that is loaded during registry so it doesn't crash?

Posted (edited)

you can look at how vanilla blocks that can be oriented implement that, I've looked at the furnace implementation when I learned it. in this case you should look at the quartz pillar block, or any log block

Edited by kiou.23
Posted
  On 3/2/2021 at 4:31 PM, Luis_ST said:

the method is wrong yes you have to change it to this one (edit: the reason why you get the error you are using the wrong import)

	@Override
	public BlockState rotate(BlockState state, net.minecraft.util.Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}

and you never set the default state in the block constructor

you have to add:

this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

Expand  

don't give people copy'n'paste code, especially without any explanation as to way they should copy and paste

  • Sad 1
Posted
  On 3/2/2021 at 5:06 PM, kiou.23 said:

you can look at how vanilla blocks that can be oriented implement that, I've looked at the furnace implementation when I learned it. in this case you should look at the quartz pillar block, or any log block

Expand  

I feel like looking at those files would be greatly beneficial. Where would I find those?

Posted
  On 3/2/2021 at 5:12 PM, ehbean said:

I feel like looking at those files would be greatly beneficial. Where would I find those?

Expand  

in your own IDE you can search for the blocks.

in IntelliJ you can use Ctrl + N, and type the name of the class you're looking for (RotatedPillarBlock, it's the class the logs use)

in Eclipse I think it is Ctrl + Shift + T, but I'm not sure

 

note that the vanilla and forge classes we'll be read-only, you can't edit them

  • Thanks 1
Posted

(Eclipse) F4 on any class name will open the type hierarchy (so if you did it on Block, you'd see all the subclasses, and if you did it on HorizontalBlock, you'd only see the subclasses of that). I can never remember the "go to definition" hotkey (it's F12 in Visual Studio, because of course I can remember that one), but hovering over a thing will give you an intellisense popup and clicking on the class identifier in that will do the same thing.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 3/2/2021 at 5:35 PM, kiou.23 said:

in your own IDE you can search for the blocks.

in IntelliJ you can use Ctrl + N, and type the name of the class you're looking for (RotatedPillarBlock, it's the class the logs use)

in Eclipse I think it is Ctrl + Shift + T, but I'm not sure

 

note that the vanilla and forge classes we'll be read-only, you can't edit them

Expand  

I'm using Eclipse, and that is the right key shortcut. Just gotta figure out how to get this to work now. Copy pasting the variables, and methods doesn't' seem to work outright so I'll need to do some tweaking. 

Posted
  On 3/2/2021 at 6:39 PM, ehbean said:

I'm using Eclipse, and that is the right key shortcut. Just gotta figure out how to get this to work now. Copy pasting the variables, and methods doesn't' seem to work outright so I'll need to do some tweaking. 

Expand  

That's usually the case, always try to understand the code before copy and pasting, or else you'll get a lot of headaches later in the code's life ;)

  • Thanks 1

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • wait, i just did that. why didn't it work? also it's the same. help me!!!!
    • Culprit has been located! It was Tough As Nails + (plus) which was among one of the mods *added* before re-entering, in an attempt to improve compatibility. It, for some reason or another, did not want to work!
    • "You can either try to load it with only the vanilla data pack ("safe mode"), or go back to the title screen and fix it manually." Hello! I encountered this error just now while attempting to re-enter my world for the first time. Notably, no mods were removed before encountering this error and, while being able to find this error elsewhere on the internet, in my scenario it is seemingly caused by a specific mod, of which I cannot isolate. Things I have tried: - Enter "Safe Mode" (fails) - Remove datapacks (no change) - Reverted to old save data (no change) Here is the server log: https://mclo.gs/9vJQEfN I use Modrinth mod loader so please let me know how to share my mod list, and if it is needed.
    • So, i'm hosting (or attempting to host) a port-forwarded modded server for 1.12.2. There's quite a few mods in this pack, but they all run and have no compatibility issues (besides something causing the game to crash if you go fullscreen, a problem ive given up trying to identify or fix). It can run on 6gb of ram or less, and works fine in singleplayer. All of my friends that want to join have the exact same mod/config/game setup as I do (I personally helped them set everything up). Just to be safe, we've all allocated 12 gigabytes of RAM to the installation, and I've also allocated 12GB to the server itself. I am able to join with no issue and it runs fine. However, when they try to join, it gets stuck in the 'logging in' screen before their game becomes unresponsive. When they close it, it gives them the exit code 805306369, which usually means not enough RAM, but this cant be the case. On my screen, in the server, it shows them joining, and then disconnecting, so I dont think its a port-forwarding issue. They can all run it just fine in singleplayer as well. The annoying bit about this particular issue is that it generates no crash log. Does anyone have any suggestions? Thanks! Here is my debug log, and his, starting from the same place. MINE: [132647] [Netty Client IO #5INFO] [FML] Attempting connection with missing mods [ctm, fusion] at SERVER 132653.817 [132653] [Client threadINFO] [minecraftGuiConnecting] Connecting to 0, 25565 132654.682 [132654] [Netty Client IO #9INFO] [STDOUT] [xaero.common.core.transformer.ClassNodeTransformertransform29] Transforming class brz net.minecraft.client.network.NetHandlerPlayClient 132654.684 [132654] [Netty Client IO #9INFO] [STDOUT] [xaero.map.core.transformer.ClassNodeTransformertransform29] Transforming class net.minecraft.client.network.NetHandlerPlayClient 132654.764 [132654] [Netty Client IO #9INFO] [FML] Server protocol version 2 132654.777 [132654] [Netty Client IO #9INFO] [FML] Attempting connection with missing mods [ctm, fusion] at SERVER 132656.193 [132656] [Client threadINFO] [FML] Injecting existing registry data into this client instance 132659.081 [132659] [Client threadINFO] [FML] Applying holder lookups 132659.082 [132659] [Client threadINFO] [FML] Holder lookups applied 132659.092 [132659] [Netty Client IO #9INFO] [FML] [Netty Client IO #9] Client side modded connection established HIS: [13:12:16] [Netty Client IO #0/INFO] [FML]: Attempting connection with missing mods [ctm, fusion] at SERVER 13:12:25.597 [13:12:25] [Client thread/INFO] [minecraft/GuiConnecting]: Connecting to (my IP address and the server port 25565) 13:12:26.805 [13:12:26] [Netty Client IO #1/INFO] [STDOUT]: [xaero.common.core.transformer.ClassNodeTransformer:transform:29]: Transforming class brz net.minecraft.client.network.NetHandlerPlayClient 13:12:26.808 [13:12:26] [Netty Client IO #1/INFO] [STDOUT]: [xaero.map.core.transformer.ClassNodeTransformer:transform:29]: Transforming class net.minecraft.client.network.NetHandlerPlayClient 13:12:26.936 [13:12:26] [Netty Client IO #1/INFO] [FML]: Server protocol version 2 13:12:27.114 [13:12:27] [Netty Client IO #1/INFO] [FML]: Attempting connection with missing mods [ctm, fusion] at SERVER 13:12:27.480 [13:12:27] [Client thread/INFO] [FML]: Injecting existing registry data into this client instance 13:12:30.669 [13:12:30] [Client thread/INFO] [FML]: Applying holder lookups 13:12:30.671 [13:12:30] [Client thread/INFO] [FML]: Holder lookups applied 13:13:04.700 Process crashed with exit code -805306369 P.S - Both mods "CTM" and "FUSION" are present in both our folders so idk what that's about.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.