Why do my recipes not work?

[lxquid_]

Hello,

i have coded recipes and there are not working.

src/main/resources/data/tme/recipes/roesti_from_crafting.json

{
  "type": "minecraft:crafting_shaped",
  "pattern":
  [
    "ppp",
    "ccc",
    "pap"
  ],
  "key":
  {
    "a":
    {
      "tag": "minecraft:coal"
    },
    "p":
    {
      "item": "minecraft:potato"
    },
    "c":
    {
      "item": "tme:cheese"
    }
  },
  "result":
  {
    "item": "tme:roesti",
    "count": 1
  }
}

somebody knows what i am doing wrong?

 

thanks in advance.

[Beethoven92]

Isn't the minecraft tag for coals..."minecraft:coals"?

Edited March 29, 2021 by Beethoven92

[lxquid_]

24 minutes ago, Beethoven92 said:

Isn't the minecraft tag for coals..."minecraft:coals"?

public static final Item COAL = registerItem("coal", new Item((new Item.Properties()).tab(ItemGroup.TAB_MATERIALS)));

 

[Beethoven92]

Mmm that is the registry name of the item. If you take a look into the ItemTags class you will see what the name of the tag for coals is

Edited March 29, 2021 by Beethoven92

[lxquid_]

@diesieben07 Nope this doesnt works for me, i tried "befat" instead of "tme" but it still is not working

[lxquid_]

@diesieben07 i already tried to change coal to coals but it still doesnt works

[lxquid_]

@diesieben07

 

resources/data/befat/recipes/roesti_from_crafting.json

 

{
  "type": "minecraft:crafting_shaped",
  "pattern":
  [
    "a"
  ],
  "key":
  {
    "a":
    {
      "tag": "minecraft:dirt"
    }
  },
  "result":
  {
    "item": "minecraft:diamond",
    "count": 1
  }
}

 

 

Edited March 30, 2021 by lxquid_

[lxquid_]

but where i can find the tags for items

[kiou.23]

1 minute ago, lxquid_ said:

but where i can find the tags for items

https://minecraft.fandom.com/wiki/Tag

you know that tags and items aren't the same thing, right?

[lxquid_]

nope please explain o-o @kiou.23

[lxquid_]

-DELETED-

Edited March 30, 2021 by lxquid_

[lxquid_]

whats the tag for dirt for example?

[kiou.23]

Just now, lxquid_ said:

nope please explain o-o @kiou.23

tags is a way of grouping together items that have something in common. look at Coal and Charcoal for example, they're both individual items, but for the torch recipe (and the campfire iirc), you can use any of the coals. minecraft doesn't make the recipe twice, once for each coal. instead it groups the coals together under a tag

there are tags for a whole bunch of stuff, some from vanilla, some from forge, and you can even make your own type of tags, it's all data-driven and the minecraft wiki article I posted goes into further detail

[lxquid_]

okay but when i change 

"tag": "minecraft:dirt"

to

"item": "minecraft:dirt"

it still doesnt works

[kiou.23]

5 minutes ago, lxquid_ said:

okay but when i change 

"tag": "minecraft:dirt"

to

"item": "minecraft:dirt"

it still doesnt works

post the full recipe json

[lxquid_]

@kiou.23

1 minute ago, kiou.23 said:

post the full recipe json

{
  "type": "minecraft:crafting_shaped",
  "pattern":
  [
    "a"
  ],
  "key":
  {
    "a":
    {
      "item": "minecraft:dirt"
    }
  },
  "result":
  {
    "item": "minecraft:diamond",
    "count": 1
  }
}

 

[kiou.23]

I'm not sure the serializer accepts shaped recipes that only have one ingredient, try using a shapeless recipe (I'm not entirely sure tho)

[lxquid_]

With shapeless it doesnt works too @kiou.23

Edited March 30, 2021 by lxquid_

[kiou.23]

where is your recipe json?

[lxquid_]

2 hours ago, kiou.23 said:

where is your recipe json?

@kiou.23

[Beethoven92]

what is "befat"? I thought your mod id was "tme" (as seen in the first json you posted)..also why did you separate advancements and recipes folder? You can put both of them in data."your_mod_id"

[lxquid_]

4 minutes ago, Beethoven92 said:

what is "befat"? I thought your mod id was "tme" (as seen in the first json you posted)..also why did you separate advancements and recipes folder? You can put both of them in data."your_mod_id"

befat is the modid

10 hours ago, diesieben07 said:

Change your ModID! "tme" is too short and not unique. Do not use abbreviations.

@Beethoven92

[Beethoven92]

All right, you changed it, thats good..so, at this point i think it would be better if you could post a link to your repository (make one if you haven't yet) so we can see the whole thing..

[kiou.23]

did you name the folders with actual periods? don't do that, IntelliJ doesn't make it subfolders (it works for Java packages, but not for regular directories), it's literally just a directory name with periods in it

recipes must be under data/modid/recipes

[lxquid_]

oh my goshh ...