After upgrading Forge (1.13.2) from 25.0.50 to 25.0.63 the Client crashes :
Logs : https://gist.github.com/LTNightshade/6bfa65a9101fb2ce48acfb058fa5daa6
github: https://github.com/LTNightshade/minecraftforge-OCDTorcher
Update: 25.0.60 is working, 25.0.61 crashes.
1. Use String#equals when possible. Since strings are not primitive types,
str_1 == str_2
will return false even if both strings are the same value given that both strings does not point to the same object.
2. Checking an item's type with its name is not accurate, as an item's name can be changed. Check the registry name or use some other methods of checking instead.
In 1.13.2, creative tab is named ItemGroup.
You basically creates a class extending ItemGroup (registry name is passed in the constructor), and override ItemGroup#createIcon to return the ItemStack for the icon of your creative tab.
The easiest way to add an item to your creative tab would be to pass the creative tab instance to your item properties via something like
yourItemProperties.group(creativeTabInstance)
.
Just a heads up for anyone who reads this in the future, I did a major dumb and had my modded server in my .minecraft folder not the modpack folder and that's what I'm assuming caused it, because as soon as i moved it, it worked.
If you want to do it from server-side only, you'll have to see if you can find a packet that harmlessly triggers a client-side inventory sync. I haven't looked into that, so I won't be much help.