Jump to content

Cadiboo

Members
  • Posts

    3624
  • Joined

  • Last visited

  • Days Won

    58

Everything posted by Cadiboo

  1. I believe that @Draco18s said that “a certain someone has finished the initial part of forge for 1.13, but hasn’t put it up on GitHub so that everyone can contribute yet”
  2. Lex told me on my PR that this was intended behaviour & is by design of the MC Entity system which is specifically based on class. I’ll see if I can use IEASD, but I don’t understand how this isn’t the use case for factories. This seems to mean that you can’t use the same class for multiple similar entities (Without IEASDs or the DataManager). I’m using this method(constructor with enum variants) with Blocks and Items, am I not supposed to be doing it this way?
  3. From that message you should have a debug log, can you please look for it again?
  4. 1) pixlemon is broken, don’t use it 2) is the path valid? Go into finder and hit command G and paste that in. If it takes you to your Minecraft folder then it’s valid. Otherwise that’s your problem
  5. Can you please post your entire debug log in a spoiler (click the eye icon while posting) as described in my signature?
  6. Oh yeah, In the post that failed I said that I didn’t see anything except the amount of mods that do stuff in the server stop event
  7. which mods do you add. try adding them 1 by one
  8. Thats a bit extreme. If you want to go that way just delete & reinstall java & delete & reinstall Minecraft & anything Minecraft or java related
  9. make sure the jar file exists and you have execute access to it
  10. Yeah I tried to do the same thing sorry for being condescending
  11. Never mind, I thought you were doing something bad but then I re-read the output ignore all this
  12. your entire process of opening the jar including how you open the command window
  13. you can put it in a spoiler you can do this by clicking the eye icon when posting
  14. how are you opening the file?
  15. please post the entire log as described in my signature
  16. so which one is your full most recent debug log?
  17. That’s not the entire log
  18. Just add the old method in through a core mod or something. Your core modding everything else I don’t see how this is different
  19. I have a bunch of entities that use the constructor MyEntity(World worldIn, MyEnum typeIn) { //... } I register them all in the Register EntityEntry event with for(MyEnum enum : myEnum.values()){ EntityEntryBuilder<Entity> builder = EntityEntryBuilder.create(); //... builder = builder.factory(worldIn -> new MyEntity(worldIn, enum)); //... event.getRegistry().register(builder.build()); } When I spawn these entities with /summon they get created correctly on the server, but on the client they all get created with the same value for typeIn (the last enum in MyEnum.values()) in the constructor. After stepping through the code with the debugger I have found that the packet they are created from (received from the server obviously) tells them (indirectly) to be created with this constructor. (It creates an entity entry from an EntityRegistration ID that corresponds to the constructor function that constructs my entity like MyEntity(worldIn, MyEnum.<last enum from MyEnum.values()>) The packet is created on the server and on the server the EntityRegistration ID is gotten from an EntityRegistration that is gotten from net.minecraftforge.fml.common.registry.EntityRegistry.lookupModSpawn(Class<? extends Entity> clazz, boolean keepLooking) which always returns an EntityRegistration ID that corresponds to the constructor function that constructs my entity like MyEntity(worldIn, MyEnum.<last enum from MyEnum.values()) and NOT like MyEntity(worldIn, MyEnum.<Correct value>). This leads to my entity having the wrong type on the client but having the correct type on the server. I've temporarily fixed this by using the EntityDataManager in my class and putting public EntityRailgunSlug(World worldIn, MyEnum typeIn) { super(worldIn); // this.type = typeIn; if (!world.isRemote) this.dataManager.set(TYPE, typeIn.getId()); } in my entity constructor. However, I don't think I should have to do this and I'm not experienced enough to make a pull request fixing this (if it is a bug) Link to my GitHub where my code that shows this is https://github.com/Cadiboo/WIPTechAlpha/blob/master/src/main/java/cadiboo/wiptech/entity/projectile/EntityRailgunSlug.java https://github.com/Cadiboo/WIPTechAlpha/blob/master/src/main/java/cadiboo/wiptech/EventSubscriber.java (onRegisterEntitiesEvent) https://github.com/Cadiboo/WIPTechAlpha/blob/master/src/main/java/cadiboo/wiptech/util/ModEnums.java (ModMaterials) StackTrace How the EntityEntry ID is gotten - FMLNetworkHandler.getEntitySpawningPacket(Entity) line: 134 Where the packet is actually created - FMLEmbeddedChannel.generatePacketFrom(Object) line: 61
  20. It says malformed JSON and even gives you the line and COLUMN NUMBER. What more could you ask for? Try putting your recipes through a JSON linting program (google it) and fixing the errors that pop up. I can see the error for that specific recipe straight off - an extra comma after the last “E E”
  21. MCP has to be updated for each version of Minecraft. Forge uses MCP under the hood and Lex apparently doesn’t want people to use it directly (He wants them to use Forge, presumably because of the patches it adds, people shouldn’t make jar mods and there’s no reason at all not to sue forge). Lex updates MCP. MCP for 1.13 isn’t finished/available yet. You can take a look at MinecraftForge/MCPConfig on github, Lex is developing it and apparently knows how to use it, but I’ve been unable to do anything with it, probably due to Lex(?) also making ForgeGradle 3 and my lack of knowledge about - Python - Gradle - MCP
  22. Right click anywhere on the package explorer and hit edit build path is one way. You can also probably do it from somewhere in the toolbar
  23. Check first one hand then the other. Player.getStackInHand(EnumHand) doing this from memory so the method might be named differently or you might have to do something like player.getHand(EnumHand).getActiveItemStack()
  24. This topic is almost 2 years old. Please don’t comment on old threads. I don’t know where the docs for the event. In the event just check it the item is the one you want to add the tooltip to and add the tooltip if it is. If you have any questions please make your own new topic
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.