What is the correct way to create a block in 16.5

[DracoDoes]

Block with constructor ::

 public static BarrierBlock barrierBlock = new BarrierBlock(AbstractBlock.Properties.of(Material.FIRE, MaterialColor.METAL));
	    public static final RegistryObject<Block> BARRIER_BLOCK = BLOCKS.register("barrier_block", (Supplier<? extends I>) barrierBlock); //this needs supplier

public class BarrierBlock extends Block {

	public BarrierBlock(Properties p_i48440_1_) {
		super(p_i48440_1_);
	}

}

//Following gives error: java.lang.NoSuchFieldError: field_151573_f
	at com.mcexamples.lists.BlockList.lambda$static$0(BlockList.java:19) ~[main/:?]


  public static final RegistryObject<Block> SILVER_BLOCK = BLOCKS.register("silver_block", () ->
	    		new Block(AbstractBlock.Properties.of(Material.METAL, MaterialColor.METAL).requiresCorrectToolForDrops()
	    				.strength(4.0f, 6.0f).sound(SoundType.METAL).harvestTool(ToolType.PICKAXE).harvestLevel(2)));

 

Thanks

 

[Luis_ST]

2 minutes ago, DracoDoes said:

Block with constructor ::

add the properties in the constructor of the block and the supplier looks like this:

BarrierBlock::new

or keep the properties in the constructor and the supplier looks like this

() -> new BarrierBlock(Block Properties)

 

[DracoDoes]

30 minutes ago, Luis_ST said:

 

or keep the properties in the constructor and the supplier looks like this

() -> new BarrierBlock(Block Properties)

 

Why this gives error? 

Following gives error: java.lang.NoSuchFieldError: field_151573_f
	at com.mcexamples.lists.BlockList.lambda$static$0(BlockList.java:19) ~[main/:?]

 

[Luis_ST]

19 minutes ago, DracoDoes said:

Why this gives error? 

post a git repo of your mod so i can use debugger

[DracoDoes]

1 hour ago, Luis_ST said:

post a git repo of your mod so i can use debugger

https://github.com/MacDax/McraftForge

[Luis_ST]

10 hours ago, DracoDoes said:

https://github.com/MacDax/McraftForge

your code looks okay, place post the complete log

[DracoDoes]

Please find attached logs.

debug.log latest.log 2021-05-21-7.log.gz

[Draco18s]

Two of those files are 0 bytes, nice.

Anyway:

Quote

java.lang.NoSuchFieldError: field_151573_f
    at com.mcexamples.lists.BlockList.lambda$static$0(BlockList.java:29)

Your BlockList file is only 25 lines long.

[Luis_ST]

20 minutes ago, Draco18s said:

Your BlockList file is only 25 lines long.

please update your git repo, as this version of the mod (on github) seems is outdated, or is not complet...

Edited May 24, 2021 by Luis_ST

[DracoDoes]

21 minutes ago, Luis_ST said:

please update your git repo, as this version of the mod (on github) seems is outdated, or is not complet...

updated the repo. However, it's the same line 

 public static final RegistryObject<Block> SILVER_BLOCK = BLOCKS.register("silver_block", () ->
	    		new Block(Properties.of(Material.CLAY, MaterialColor.COLOR_CYAN)));

that shows error for some field like "15**" :: Logs attached from latest run

debug.log latest.log

[kiou.23]

1 minute ago, DracoDoes said:

updated the repo.

You haven't, latest commit is from 3 days ago

forgot to push?

[DracoDoes]

3 minutes ago, kiou.23 said:

You haven't, latest commit is from 3 days ago

forgot to push?

Ok, ya, updated now.

 

Thanks

[aritod]

24 minutes ago, DracoDoes said:

Ok, ya, updated now.

 

Thanks

Why does the mod id in the .toml file not match that of your packages?

 

The path of your classes should be src/main/java/com/<MOD_AUTHOR>/<MOD_ID>/...

But yours is src/main/java/com/mcexamples/examplemod/...

 

So to fix your issue, under the package .../java/ refactor the package mcexamples to the mod author, so 'dracodoes' for example, then refactor the package examplemod to 'mcexamples'

Edited May 24, 2021 by aritod

[DracoDoes]

9 minutes ago, aritod said:

Why does the mod id in the .toml file not match that of your packages?

 

 

so in .toml file, I added mcexamples with dependencies. (main folder under src/main/java) 

But modid is present in .toml file modId="mcexamples"  line 18

If I add one more entry with modId= mcexamples, (name of the ModId) in .toml file, I get the same error. I have tried it earliar. But believe me, it gives the same error.

 

[[dependencies.mcexamples]] #optional
    # the modid of the dependency
    modId="forge" #mandatory

[aritod]

19 minutes ago, DracoDoes said:

so in .toml file, I added mcexamples with dependencies. (main folder under src/main/java) 

But modid is present in .toml file modId="mcexamples"  line 18

If I add one more entry with modId= mcexamples, (name of the ModId) in .toml file, I get the same error. I have tried it earliar. But believe me, it gives the same error.

 

[[dependencies.mcexamples]] #optional
    # the modid of the dependency
    modId="forge" #mandatory

I'm not sure I quite understand you.

 

What I'm saying is that your project structure should look like this:

 

 

Notice how the path is src/main/java/com/dracodoes/mcexamples/ instead of src/main/java/com/mcexamples/examplemod/

So make sure your project structures looks like this. Obviously, you can rename the directory 'dracodoes' to another name, such as MacDax, etc, as it represents the mod author.

I am not asking you to change anything in your mods.toml file, so either I misunderstood you, or you misunderstood me.

 

Also, sorry if this is not what you meant, because you were somewhat unclear.

Edited May 24, 2021 by aritod

[kiou.23]

1 hour ago, aritod said:

The path of your classes should be src/main/java/com/<MOD_AUTHOR>/<MOD_ID>/...

That should only be the path if you own the domain <MOD_AUTHOR>.com, which commonly isn't the case

if  you don't own a website/domain, the recommended package name is io.github.<MOD_AUTHOR>, or some repository hosting service you use.

The name of the package, however, does not affect the issue

Edited May 24, 2021 by kiou.23

[DracoDoes]

10 minutes ago, kiou.23 said:

That should only be the path if you own the domain <MOD_AUTHOR>.com, which commonly isn't the case

if  you don't own a website/domain, the recommended package name is io.github.<MOD_AUTHOR>, or some repository hosting service you use.

The name of the package, however, does not affect the issue

That's what I thought.. so what's the issue?

[DracoDoes]

Now my package structure looks like this:  But still it gives the same error:

[24May2021 13:45:58.012] [Render thread/ERROR] [net.minecraftforge.fml.javafmlmod.FMLModContainer/LOADING]: Caught exception during event RegistryEvent.Register<minecraft:block> dispatch for modid mcexamples
java.lang.NoSuchFieldError: field_151571_B
	at com.MacDax.mcexamples.lists.BlockList.lambda$static$0(BlockList.java:27) ~[main/:?]
	at net.minecraftforge.registries.DeferredRegister.lambda$register$0(DeferredRegister.java:124) ~[forge-1.16.5-36.1.4_mapped_official_1.16.5-recomp.jar:?]