Please read the rules and FAQ before starting a new topic

Biome Dictionary, inconsistency in default registrations

Posted September 14, 201411 yr

BiomeDictionary.java has the following registration:

registerBiomeType(extremeHills, MOUNTAIN, HILLS );

In MakeBestGuess(), Hills and Mountain are exclusive; all the other extreme hills variants are either hills or mountains.

Equally, Extreme Hills + (162) and Extreme Hills M (131) are marked as hills, not mountains.

===

MakeBestGuess() is using a comparison of height variation against 1.5F. This value being tested used to be the max height (in 164 and earlier); none of the vanilla biomes have a height variation that large in 1.7. Even the savannah variants at 163/164 don't hit that, and they are the largest in vanilla 1.7. I think this test is definitely bugged.

Jeb! The sheep! The fence pens, they do nothing still leak!

Quote

1 month later...

October 19, 201410 yr

Author

Additional flaws:

1. Ice Mountains, despite the name, has the same base height 0.45 and variation 0.3 as all the hills. It should have the hills tag, not the mountains (it is not in the same category with extreme hills).

2. Mesa Plateau F M and Mesa Plateau M also have the same 0.45 and 0.3. Yet "FM" has no height tag, and "M" has the "plains" tag. (biomes 166 and 167)

3. "Savanna Plateau M" has the biggest heights in the game -- base 1.05, variation 1.2125, can get really high, yet is only "hills" -- that's like calling the Himalayas "hills".

Jeb! The sheep! The fence pens, they do nothing still leak!

Quote

October 19, 201410 yr

Feel free to PR it with these justifications, untill then dont care they are rather arbitrarily stuck in places anway.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Quote

October 19, 201410 yr

Author

Where can I find instructions on submitting a pull request to forge?

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

Jeb! The sheep! The fence pens, they do nothing still leak!

Quote

October 20, 201410 yr

Where can I find instructions on submitting a pull request to forge?

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

Goto https://github.com/MinecraftForge/MinecraftForge and read the

For Contributors

part of the readme.txt

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/23230-biome-dictionary-inconsistency-in-default-registrations/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

No registered users viewing this page.

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Personally, I just use event.SetCanceled(true) in my handler and it blocks the scroll well.
Even if the method does not appear clear, it is available via the Cancellable interface.
It works at home without additional hacks.

By briey · 1 hour ago1 hr
Failed loading villager cartographer registered at cartographer - frozen tick

Also make a test without jeresources and jei

By TileEntity · 11 hours ago11 hr
Minecraft Mod Gradle Build not working

Try this one:
https://github.com/MinecraftForge/MinecraftForge/blob/1.19.x/mdk/settings.gradle

By TileEntity · 12 hours ago12 hr
Failed loading villager cartographer registered at cartographer - frozen tick

I also just tried with iron's spellbooks removed, since that seemed related, but i am still having the same problem, even in newly created worlds. https://mclo.gs/AtrAfaj

By chemba21 · 14 hours ago14 hr
Minecraft Mod Gradle Build not working

My Gradle Project for my Minecraft mod isn't building.
Terminal:
* Where:
Settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle' line: 2
* What went wrong:
Could not compile settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle'.
> startup failed:
settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle': 2: The pluginManagement {} block must appear before any other statements in the script.
For more information on the pluginManagement {} block, please refer to https://docs.gradle.org/9.0.0/userguide/plugins.html#sec:plugin_management in the Gradle documentation.
@ line 2, column 1.
pluginManagement {
^
1 error

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to generate a Build Scan (Powered by Develocity).
> Get more help at https://help.gradle.org.

Setting.Gradle File:

rootProject.name = 'fusion-lucky-block'
pluginManagement {
repositories {
gradlePluginPortal()
maven { url "https://maven.minecraftforge.net/" }
mavenCentral()
}
}

By Fairygamer03 · Posted 14 hours ago14 hr

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?
Modder Support

1.21.8
[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Zacomat · August 13Aug 13

On Forge 58.0.5 (MC 1.21.8), InputEvent.MouseScrollingEvent is marked cancellable (implements Cancellable, uses a CancellableEventBus), but the event type does not expose setCanceled(boolean) or cancel() from a @SubscribeEvent listener. What’s the correct way to cancel this event (or otherwise block vanilla scroll behavior) from mod code? Can someone plz point me in the right direction? Thx
- 3 replies
- 41336 views
Zacomat

August 13Aug 13

briey

1 hour ago1 hr
Failed loading villager cartographer registered at cartographer - frozen tick
Support & Bug Reports

Failed loading villager cartographer registered at cartographer - frozen tick

chemba21 · yesterday at 09:51 AM1 day

Logs are below, I tried to debug this for a while, and would really appreciate any direction in what mod(s) could be causing the problem. It's only when certain chunks are being loaded that this error comes up and soft locks the game, and the tick freeze is always preceeded by this villager error. Thank you! https://api.mclo.gs/1/raw/4WCNYg7
- 8 replies
- 5211 views
chemba21

Yesterday at 09:51 AM1 day

TileEntity

11 hours ago11 hr
Minecraft Mod Gradle Build not working
ForgeGradle

Minecraft Mod Gradle Build not working

Fairygamer03 · 14 hours ago14 hr

My Gradle Project for my Minecraft mod isn't building. Terminal: * Where: Settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle' line: 2 * What went wrong: Could not compile settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle'. > startup failed: settings file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\settings.gradle': 2: The pluginManagement {} block must appear before any other statements in the script. For more i
- 1 reply
- 1088 views
Fairygamer03

14 hours ago14 hr

TileEntity

12 hours ago12 hr
Mod not building
ForgeGradle

Mod not building

Fairygamer03 · 15 hours ago15 hr

Whenever I go to build my it says "Build failed in " how many seconds Here is what is said in my terminal * Where: Build file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\build.gradle' line: 3 * What went wrong: Plugin [id: 'net.minecraftforge.gradle', version: '6.1.51'] was not found in any of the following sources: - Gradle Core Plugins (plugin is not in 'org.gradle' namespace) - Included Builds (No included builds contain this plugin) - Plugin Repositories (
- 0 replies
- 922 views
Fairygamer03

15 hours ago15 hr

Fairygamer03

15 hours ago15 hr
My Minecraft crashes after I try to load into a world.
Support & Bug Reports

My Minecraft crashes after I try to load into a world.

FoxyWoxy · Sunday at 06:10 PM3 days

https://pastebin.com/mgJCNzAC @TileEntity THE GOAT! that's the log once I load into a world before that everything is fine if you want the whole log just say so (I might need to use google drive though)
- 6 replies
- 10454 views
FoxyWoxy

Sunday at 06:10 PM3 days

TileEntity

Yesterday at 03:07 PM1 day

Sign In

Biome Dictionary, inconsistency in default registrations

Featured Replies

Join the conversation

Recently Browsing 0

Posts

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

Topics

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

Mod not building

My Minecraft crashes after I try to load into a world.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)