Problems upgrading to 1.8 - IBlockState

[BlazeAxtrius]

Ok thanks, I finally managed to fix it.

 

@Override
    public void onMinecartPass(World worldObj, EntityMinecart cart, BlockPos pos)
    {
        if (worldObj.getBlockState(new BlockPos(pos)).getBlock() == ERMBase.triplerailArmed)
        {
            IBlockState blockMetaData = worldObj.getBlockState(new BlockPos(pos));
            worldObj.createExplosion(cart, pos.getX(), pos.getY(), pos.getZ(), 0.3F, false);
            worldObj.newExplosion(cart, pos.getX(), pos.getY(), pos.getZ(), 3.5F, true, true);
        }
    }

 

I just found an other problem, that I have.

 

public boolean canPlaceBlockAt(World par1World, int par2, int par3, int par4)
    {
    	//return !par1World.doesBlockHaveSolidTopSurface(par2, par3 - 1, par4);
        return !par1World.doesBlockHaveSolidTopSurface(par1World, par2, par3 - 1, par4); THIS HERE 
    }

    //public void onNeighborBlockChange(World par1World, int par2, int par3, int par4, int par5)
    public void onNeighborBlockChange(World par1World, int par2, int par3, int par4, Block par5)
    {
        if (!par1World.isRemote) 
        {
            int i1 = par1World.getBlockMetadata(par2, par3, par4);  AND THIS
            int j1 = i1;

            //if (this.isPowered)
            if (this.isPowered()) AND THIS
            {
                j1 = i1 & 7;
            }

            boolean flag = false;

[Draco18s]

I just found an other problem, that I have.

 

And what problem would that be?  I can't look at a block of code and magically understand your problem(s)

[BlazeAxtrius]

I just found an other problem, that I have.

 

And what problem would that be?  I can't look at a block of code and magically understand your problem(s)

 

int i1 = par1World.getBlockMetadata(par2, par3, par4);

I don't know how to fix this, because if I change .getblockMetadata... It will ask me to change int i1 to IBlockState i1 and this makes the rest of the code in errors

 

this.func_150048_a(par1World, pos, i1, j1, par5); - this func_150048_a. What is it?

 

if (this.isPowered()) - I don't how to fix this.

[TheGreyGhost]

Hi Blaze

 

You're digging deep enough now that we aren't going to be able to help you much more unless you get a thorough understanding of some of the basics of 1.8, including IBlockState.  There are a few tutorials around (Wuppy's for example) that will help you get up to speed and make it a lot more frustrating for everyone

 

-TGG

[BlazeAxtrius]

I have a problem with the lines :

if((blockMetaData & 0x8) == 0)

int blockMetaWithoutPoweredBit = blockMetaData & 0x7;

 

It says that "&" is undefined for the argument type(s) IBlockState, int

Here is the full code:

public void onMinecartPass(World world, EntityMinecart cart, BlockPos pos)
    {
        //cm = blockID
        if (world.getBlockState(pos) == ERMBase.monorailPowered)
        {
            IBlockState blockMetaData = world.getBlockState(pos);

            if ((blockMetaData & 0x8) == 0)
            {
                double var24 = Math.sqrt(cart.motionX * cart.motionX + cart.motionZ * cart.motionZ);

                if (var24 < 0.03D)
                {
                    cart.motionX *= 0.0D;
                    cart.motionY *= 0.0D;
                    cart.motionZ *= 0.0D;
                }
                else
                {
                    cart.motionX *= 0.5D;
                    cart.motionY *= 0.0D;
                    cart.motionZ *= 0.5D;
                }
            }
            else
            {
                int blockMetaWithoutPoweredBit = blockMetaData & 0x7;
                double var41 = Math.sqrt(cart.motionX * cart.motionX + cart.motionZ * cart.motionZ);

                if (var41 > 0.01D)
                {
                    double var43 = 0.06D;
                    cart.motionX += cart.motionX / var41 * var43;
                    cart.motionZ += cart.motionZ / var41 * var43;
                }
                else if (blockMetaWithoutPoweredBit == 1)
                {
                    if (world.isBlockIndirectlyGettingPowered(pos) == pos.getX() - 1)
                    {
                        cart.motionX = 0.02D;
                    }
                    else if (world.isBlockIndirectlyGettingPowered(pos) == pos.getX() + 1)
                    {
                        cart.motionX = -0.02D;
                    }
                }
                else if (blockMetaWithoutPoweredBit == 0)
                {
                    if (world.isBlockIndirectlyGettingPowered(pos) == pos.getZ() - 1)
                    {
                        cart.motionZ = 0.02D;
                    }
                    else if (world.isBlockIndirectlyGettingPowered(pos) == pos.getZ() + 1)
                    {
                        cart.motionZ = -0.02D;
                    }
                }
            }
        }
    }

[LexManos]

That is fundamentally not how Block State works. You are not gunna do any bitbanging anymore. you're gunna use abstract IProperties and get the values in a sane way.

IBlockState state = getBlockState();

if ((Boolean)state.get(isPowered)) //do shit

[BlazeAxtrius]

That is fundamentally not how Block State works. You are not gunna do any bitbanging anymore. you're gunna use abstract IProperties and get the values in a sane way.

IBlockState state = getBlockState();

if ((Boolean)state.get(isPowered)) //do shit

 

It doesn't work.

It wants to be BlockState state = getBlockState();

and .get(isPowered). It says "The method get(boolean) is undefined for the type BlockState

 

IBlockState state = getBlockState();

            if ((Boolean)state.get(isPowered))

[BlazeAxtrius]

BlockState state = getBlockState();

            if ((Boolean)state.equals(POWERED))

 

This works. only this thing I have no idea how to fix.

 

int blockMetaWithoutPoweredBit = state & 0x7;

[Draco18s]

That would be available in one of the OTHER states.  Seriously, look at their innards.

[BlazeAxtrius]

I tried so many things. I can't figure it out.

[Draco18s]

Well, you're going to have a lot of trouble getting a specific block's state without casting it to that specific block's BlockState.

[LexManos]

There are plenty of samples on how to use the state system in the vanilla code.

.equals IS NOT the way to do it.

IBlockState is simply a collection of values, those values are keyed by IProperty's

BlockButton is a prime example, go take a look.

[BlazeAxtrius]

There are plenty of samples on how to use the state system in the vanilla code.

.equals IS NOT the way to do it.

IBlockState is simply a collection of values, those values are keyed by IProperty's

BlockButton is a prime example, go take a look.

 

Every time I try something. I go in the game and use the minecart to go over the rail. Mostly the game doesn't crash which means that the code doesn't work even tho it doesn't show errors. With .equals the game crashed so I was left with the impression that it works.

 

It is just this "& 0x7" part I have no idea how to fix. It is an "Int" which isn't specified  but I don't to what I have to change it.

[Draco18s]

With .equals the game crashed so I was left with the impression that it works.

 

What.

[Anon10W1z]

With .equals the game crashed so I was left with the impression that it works.

Just about sums up your Java knowledge...

[BlazeAxtrius]

With .equals the game crashed so I was left with the impression that it works.

Just about sums up your Java knowledge...

 

The fact that it crashed meant that the code was correct and the only line that doesn't work is the int ....

That is how I managed to fix the other Rails. When the game crashes,the crashes report only shows the int... line to be the problem which it is. Before if the code is correct like what Draco18s suggested fixed the problem but the rail property wasnt working. Now the property actually works but I just cant finish this last line of code.

[BlazeAxtrius]

I have 3 things that i can't fix in my mod:

 

Here is the full class:

 

@Override
    //public void onNeighborBlockChange(World par1World, int par2, int par3, int par4, int par5)
    public void onNeighborBlockChange(World par1World, BlockPos pos1, Block par5)
    {
        if (!par1World.isRemote)
        {
            IBlockState i1 = par1World.getBlockState(pos1);
            IBlockState j1 = i1;

            //if (this.isPowered)
            if (this.canProvidePower())
            {
                j1 = i1 & 7;
            }

            boolean flag = false;

            //if (par1World.doesBlockHaveSolidTopSurface(par2, par3 - 1, par4))
            if (par1World.doesBlockHaveSolidTopSurface(par1World, pos1))
            {
                flag = true;
            }

            /**if (j1 == 2 && par1World.doesBlockHaveSolidTopSurface(par2 + 1, par3, par4))
            {
                flag = true;
            }

            if (j1 == 3 && par1World.doesBlockHaveSolidTopSurface(par2 - 1, par3, par4))
            {
                flag = true;
            }

            if (j1 == 4 && par1World.doesBlockHaveSolidTopSurface(par2, par3, par4 - 1))
            {
                flag = true;
            }

            if (j1 == 5 && par1World.doesBlockHaveSolidTopSurface(par2, par3, par4 + 1))
            {
                flag = true;
            }*/

            if (flag)
            {
                this.dropBlockAsItem(par1World, pos1, par1World.getBlockState(pos1), 0);
                par1World.setBlockToAir(pos1);
            }
            else
            {
            	//this.func_94358_a(par1World, par2, par3, par4, i1, j1, par5);
                this.func_150048_a(par1World, pos1, i1, j1, par5);
            }
        }

 

 

1 error line:

 

public void onNeighborBlockChange(World par1World, BlockPos pos1, Block par5)

The method onNeighborBlockChange(World par1World, BlockPos pos1, Block par5) of type EnderPearlRail must override or implement a supertype method

 

 

2 error line:

 

j1 = i1 & 7;

& is not undefined for the argument type IBlockState, int

 

 

3 error line:

 

this.func_150048_a(par1World, pos1, i1, j1, par5);

The method func_150048_a is undefined for the type EnderPearlRail

 

 

The second thing i can't fix.

Full code:

 

package com.expanded.rails.mod.rails;

import net.minecraft.block.Block;
import net.minecraft.block.BlockRailBase;
import net.minecraft.block.BlockRailPowered;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityMinecart;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;

import com.expanded.rails.mod.ERMBase;
import com.google.common.base.Predicate;

public class MonorailPowered extends BlockRailBase
{

    public MonorailPowered(int par1)
    {
        super(true);
        setUnlocalizedName("monorailPowered");
        setHardness(0.7F);
        setStepSound(Block.soundTypeMetal);
        setUnlocalizedName("expandedrails:MonorailPowered");
        // TODO Auto-generated constructor stub
    }

    public static final PropertyEnum SHAPE = PropertyEnum.create("shape", BlockRailBase.EnumRailDirection.class, new Predicate()
    {
        private static final String __OBFID = "CL_00002080";
        public boolean apply(BlockRailBase.EnumRailDirection direction)
        {
            return direction != BlockRailBase.EnumRailDirection.NORTH_EAST && direction != BlockRailBase.EnumRailDirection.NORTH_WEST && direction != BlockRailBase.EnumRailDirection.SOUTH_EAST && direction != BlockRailBase.EnumRailDirection.SOUTH_WEST;
        }
        public boolean apply(Object p_apply_1_)
        {
            return this.apply((BlockRailBase.EnumRailDirection)p_apply_1_);
        }
    });
    public static final PropertyBool POWERED = PropertyBool.create("powered");
    private static final String __OBFID = "CL_00000288";

    protected MonorailPowered()
    {
        super(true);
        this.setDefaultState(this.blockState.getBaseState().withProperty(SHAPE, BlockRailBase.EnumRailDirection.NORTH_SOUTH).withProperty(POWERED, Boolean.valueOf(false)));
    }
    
    protected boolean func_176566_a(World worldIn, BlockPos pos, IBlockState state, boolean p_176566_4_, int p_176566_5_)
    {
        if (p_176566_5_ >= 
        {
            return false;
        }
        else
        {
            int j = pos.getX();
            int k = pos.getY();
            int l = pos.getZ();
            boolean flag1 = true;
            BlockRailBase.EnumRailDirection enumraildirection = (BlockRailBase.EnumRailDirection)state.getValue(SHAPE);

            switch (MonorailPowered.SwitchEnumRailDirection.DIRECTION_LOOKUP[enumraildirection.ordinal()])
            {
                case 1:
                    if (p_176566_4_)
                    {
                        ++l;
                    }
                    else
                    {
                        --l;
                    }

                    break;
                case 2:
                    if (p_176566_4_)
                    {
                        --j;
                    }
                    else
                    {
                        ++j;
                    }

                    break;
                case 3:
                    if (p_176566_4_)
                    {
                        --j;
                    }
                    else
                    {
                        ++j;
                        ++k;
                        flag1 = false;
                    }

                    enumraildirection = BlockRailBase.EnumRailDirection.EAST_WEST;
                    break;
                case 4:
                    if (p_176566_4_)
                    {
                        --j;
                        ++k;
                        flag1 = false;
                    }
                    else
                    {
                        ++j;
                    }

                    enumraildirection = BlockRailBase.EnumRailDirection.EAST_WEST;
                    break;
                case 5:
                    if (p_176566_4_)
                    {
                        ++l;
                    }
                    else
                    {
                        --l;
                        ++k;
                        flag1 = false;
                    }

                    enumraildirection = BlockRailBase.EnumRailDirection.NORTH_SOUTH;
                    break;
                case 6:
                    if (p_176566_4_)
                    {
                        ++l;
                        ++k;
                        flag1 = false;
                    }
                    else
                    {
                        --l;
                    }

                    enumraildirection = BlockRailBase.EnumRailDirection.NORTH_SOUTH;
            }

            return this.func_176567_a(worldIn, new BlockPos(j, k, l), p_176566_4_, p_176566_5_, enumraildirection) ? true : flag1 && this.func_176567_a(worldIn, new BlockPos(j, k - 1, l), p_176566_4_, p_176566_5_, enumraildirection);
        }
    }

    protected boolean func_176567_a(World worldIn, BlockPos p_176567_2_, boolean p_176567_3_, int distance, BlockRailBase.EnumRailDirection p_176567_5_)
    {
        IBlockState iblockstate = worldIn.getBlockState(p_176567_2_);

        if (iblockstate.getBlock() != this)
        {
            return false;
        }
        else
        {
            BlockRailBase.EnumRailDirection enumraildirection = (BlockRailBase.EnumRailDirection)iblockstate.getValue(SHAPE);
            return p_176567_5_ == BlockRailBase.EnumRailDirection.EAST_WEST && (enumraildirection == BlockRailBase.EnumRailDirection.NORTH_SOUTH || enumraildirection == BlockRailBase.EnumRailDirection.ASCENDING_NORTH || enumraildirection == BlockRailBase.EnumRailDirection.ASCENDING_SOUTH) ? false : (p_176567_5_ == BlockRailBase.EnumRailDirection.NORTH_SOUTH && (enumraildirection == BlockRailBase.EnumRailDirection.EAST_WEST || enumraildirection == BlockRailBase.EnumRailDirection.ASCENDING_EAST || enumraildirection == BlockRailBase.EnumRailDirection.ASCENDING_WEST) ? false : (((Boolean)iblockstate.getValue(POWERED)).booleanValue() ? (worldIn.isBlockPowered(p_176567_2_) ? true : this.func_176566_a(worldIn, p_176567_2_, iblockstate, p_176567_3_, distance + 1)) : false));
        }
    }

    protected void onNeighborChangedInternal(World worldIn, BlockPos pos, IBlockState state, Block neighborBlock)
    {
        boolean flag = ((Boolean)state.getValue(POWERED)).booleanValue();
        boolean flag1 = worldIn.isBlockPowered(pos) || this.func_176566_a(worldIn, pos, state, true, 0) || this.func_176566_a(worldIn, pos, state, false, 0);

        if (flag1 != flag)
        {
            worldIn.setBlockState(pos, state.withProperty(POWERED, Boolean.valueOf(flag1)), 3);
            worldIn.notifyNeighborsOfStateChange(pos.down(), this);

            if (((BlockRailBase.EnumRailDirection)state.getValue(SHAPE)).isAscending())
            {
                worldIn.notifyNeighborsOfStateChange(pos.up(), this);
            }
        }
    }

    public IProperty getShapeProperty()
    {
        return SHAPE;
    }

    public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(SHAPE, BlockRailBase.EnumRailDirection.byMetadata(meta & 7)).withProperty(POWERED, Boolean.valueOf((meta &  > 0));
    }

    public int getMetaFromState(IBlockState state)
    {
        byte b0 = 0;
        int i = b0 | ((BlockRailBase.EnumRailDirection)state.getValue(SHAPE)).getMetadata();

        if (((Boolean)state.getValue(POWERED)).booleanValue())
        {
            i |= 8;
        }

        return i;
    }

    protected BlockState createBlockState()
    {
        return new BlockState(this, new IProperty[] {SHAPE, POWERED});
    }

    static final class SwitchEnumRailDirection
        {
            static final int[] DIRECTION_LOOKUP = new int[blockRailBase.EnumRailDirection.values().length];
            private static final String __OBFID = "CL_00002079";

            static
            {
                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.NORTH_SOUTH.ordinal()] = 1;
                }
                catch (NoSuchFieldError var6)
                {
                    ;
                }

                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.EAST_WEST.ordinal()] = 2;
                }
                catch (NoSuchFieldError var5)
                {
                    ;
                }

                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.ASCENDING_EAST.ordinal()] = 3;
                }
                catch (NoSuchFieldError var4)
                {
                    ;
                }

                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.ASCENDING_WEST.ordinal()] = 4;
                }
                catch (NoSuchFieldError var3)
                {
                    ;
                }

                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.ASCENDING_NORTH.ordinal()] = 5;
                }
                catch (NoSuchFieldError var2)
                {
                    ;
                }

                try
                {
                    DIRECTION_LOOKUP[blockRailBase.EnumRailDirection.ASCENDING_SOUTH.ordinal()] = 6;
                }
                catch (NoSuchFieldError var1)
                {
                    ;
                }
            }
        }
    
    public void onMinecartPass(World world, EntityMinecart cart, BlockPos pos)
    {
        //cm = blockID
        if (world.getBlockState(pos) == ERMBase.monorailPowered)
        {
            BlockState state = getBlockState();

            if ((boolean)state.equals(isPowered))
            {
                double var24 = Math.sqrt(cart.motionX * cart.motionX + cart.motionZ * cart.motionZ);

                if (var24 < 0.03D)
                {
                    cart.motionX *= 0.0D;
                    cart.motionY *= 0.0D;
                    cart.motionZ *= 0.0D;
                }
                else
                {
                    cart.motionX *= 0.5D;
                    cart.motionY *= 0.0D;
                    cart.motionZ *= 0.5D;
                }
            }
            else
            {
                int blockMetaWithoutPoweredBit = state & 0x7;
                double var41 = Math.sqrt(cart.motionX * cart.motionX + cart.motionZ * cart.motionZ);

                if (var41 > 0.01D)
                {
                    double var43 = 0.06D;
                    cart.motionX += cart.motionX / var41 * var43;
                    cart.motionZ += cart.motionZ / var41 * var43;
                }
                else if (blockMetaWithoutPoweredBit == 1)
                {
                    if (world.isBlockIndirectlyGettingPowered(pos) == pos.getX() - 1)
                    {
                        cart.motionX = 0.02D;
                    }
                    else if (world.isBlockIndirectlyGettingPowered(pos) == pos.getX() + 1)
                    {
                        cart.motionX = -0.02D;
                    }
                }
                else if (blockMetaWithoutPoweredBit == 0)
                {
                    if (world.isBlockIndirectlyGettingPowered(pos) == pos.getZ() - 1)
                    {
                        cart.motionZ = 0.02D;
                    }
                    else if (world.isBlockIndirectlyGettingPowered(pos) == pos.getZ() + 1)
                    {
                        cart.motionZ = -0.02D;
                    }
                }
            }
        }
    }
    
}

 

 

Error line:

 

int blockMetaWithoutPoweredBit = state & 0x7;

& is not undefined for the argument type IBlockState, int

 

[BlazeAxtrius]

1. [*]The signature for onNeighborBlockChange is

public void onNeighborBlockChange(World worldIn, BlockPos pos, IBlockState state, Block neighborBlock)

. You could have easily found that out by just looking at the Block class and searching for the method (this literally took me about 30 seconds to find. Including booting up my 1.8 workspace).

[*]As said before in this thread, metadata itself does not exist anymore. All the properties you previously stuffed into one interger number (isPowered, direction, etc.) are now actual properties (IProperty). So you don't need all the bit-twiddling operators anymore. Look at vanilla blocks, there are plenty of examples.

[*]Just blindly copying over your (copy and pasted) 1.7 code won't get you anywhere. You need to first of all understand what your (copy and pasted) 1.7 code does. Then look at the vanilla 1.8 code for rails and go from there. Then it is again a task of seconds (maybe a minute now, I did not time it) to see how this exact call looks in 1.8.

 

Ok, I fixed them. They don't work on a 100%. Meaning, they can be placed on the ground but once you place one of the EnderPearlRail in the air you can build the others and they will float.

 

I still don't know how exactly to change the second problem tho.