[1.10.2] [SOLVED] Capability init works on Integrated but not Dedicated Server

[Archery2000]

Hi all,

I am currently working on a mod that adds rpg-like skills to Minecraft using a Capability attached to EntityPlayer. Right now, the system works just fine on an Integrated Server, but upon attempting to launch it on a Dedicated Server, the line registering the capability encounters a NoClassDefFoundError:

https://github.com/archery2000/Mod/blob/master/Crashlog

 

Here is the part of my code that is probably related to the crash:

https://github.com/archery2000/Mod/blob/master/skills/core/SkillCapability.java

https://github.com/archery2000/Mod/blob/master/core/Main.java

https://github.com/archery2000/Mod/blob/master/core/CommonProxy.java

https://github.com/archery2000/Mod/blob/master/core/ServerProxy.java

https://github.com/archery2000/Mod/blob/master/core/ClientProxy.java

 

Would be so grateful if someone could point me in the right direction.

 

Thanks!

 

Edit: Thanks to Abastro, I figured out the source of the problem. By only injecting it in Common Proxy and referring to it from all my other files, the error is prevented.

[loordgek]

replace

if (FMLCommonHandler.instance().getEffectiveSide().isClient()

w/

if (event.getSide() == Side.CLIENT)

[Draco18s]

By the way, why is this in the Common proxy?

https://github.com/archery2000/Mod/blob/master/core/CommonProxy.java#L48

[Archery2000]

replace

if (FMLCommonHandler.instance().getEffectiveSide().isClient()

w/

if (event.getSide() == Side.CLIENT)

 

It didn't work, here's the second crashlog(which looks about the same):

https://github.com/archery2000/Mod/blob/master/Crashlog2

 

May I know the rationale behind the change? Also, if it is important, I use several packets to update the skill information between client and server, where I update the capability information in the packet handler under the appropriate thread.

 

By the way, why is this in the Common proxy?

https://github.com/archery2000/Mod/blob/master/core/CommonProxy.java#L48

 

That's from an FX handler that was updated from 1.8. In it, all the FX used by my mod is managed. It was added into Common by accident and has been removed. Thanks!

[Animefan8888]

Your crash is caused by using EntityPlayerSP somewhere in your code.

[Archery2000]

Your crash is caused by using EntityPlayerSP somewhere in your code.

 

Yes, that I know, but the issue is that I have no idea how to remedy it.

 

There are only two places where EntityPlayerSP is used.

The first is in my packet handlers which are intended to sync capability data from server to client(the player on client side is gotten using Minecraft.getMinecraft().thePlayer. I suppose it is not wrong to attach the capability to this instance of the player? Or is there another 'player entity' that I am supposed to attach it to?

The second is in GUIs because I render the skill bar on the HUD. In this case, the player is again obtained using Minecraft.getMinecraft().thePlayer, because it is client sided only.

 

Regardless, I don't really understand why the error comes up in initialisation.

[Abastro]

Check all part where the casting capability is injected. Client-only code shouldn't be referenced on the same class with the injection.

[Archery2000]

Thanks for the help!

 

I had no idea that simply injecting would cause this issue. Why is it so even if the code is never run on the server side?

[Draco18s]

Because the class is

loaded

.  Merely by being called into existence, the JVM needs to load up every class that it then references before ANY method can be run.