[1.10.2] Storing items in an enum VS Performence

[SHsuperCM]

Will adding items inside an enum and doing all things needed from there affect performence

while loading the game/being in the game?

I'm somewhat new to java and I dont know..

 

I'm asking this because I belive I made the simplest way of adding items and im not sure if its safe...

 

All you need is 1 line for an item and it's resources...

 

 

 

EDIT: IGNORE THIS VV  new below

public class ModItems{
    public static enum ModItemsEnum{
        TESTITEM("TestItem","this_is_test",0),
        ANOTHERTEST("UnLocalizedNameHere","registry_name_here",1),
        CanReallyBeAnything("IsThisGud","this_is_registry_name",0);




        private Item item;
        ModItemsEnum(Item INitem, String INunlocalizedName, String INregistryName, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(INunlocalizedName);
            this.item.setRegistryName(INregistryName);
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(String INunlocalizedName, String INregistryName, int INspecial){ //Normal Classless Items
            this(new Item(),INunlocalizedName,INregistryName,INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;    
        }
        return true;
    }
}

[SHsuperCM]

EDIT:

 

Found a way to shrink it even more! Woop Woop!

 

public class ModItems{
    public static enum ModItemsEnum{
        TESTITEM("this_is_test",0),
        ThisIsUnlocalizedName("registry_name_here",0),
        CanReallyBeAnything("this_is_registry_name",0);




        private Item item;
        ModItemsEnum(Item INitem, String INregistryName, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(this.name());
            this.item.setRegistryName(INregistryName);
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(String INregistryName, int INspecial){ //Normal Classless Items
            this(new Item(),INregistryName,INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }
}

[LexManos]

Creating items in static constructors is typically a bad thing to do.

Just setup your items normally in your init methods.

[SHsuperCM]

Creating items in static constructors is typically a bad thing to do.

Just setup your items normally in your init methods.

I figured that, but what actually it does? because I can just have items and register them any time I want,

and again I want to know what it really matters...

 

Is there some inside super wierd code that doesnt get applied to item instances when they are being themselves?

[SHsuperCM]

Just setup your items normally in your init methods.

The point of the question in the forums is to find out if I can do it without that...

[LexManos]

You're not initalizing the items whenever you want, you're doing it whenever the class is referenced.

Which could be in placed you have no idea.

Such as when other mods re running and then FML is like "Where the hell are these items coming from!?" And it screws up the registry and things go to hell...

Its also a level of indirection magic that makes your code harder to understand.

Technically YES you could write things like this, but you shouldn't as it has a lot of downfalls.

[SHsuperCM]

Actually just creating an Item instance is fine, it does not register it.

Just make sure you call GameRegistry.register in preInit only.

That's what I'm thinking about right now...

I'm just creating the items, and the registry happens only on preinit...

(a.k.a im calling

registerItems()

in preInit, and also calling

registerRenders()

in clientProxy's preInit)

So I dont actually think something would happen wrong...

[SHsuperCM]

Registry happens outside of the enum constructor is what I mean...

[SHsuperCM]

So I dont actually think something would happen wrong...

As it looks to me like a normal code but done diffrently...

[SHsuperCM]

 

I've managed to make it even smaller text/item ratio!

 

 

public class ModItems{
    public static enum ModItemsEnum{
        this_is_test(0)
        ,registry_name_here(0)
        ,this_is_also_the_unlocalized_name(0)
        
        
        ;


        private Item item;
        ModItemsEnum(Item INitem, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(this.name());
            this.item.setRegistryName(this.name());
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(int INspecial){ //Normal Classless Items
            this(new Item(),INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }
}

 

Figured: why the H would I even need a diffrent string for the unlocalized name..

So its just the same!

 

Thought I'd share... Dont really have a reason...

[Draco18s]

Shame it will still crash a dedicated server because it has client-side-only code in a common place.

[SHsuperCM]

Shame it will still crash a dedicated server because it has client-side-only code in a common place.

What do you mean?

[Draco18s]

ModelLoader

does not exist on the dedicated server.

 

Do you understand why the proxy system exists?

[SHsuperCM]

ModelLoader

does not exist on the dedicated server.

 

Do you understand why the proxy system exists?

I really dont understand what you mean... Im opening a server now...

[SHsuperCM]

It works fine!

I can get items place em and see them with

/say @e[type=Item]

[SHsuperCM]

registerRenders()

occurs only on the client proxy, not the server proxy...

[SHsuperCM]

Really from my POV its a flawless system..

I dont get any errors and everything works fine in server/Lan/singleplayer....

[Ernio]

As long as registration methods are called in mod's preInit, I can't argue with the fact that it will work.

 

As to what I would comment here:

 

1. While ModelLoader is not @SideOnly, it actually is for client use only and I personally would place it in client only class (or client proxy) or at least call it from one (client proxy).

 

2. You already made up your mind, why keep asking? If it works, it works (doesn't mean it is any better than any other thing you could write and most certainly it isn't clearer this way).

 

3. This is probably the worst:

if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);

Just do ModItemsEnum.this_is_test.item.setSomeThing(stuff) from preInit.

 

4. Oh wait, it (above) isn't - From now on, instead of doing Items.ITEM, you will have to do Items.LONG_ENUM_NAME.getItem() in EVERY damn place in your code... great!

Aside from that - writing such systems for simple stuff is retarded - anything out of ordinary will still require writing few more lines of code.

 

My piece on this.

[SHsuperCM]

1. While ModelLoader is not @SideOnly, it actually is for client use only and I personally would place it in client only class (or client proxy) or at least call it from one (client proxy).

I said it is only called from client proxy.

 

3. This is probably the worst:

if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);

Just do ModItemsEnum.this_is_test.item.setSomeThing(stuff) from preInit.

This is only called to make special types of items, I dont want to add 10 items and get them in a tab and I dont want to make 10 items

and not get them in a tab, This is an automatic way to do special things to items using the enum constructor

 

4. Oh wait, it (above) isn't - From now on, instead of doing Items.ITEM, you will have to do Items.LONG_ENUM_NAME.getItem() in EVERY damn place in your code... great!

Aside from that - writing such systems for simple stuff is retarded - anything out of ordinary will still require writing few more lines of code.

Calling for an item using its registry name and adding a

getItem()

really isnt that bad for the nothing you do to add the item..

it wont change much at all...

 

 

 

2. You already made up your mind, why keep asking? If it works, it works (doesn't mean it is any better than any other thing you could write and most certainly it isn't clearer this way).

 

You're right!

 

LOCKED