How to spawn structures in underground caves

[Draco18s]

6 minutes ago, TheRPGAdventurer said:

like what biomes? so I can make and exception?

Pretty much all of the non-hills biomes.  Plains, forest, birch forest, ice plains...

Average ground height is considered to be 63.

[TheRPGAdventurer]

Just now, Draco18s said:

Pretty much all of the non-hills biomes.  Plains, forest, birch forest, ice plains...

Average ground height is considered to be 63.

small question, what is the method that makes mobs leashed or un leashed?

[TheRPGAdventurer]

9 hours ago, Animefan8888 said:

This does not generate underground due to these lines.

 

This line makes the chance of it spawning 1 in 120.

This line makes the chance harder if it was underground, but since it is above ground this works.

Update tell me please what's wrong with it.

public void generateNestUnderground(World world, Random random, int chunkX, int chunkZ, Random rand) {        
        int x = chunkX * 16 + random.nextInt(16);
        int z = chunkZ * 16 + random.nextInt(16);
        int xy = x >> 4;
        int zy = z >> 4;
        int y = random.nextInt(43 - 30);
        
            if(world.getBiomeForCoordsBody(new BlockPos(x,y,z)).getBiomeClass().equals(BiomePlains.class)) {
                
                if((random.nextInt(45) + 1) <= 1) {
                    boolean place = true;
        
                    for(int Y = 0; Y < 6; Y++) {
                        for(int Z = 0; Z < 9; Z++) {
                            for(int X = 0; X < 11; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {
                        dragonNest.generate(world, random, new BlockPos(x,y,z));
                }
            }
        }
    }
}                 

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

for(int Y = 0; Y < 6; Y++) {
                        for(int Z = 0; Z < 9; Z++) {
                            for(int X = 0; X < 11; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }

This part checks to see if a 9x11xHeight space is AIR. Which will almost never happen underground.

[TheRPGAdventurer]

Just now, Animefan8888 said:

This part checks to see if a 9x11xHeight space is AIR. Which will almost never happen underground.

9X11 more or 9X11 less? I mean does it really needs that the ground is exactly 9X11?

Edit: bigger than 9X11 or less than 9X11 needed to spawn?

Edited July 16, 2017 by TheRPGAdventurer

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

9X11 more or 9X11 less? I mean does it really needs that the ground is exactly 9X11?

That piece of code is entirely useless for your means. You are checking if a 9x6x11 space is AIR. You don't want to do that.

[TheRPGAdventurer]

Just now, Animefan8888 said:

That piece of code is entirely useless for your means. You are checking if a 9x6x11 space is AIR. You don't want to do that.

ok gonna do a size count on my structure, my structure is a pretty small dragon nest that can fit in a cave.

[TheRPGAdventurer]

Just now, Animefan8888 said:

That piece of code is entirely useless for your means. You are checking if a 9x6x11 space is AIR. You don't want to do that.

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

[TheRPGAdventurer]

Just now, TheRPGAdventurer said:

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

my structure size btw is 7X2X7; 

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

[Kokkie]

derp

Edited July 16, 2017 by Kokkie
Sorry, wrong thing

[TheRPGAdventurer]

11 minutes ago, Animefan8888 said:

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

 

Just now, Kokkie said:

derp

AHAHAHAHAHA

[Kokkie]

Sorry, I replied something that was already said..

[TheRPGAdventurer]

On 7/16/2017 at 9:03 PM, Animefan8888 said:

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

what's wrong with this?

[TheRPGAdventurer]

On 7/16/2017 at 9:03 PM, Animefan8888 said:

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

here's an update 

public void generateNestUnderground(World world, Random random, int chunkX, int chunkZ, Random rand) {        
        int x = chunkX * 16 + random.nextInt(16);
        int z = chunkZ * 16 + random.nextInt(16);
        int xy = x >> 4;
        int zy = z >> 4;
        int height = world.getChunkFromChunkCoords(xy, zy).getHeight(new BlockPos(x & 15, 0, z & 15));
        int y = height - random.nextInt(43 - 30);
        
            if(world.getBiomeForCoordsBody(new BlockPos(x,y,z)).getBiomeClass().equals(BiomePlains.class)) {
                
                if((random.nextInt(10) + 1) <= 1) {
                    boolean place = true;
        
                    for(int Y = 0; Y < 3; Y++) {
                        for(int Z = 0; Z < 7; Z++) {
                            for(int X = 0; X < 7; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {
                        dragonNest.generate(world, random, new BlockPos(x,y,z));
                }
            }
        }
    }
}                 

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

here's an update

That is not what I asked for. I want your entire dragonNest class.

[TheRPGAdventurer]

2 hours ago, Animefan8888 said:

That is not what I asked for. I want your entire dragonNest class.

oh sorry, I thought I posted it a minute ago, https://pastebin.com/p6DWTgMP

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

oh sorry, I thought I posted it a minute ago, https://pastebin.com/p6DWTgMP

So what is the problem currently?

[TheRPGAdventurer]

2 hours ago, Animefan8888 said:

So what is the problem currently?

still not spawning.

[Animefan8888]

Just now, TheRPGAdventurer said:

still not spawning.

Are you sure it is not spawning lets run through a checklist.

• It will only spawn in the Plains Biome.
• Then after that it will only have a chance to spawn 1 out of 10 times.
• Where it generates underground has to have enough air blocks to generate.
• The generation will only run on new chunks.

Make sure you are meeting all of those requirements when you are looking.

[TheRPGAdventurer]

2 hours ago, Animefan8888 said:

Are you sure it is not spawning lets run through a checklist.

• It will only spawn in the Plains Biome.
• Then after that it will only have a chance to spawn 1 out of 10 times.
• Where it generates underground has to have enough air blocks to generate.
• The generation will only run on new chunks.

Make sure you are meeting all of those requirements when you are looking.

I am using a seed that spawns you in a plains biome

I saved that seed so everytime I create a new world, I don't have trouble looking for a plains biome.

[Animefan8888]

1 minute ago, TheRPGAdventurer said:

I am using a seed that spawns you in a plains biome

I saved that seed so everytime I create a new world, I don't have trouble looking for a plains biome.

The biggest problem is the third bullet point.

4 minutes ago, Animefan8888 said:

Where it generates underground has to have enough air blocks to generate.

Since most of underground is not Air the likely hood of it being like that is really low. it is less than 1%.

[TheRPGAdventurer]

2 hours ago, Animefan8888 said:

The biggest problem is the third bullet point.

Since most of underground is not Air the likely hood of it being like that is really low. it is less than 1%.

the new generate method I use will still not work? I thought I changed the value to 3, 7, 7,

[Animefan8888]

Just now, TheRPGAdventurer said:

the new generate method I use will still not work? I thought I changed the value to 3, 7, 7,

3 * 7 * 7 = 147. 147 blocks will have to be air at the randomly generated BlockPos. The likely hood of this happening is almost 0%. Just remove 

 

21 minutes ago, TheRPGAdventurer said:

                    boolean place = true;
        
                    for(int Y = 0; Y < 3; Y++) {
                        for(int Z = 0; Z < 7; Z++) {
                            for(int X = 0; X < 7; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {

None of this is needed.

[TheRPGAdventurer]

2 hours ago, Animefan8888 said:

3 * 7 * 7 = 147. 147 blocks will have to be air at the randomly generated BlockPos. The likely hood of this happening is almost 0%. Just remove 

 

None of this is needed.

but my structure is not a big ass dungeon, it will not be found easily because miners in survival can't see it in caves that's why It needs a cave.