Adding textures to items?

[Animefan8888]

2 minutes ago, Animus_Surge said:

No code errors after fixing a bunch of errors, and my game crashes with the following:

Where are you calling ModelLoader.setCustom...

[Animus_Surge]

1 minute ago, Animefan8888 said:

Where are you calling ModelLoader.setCustom...

in the ItemLightBridge class file

[_Cruelar_]

Post all relevant code, please. Then we might find the error faster.

[Animefan8888]

2 minutes ago, Animus_Surge said:

in the ItemLightBridge class file

Patient: Ouch doctor it hurts

Doctor: Where does it hurt.

Patient: Right there

Doctor: Where is there?

[Animus_Surge]

The item class file (ItemLightBridge)

package net.overgrownportal.item;

import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.overgrownportal.mod.OvergrownPortal;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.client.renderer.texture.SimpleTexture;
import net.minecraft.creativetab.*;

public class ItemLightBridge extends Item{
	public static final Item itemLightBridge = null;

	public ItemLightBridge() {
        setRegistryName("overgrownportal:itemlightbridge");
        setUnlocalizedName(OvergrownPortal.MODID + ".itemlightbridge");
       
		ModelLoader.setCustomModelResourceLocation(itemLightBridge, 0, new ModelResourceLocation(getRegistryName(), getUnlocalizedName()));
    }

    @SideOnly(Side.CLIENT)
    public void initModel() {
        ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
    }

	public static void init() {
		// TODO Auto-generated method stub
		
	}
}

ModItems class file:

package net.overgrownportal.item;

import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class ModItems{

    @GameRegistry.ObjectHolder("overgrownportal:itemlightbridge")
    public static final Item ItemLightBridge = null;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
    	
    }
		
}

and the JSON file:

{
    "parent":"item/generated",
    "textures":{
        "layer0": "overgrownportal:items/itemlightbridge"
    }
}

Edited July 25, 2018 by Animus_Surge

[_Cruelar_]

What's about CommonProxy and ClientProxy

Quote

And the registration in the CommonProxy:

@Mod.EventBusSubscriber
public class CommonProxy {

    ...

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new SimpleTexturedItem());
        ...
    }
}

Also in ClientProxy:

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {

    ...

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
        ModBlocks.initModels();
        ModItems.initModels();
    }


}

 

(Quote from the Tutorial I posted)

 

[Animefan8888]

1 minute ago, Animus_Surge said:

The item class file (ItemLightBridge)

You're passing a null item into setCustomModelResourceLocation.

[Animus_Surge]

1 minute ago, Animefan8888 said:

You're passing a null item into setCustomModelResourceLocation.

What does it need to be instead?

 

[_Cruelar_]

Use this instead of using itemLightBridge

[Animus_Surge]

2 minutes ago, _Cruelar_ said:

What's about CommonProxy and ClientProxy

 

package net.overgrownportal.mod;

import net.minecraft.item.Item;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.overgrownportal.item.ItemLightBridge;

@Mod.EventBusSubscriber
public class CommonProxy {



    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new ItemLightBridge());

    }
}

package net.overgrownportal.mod;

import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.overgrownportal.item.ModItems;
import net.minecraftforge.fml.relauncher.Side;

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
        ModItems.initModels();
    }


}

 

[_Cruelar_]

The Proxies are fine

[_Cruelar_]

Quote

@SideOnly(Side.CLIENT)
    public void initModel() {
        ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
    }

Quote from the Tutorial

Where you got that with

public static final Item itemLightBridge = null;

[Draco18s]

9 minutes ago, Animus_Surge said:

ModelLoader.setCustomModelResourceLocation

Do NOT in any circumstance reference this outside of the client proxy class.

 

	public ItemLightBridge() {
        setRegistryName("overgrownportal:itemlightbridge");
        setUnlocalizedName(OvergrownPortal.MODID + ".itemlightbridge");
      
       //you know, this line here:
		ModelLoader.setCustomModelResourceLocation(itemLightBridge, 0, new ModelResourceLocation(getRegistryName(), getUnlocalizedName()));
      //DO NOT DO THIS AT ALL EVER
    }

Edited July 25, 2018 by Draco18s

[Animus_Surge]

It worked when I replaced itemLightBridge with (this). 

Just now, _Cruelar_ said:

Where you got that with

public static final Item itemLightBridge = null;

I removed it when I replaced itemLightBridge with (this). 

[Animus_Surge]

2 minutes ago, Draco18s said:

Do NOT in any circumstance reference this outside of the client proxy class

So do I put it in the client proxy class?

 

[_Cruelar_]

No you put it in initModel() in your Item call that in initModels in your ModItems which you call in your registerModels() in your ClientProxy

Edited July 25, 2018 by _Cruelar_

[Animus_Surge]

 

package net.overgrownportal.item;

import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class ModItems{

    @GameRegistry.ObjectHolder("overgrownportal:itemlightbridge")
    public static final Item ItemLightBridge = null;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
		ModelLoader.setCustomModelResourceLocation(ItemLightBridge, 0, new ModelResourceLocation(getRegistryName(), getUnlocalizedName()));
    }

	private static String getUnlocalizedName() {
		// TODO Auto-generated method stub
		return null;
	}

	private static ResourceLocation getRegistryName() {
		// TODO Auto-generated method stub
		return null;
	}
		
}

scratch that thought

I have one of those in my initModel already

Edited July 25, 2018 by Animus_Surge

[Draco18s]

4 minutes ago, _Cruelar_ said:

No you put it in initModel() in your Item call that in initModels in your ModItems which you call in your registerModels() in your ClientProxy

No, this is dumb. There is no reason for it to be here. None. At all.

You can call the method without having to ask the class to do it:

 

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName()))

instead of:

item.initModels()

There is literally no reason to ask the item class to do this.

Bam

 

Quote

	private static String getUnlocalizedName() {
		// TODO Auto-generated method stub
		return null;
	}

	private static ResourceLocation getRegistryName() {
		// TODO Auto-generated method stub
		return null;
	}

WHY ARE THESE METHODS RETURNING NULL!?

No one told you to add these methods, so why did you?

Edited July 25, 2018 by Draco18s

[Animefan8888]

1 minute ago, Animus_Surge said:

Like this?

Who told you to do anything with those methods?

[Animus_Surge]

1 minute ago, Draco18s said:

No, this is dumb. There is no reason for it to be here. None. At all.

You can call the method without having to ask the class to do it:

 

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName()))

instead of:

item.initModels()

There is literally no reason to ask the item class to do this.

Bam

 

WHY ARE THESE METHODS RETURNING NULL!?

No one told you to add these methods, so why did you?

 

Just now, Animefan8888 said:

Who told you to do anything with those methods?

I just removed them

[Animefan8888]

This is a link to my ModelRegistryEvent for a WIP mod if you trace it back you will see how it all comes together. I feel it might be easier than explaining it all to you with a back and forth.

[Animefan8888]

12 minutes ago, Animus_Surge said:

I just removed them

And once you have read it and possibly have questions come back and ask and I will answer.

[_Cruelar_]

21 hours ago, Draco18s said:

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName()))

instead of:

item.initModels()

There is literally no reason to ask the item class to do this.

1. In the guide of which I posted the link to uses item.initModels so I wanted to keep it like that for the explanation.
2. Yes there's no reason to do that in the Item class and a central method would be better but both ways work perfectly fine as long you don't make mistakes.

[Draco18s]

15 minutes ago, _Cruelar_ said:

1. In the guide of which I posted the link to uses item.initModels so I wanted to keep it like that for the explanation.

Doesn't mean its a good way to do it

15 minutes ago, _Cruelar_ said:

1. Yes there's no reason to do that in the Item class and a central method would be better but both ways work perfectly fine as long you don't make mistakes.

As long as you don't make mistakes is the important bit. If you never put the code in your item class you can't make a mistake that's basically invisible until you compile and distribute and someone says "it crashes my server."

[_Cruelar_]

For beginner's it's easier to see the ModelLoader thing in the Item that goes with it as code with ItemVariants can be easily forgotten while using an general method for it.

11 minutes ago, Draco18s said:

someone says "it crashes my server."

How should it do that if it's made like the guide says you to do that, I always like it to learn new things about how things can go wrong so I can avoid using these things.