PathNodeType being an enum is a big problem for custom path finding

[MrChoke]

I am writing my own custom PathNavigator and NodeProcessor.  And I am finding I can't extend anything from existing code because Mojang decided to make PathNodeType an enum.  This enum is used all over the place in path finding and even in some other entity code.  What if I need to define my own path nodes types?  For example, I want to be able to break fences.  Well, too bad trying to use any of the existing code because with an enum I can't add anything to it nor can I extend it.

 

I don't know how many people have seen the 1.13 code yet.  Did Mojang change this?  If not, can we change this in Forge?  I'll write the code if I need to.  Thoughts?

 

[Animefan8888]

1 minute ago, MrChoke said:

seen the 1.13 code yet.

I have not seen this, however you could probably look for the mcp(minecraft coder pack for 1.13 and check.

2 minutes ago, MrChoke said:

If not, can we change this in Forge? 

No. This is too bug of a change.

2 minutes ago, MrChoke said:

What if I need to define my own path nodes types

Use reflection and add another entry to the enum. Look at how the EnumHelper class does it if you need an example.

[MrChoke]

4 minutes ago, Animefan8888 said:

Use reflection and add another entry to the enum. Look at how the EnumHelper class does it if you need an example.

WOW, that code is deep.  I read enums are read-only, PERIOD.  That is some serious hack-like code.  It is using "sun" objects for example.  Oh well.  If it works great.  I will see if I can copy part of it.  Too bad PathNodeType is not handled already.  Can that be a Forge change?

[Cadiboo]

It’s very deep code, which is why it breaks on everything except java 8. However it is the “proper” way of adding enum a in forge and is used by all Modders.

 

See an example of adding an enum in the AddHorseArmor method.

Don’t copy the forge method if that’s what you meant by this!!!

3 minutes ago, MrChoke said:

I will see if I can copy part of it.

Edited September 25, 2018 by Cadiboo

[MrChoke]

5 minutes ago, Cadiboo said:

It’s very deep code, which is why it breaks on everything except java 8. However it is the “proper” way of adding enum a in forge and is used by all Modders.

Ok.  Of course it still won't let me do something like this:

 

PathNodeType.NEW_TYPE

 

Since the compiler will fail that.  But perhaps it will allow me to keep a lot of existing code at least.  But how do I reference one of these new runtime enum values then???

 

So any chance of PathNodeType being added to EnumHelper?

Edited September 25, 2018 by MrChoke

[Cadiboo]

Take a look at https://github.com/Cadiboo/WIPTechAlpha/blob/master/src/main/java/cadiboo/wiptech/api/WIPTechAPI.java where I use forges reflection to add an enum

[MrChoke]

6 minutes ago, Cadiboo said:

It’s very deep code, which is why it breaks on everything except java 8. However it is the “proper” way of adding enum a in forge and is used by all Modders.

 

See an example of adding an enum in the AddHorseArmor method.

Don’t copy the forge method if that’s what you meant by this!!!

 

A method like "addPathNodeType" would be great.  It doesn't exist!  We need one.  I smell a forge pull request coming....

[Cadiboo]

Go ahead, but it’s not exactly required

[MrChoke]

1 minute ago, Cadiboo said:

Go ahead, but it’s not exactly required

Explain how its not required unless I start lifting EnumHelper code which I agree is a very bad idea.  

 

Though, please help me with my other question.  How do you reference one of these new enums in code??  PathNodeType.NEW_TYPE sure won't work.

 

[Cadiboo]

5 minutes ago, Cadiboo said:

Take a look at https://github.com/Cadiboo/WIPTechAlpha/blob/master/src/main/java/cadiboo/wiptech/api/WIPTechAPI.java where I use forges reflection to add an enum

 

[Cadiboo]

In pseudo code

public static final EnumType NEW_ENUM = reflectionHelper.addEnum(EnumType.class, new Class[]{enum argument classes}, new enum argument values...);

[MrChoke]

4 minutes ago, Cadiboo said:

In pseudo code

public static final EnumType NEW_ENUM = reflectionHelper.addEnum(EnumType.class, new Class[]{enum argument classes}, new enum argument values...);

 

I will look at the code you sent me.  Seems like I can call addENum() from EnumHelper.  That is fine too.

 

So for my question on referencing it at runtime, would this built-in Enum method work for the runtime entry?

 

static <T extends Enum<T>> T

valueOf(Class<T> enumType, String name)

 

If so, I think this will work.

 

 

Edited September 25, 2018 by MrChoke

[Cadiboo]

1 minute ago, MrChoke said:

 

I will look at the code you sent me.  Seems like I can call addENum() from EnumHelper.  That is fine too.

 

So for my question on referencing it at runtime, would this built-in Enum method work for the runtime entry?

 

static <T extends Enum<T>> T

valueOf(Class<T> enumType, String name)

 

If so, I think this will work.

 

 

Maybe, but just reference your new enum that you added with enumhelper and stored in a constant field.

[MrChoke]

9 minutes ago, Cadiboo said:

Maybe, but just reference your new enum that you added with enumhelper and stored in a constant field.

Still not seeing how I can reference the new enum value as a constant...   I am looking at the HroseArmor stuff....

Edited September 25, 2018 by MrChoke

[Cadiboo]

4 minutes ago, MrChoke said:

Still not seeing how I can reference the new enum value as a constant...   I am looking at the HroseArmor stuff....

Enumhelper.addEnum returns the new enum created. Store it somewhere and reference it

Edited September 25, 2018 by Cadiboo

[MrChoke]

2 minutes ago, Cadiboo said:

Enumhelper.addEnum returns the new enum created. Store it somewhere and reference it

Oh ok.  Yeah that makes sense.  Thanks!

[MrChoke]

Just wanted to let you know, that was a piece of cake to add.  And the built-in valueOf() method works too:

 

final Class[] parameterTypes = new Class[] { float.class };
PathNodeType FENCE_OPEN = EnumHelper.addEnum(PathNodeType.class, "FENCE_OPEN", parameterTypes, 0.0F);

PathNodeType test1 = Enum.valueOf(PathNodeType.class, "FENCE_OPEN");
if(test1 == FENCE_OPEN)
{
    System.out.println("PASSED!!");
}

 

[Cadiboo]

Problematic code issue #10

Edited September 25, 2018 by Cadiboo

[MrChoke]

3 minutes ago, Cadiboo said:

Problematic code issue #10

 

You mean I call the new field something like "MYMOD_FENCE_OPEN"?

[Cadiboo]

On 9/25/2018 at 1:00 PM, MrChoke said:

 

You mean I call the new field something like "MYMOD_FENCE_OPEN"?

I recommend naming your enum a resource location (MODID, EnumName).toString(). What you name it in your field reference is up to you.

 

I don’t know if having a semicolon in the enum name will cause issues though

Edited September 26, 2018 by Cadiboo

[Draco18s]

10 hours ago, Cadiboo said:

I recommend naming your enum a resource location (MODID, EnumName).toString(). What you name it in your field reference is up to you.

 

I don’t know if having a semicolon in the enum name will cause issues though

: is a colon.

[quadraxis]

PathNodeType being an enum was discussed in https://github.com/MinecraftForge/MinecraftForge/pull/4598.