Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Help Creating a Custom Machine [1.12.2]

Distinct Soul

By Distinct Soul
in Modder Support

 Share

Recommended Posts

  • 3 weeks later...
  • Replies 99
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Distinct Soul
Distinct Soul

In Cadiboo's tutorials, he says to look at Cubicoder's one for 1.12.2, and it has it there: https://cubicoder.github.io/tutorials/1-12-2/2018-06-20-first-block/

Posted Images

  • 3 weeks later...
Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted (edited)

Ok, so I've done a few changes to my mod, and I no longer have errors for my classes. However, the problem now relates to the fact that when I run my Minecraft, it crashes and says this:

 

java.lang.IllegalStateException: The ObjectHolder annotation cannot apply to a field that does not map to a registry. Ensure the registry was created during the RegistryEvent.NewRegistry event. (found : net.minecraft.creativetab.CreativeTabs at java.lang.reflect.Field.SOUL_FORGERY)

 

Here's my ClientEventSubscriber if it helps:
  

@Mod.EventBusSubscriber(modid = Main.MODID, value = CLIENT)
public final class ClientEventSubscriber {
	
	private static final Logger LOGGER = LogManager.getLogger();
	private static final String DEFAULT_VARIANT = "normal";
	
	@SubscribeEvent
	public static void onRegisterModelsEvent(@Nonnull final ModelRegistryEvent event) {
		
		ForgeRegistries.BLOCKS.getValuesCollection().stream()
						.filter(block -> block.getRegistryName().getNamespace().equals(Main.MODID))
						.forEach(ClientEventSubscriber::registerItemBlockModel);
		
		registerItemBlockModel(ModBlocks.IGRIAN_ORE);
		registerItemBlockModel(ModBlocks.SHARD_FUSER);
		
		registerItemModel(ModItems.IGRIAN_INGOT);
		registerItemModel(ModItems.IGRIAN_SHARDS);
		registerItemModel(ModItems.TAINTED_SOUL);
		registerItemModel(ModItems.IGRIAN_SWORD);
		
		LOGGER.debug("Registered models");
	}
	
	private static void registerItemModel(@Nonnull final Item item) {
		Preconditions.checkNotNull(item, "Item cannot be null!");
		final ResourceLocation registryName = item.getRegistryName();
		Preconditions.checkNotNull(registryName, "Item Registry Name cannot be null!");
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), DEFAULT_VARIANT));
	}

	private static void registerItemBlockModel(@Nonnull final Block block) {
		Preconditions.checkNotNull(block, "Block cannot be null!");
		final ResourceLocation registryName = block.getRegistryName();
		Preconditions.checkNotNull(registryName, "Block Registry Name cannot be null!");
		ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), DEFAULT_VARIANT));
	}
	
	@SubscribeEvent
	public static void onTextureStitchEvent(@Nonnull final TextureStitchEvent event) {
		// Register texture for Shard Fuser
		final ResourceLocation registryName = ModBlocks.SHARD_FUSER.getRegistryName();
		event.getMap().registerSprite(new ResourceLocation(registryName.getNamespace(), "block/" + registryName.getPath()));
	}
}

 

I'm not really sure what other things to give to help solve this problem.

Edited by Distinct Soul

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted

I did and that's why I sent that because it had to do with registering stuff, which I thought the error was talking about, as it was talking about the registry and registry events. If I didn't I would of just said: "My game crashed. Please help." and not even send anything other than the crash report. At least now that I know that it's more specifically targeted at the @ObjectHolder annotation.

 

From that, all I can think of that might help is sending classes which contain the '@ObjectHolder' annotation. 

@ObjectHolder(Main.MODID)
public class ModBlocks {
	
	// Blocks
	public static final BlockBase IGRIAN_ORE = null;
	public static final BlockBase SHARD_FUSER = null;
}
@ObjectHolder (Main.MODID)
public class ModItems {
	
	// Creative Tabs
	public static final CreativeTabs SOUL_FORGERY = new CreativeTabs("soul_forgery") {

		@Override
		public ItemStack createIcon() {
			return new ItemStack(IGRIAN_INGOT);
		}
	};
	
	// Materials
	public static final ToolMaterial MATERIAL_IGRIAN = EnumHelper.addToolMaterial("material_igrian", 4, 1600, 9.0F, 5.0F, 10);
	
	// Items
	public static final ItemBase TAINTED_SOUL = null;
	public static final ItemBase IGRIAN_SHARDS = null;
	public static final ItemBase IGRIAN_INGOT = null;
	
	// Tools
	public static final ItemSword IGRIAN_SWORD = new ToolSword(MATERIAL_IGRIAN);
	
}

 

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

fweo Tree Puncher

fweo

Posted
Posted

The error is telling you that you are applying the @ObjectHolder annotation to a field that does not correspond to a registry, namely one of type CreativeTabs. If you annotate the class with @ObjectHolder like you have done, it will try to use all of the fields in there as object holders, regardless of their type, so it is trying to use SOUL_FORGERY as an object holder. You can get around this by either having only the things you want as object holders in that class and moving the others, or by annotating each field instead of the whole class (see this link).

  • 1 month later...
Draco18s Reality Controller

Draco18s

Posted
Posted
  On 7/24/2019 at 2:38 PM, Distinct Soul said:

Now when I do that it says 'Item cannot be null'; but I thought that was part of the purpose of my EventSubscriber class. Or one of my other classes at least.

Expand  

That is not what the EventSubscriber class does. If you have a problem with something being null (or any other error), you have to include the code and the log so that we can even begin to help you.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted

Alright, so this is the class I just updated: 

public class ModItems {
	
	@SubscribeEvent
	public void registerItems(RegistryEvent.Register<Item> event) {
	    event.getRegistry().registerAll(TAINTED_SOUL, IGRIAN_SHARDS, IGRIAN_INGOT, IGRIAN_SWORD);
	}
	
	// Creative Tabs
	public static final CreativeTabs SOUL_FORGERY = new CreativeTabs("soul_forgery") {

		@Override
		public ItemStack createIcon() {
			return new ItemStack(IGRIAN_INGOT);
		}
	};
	
	// Materials
	public static final ToolMaterial MATERIAL_IGRIAN = EnumHelper.addToolMaterial("material_igrian", 4, 1600, 9.0F, 5.0F, 10);
	
	// Items
	public static final ItemBase TAINTED_SOUL = null;
	public static final ItemBase IGRIAN_SHARDS = null;
	public static final ItemBase IGRIAN_INGOT = null;
	
	// Tools
	public static final ItemSword IGRIAN_SWORD = new ToolSword(MATERIAL_IGRIAN);
	
}

(Added the 'registerItems' event at the top, and removed the '@ObjectHolder' annotation that I believe was causing the previous crash)

 

The class that I now believe relates to the current crash, which in the crash log references line 52 and 43 of: 

@Mod.EventBusSubscriber(modid = Main.MODID, value = CLIENT)
public final class ClientEventSubscriber {
	
	private static final Logger LOGGER = LogManager.getLogger();
	private static final String DEFAULT_VARIANT = "normal";
	
	@SubscribeEvent
	public static void onRegisterModelsEvent(@Nonnull final ModelRegistryEvent event) {
		
		ForgeRegistries.BLOCKS.getValuesCollection().stream()
						.filter(block -> block.getRegistryName().getNamespace().equals(Main.MODID))
						.forEach(ClientEventSubscriber::registerItemBlockModel);
		
		registerItemBlockModel(ModBlocks.IGRIAN_ORE);
		registerItemBlockModel(ModBlocks.SHARD_FUSER);
		
		registerItemModel(ModItems.IGRIAN_INGOT);
		registerItemModel(ModItems.IGRIAN_SHARDS);
		registerItemModel(ModItems.TAINTED_SOUL);
		registerItemModel(ModItems.IGRIAN_SWORD);
		
		LOGGER.debug("Registered models");
	}
	
	private static void registerItemModel(@Nonnull final Item item) {
		Preconditions.checkNotNull(item, "Item cannot be null!");
		final ResourceLocation registryName = item.getRegistryName();
		Preconditions.checkNotNull(registryName, "Item Registry Name cannot be null!");
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), DEFAULT_VARIANT));
	}

	private static void registerItemBlockModel(@Nonnull final Block block) {
		Preconditions.checkNotNull(block, "Block cannot be null!");
		final ResourceLocation registryName = block.getRegistryName();
		Preconditions.checkNotNull(registryName, "Block Registry Name cannot be null!");
		ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), DEFAULT_VARIANT));
	}
	
	@SubscribeEvent
	public static void onTextureStitchEvent(@Nonnull final TextureStitchEvent event) {
		// Register texture for Shard Fuser
		final ResourceLocation registryName = ModBlocks.SHARD_FUSER.getRegistryName();
		event.getMap().registerSprite(new ResourceLocation(registryName.getNamespace(), "block/" + registryName.getPath()));
	}
}

 

And this is the error log:

  Reveal hidden contents

Any help would be appreciated.

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 7/24/2019 at 3:32 PM, Distinct Soul said:

public static final ItemBase TAINTED_SOUL = null;

public static final ItemBase IGRIAN_SHARDS = null;

public static final ItemBase IGRIAN_INGOT = null;

Expand  

You set these to null here.

 

  On 7/24/2019 at 3:32 PM, Distinct Soul said:

event.getRegistry().registerAll(TAINTED_SOUL, IGRIAN_SHARDS, IGRIAN_INGOT, IGRIAN_SWORD);

Expand  

So...you're referencing the static fields here. Which are null.

 

  On 7/24/2019 at 3:32 PM, Distinct Soul said:

registerItemBlockModel(ModBlocks.IGRIAN_ORE);

registerItemBlockModel(ModBlocks.SHARD_FUSER);

registerItemModel(ModItems.IGRIAN_INGOT);

registerItemModel(ModItems.IGRIAN_SHARDS);

registerItemModel(ModItems.TAINTED_SOUL);

registerItemModel(ModItems.IGRIAN_SWORD);

Expand  

Those references are still null.

  On 7/24/2019 at 3:32 PM, Distinct Soul said:

return new ItemStack(IGRIAN_INGOT);

Expand  

Still null.

 

I don't see where you're actually creating these items. If you are going to use @ObjectHolder to fill them with values, you can't reference these during the RegistryEvent<Item> handler because object holders are not filled until after the registry event.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 7/24/2019 at 4:32 PM, Distinct Soul said:

So what exactly should I do? I've been following Cadiboo's example as best as I can; but I've had to edit things so much I'm completely lost on what I'm supposed to do, and the right way to do it. I feel like examples would help more.

Expand  

Where do you call new Item()? You have to, somewhere. Maybe it's new Ruby() or whatever, but you MUST be calling new on a class that extends Item SOMEWHERE. If you do not have this line, then you are failing to follow the examples terribly.

 

See this?

https://github.com/Cadiboo/Example-Mod/blob/1.12.2/src/main/java/io/github/cadiboo/examplemod/EventSubscriber.java#L95

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted

Oh my bad, I forgot that what I had in this class: 

@EventBusSubscriber (modid = Main.MODID)
public class EventSubscriber {
	
	@SubscribeEvent
	public static void registerBlocks(Register<Block> event) {
		
		final Block[] blocks = {
						new BlockBase(Material.ROCK).setRegistryName("igrian_ore").setTranslationKey(Main.MODID + "." + "igrian_ore"),
						new BlockBase(Material.ROCK).setRegistryName("shard_fuser").setTranslationKey(Main.MODID + "." + "shard_fuser"),
		};
		
		event.getRegistry().registerAll(blocks);
	}
	
	@SubscribeEvent
	public static void registerItems(Register<Item> event) {
			
			final Item[] items = {
						new ItemBase().setRegistryName("tainted_soul").setTranslationKey(Main.MODID + "." + "tainted_soul"),
						new ItemBase().setRegistryName("igrian_shards").setTranslationKey(Main.MODID + "." + "igrian_shards"),
						new ItemBase().setRegistryName("igrian_ingot").setTranslationKey(Main.MODID + "." + "igrian_ingot"),
						new ItemBase().setRegistryName("igrian_sword").setTranslationKey(Main.MODID + "." + "igrian_sword"),	
			};
			
			final Item[] itemBlocks = {
			new ItemBlock(ModBlocks.IGRIAN_ORE).setRegistryName(ModBlocks.IGRIAN_ORE.getRegistryName()),
			new ItemBlock(ModBlocks.SHARD_FUSER).setRegistryName(ModBlocks.SHARD_FUSER.getRegistryName()),
		};
			
			event.getRegistry().registerAll(items);
			event.getRegistry().registerAll(itemBlocks);
		}
	
}

 

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
  On 7/24/2019 at 3:32 PM, Distinct Soul said:

(Added the 'registerItems' event at the top, and removed the '@ObjectHolder' annotation that I believe was causing the previous crash)

Expand  

Since you removed it from the class you need to put it on every Item field.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Draco18s Reality Controller

Draco18s

Posted
Posted

If you have this:

  On 7/24/2019 at 4:42 PM, Distinct Soul said: 
	@SubscribeEvent
	public static void registerItems(Register<Item> event) {
			
			final Item[] items = {
Expand  

 

Then why do you also have this:

  On 7/24/2019 at 3:32 PM, Distinct Soul said: 
	@SubscribeEvent
	public void registerItems(RegistryEvent.Register<Item> event) {
	    event.getRegistry().registerAll(TAINTED_SOUL, IGRIAN_SHARDS, IGRIAN_INGOT, IGRIAN_SWORD);
	}
Expand  

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 2 weeks later...
Draco18s Reality Controller

Draco18s

Posted
Posted
  On 8/2/2019 at 5:00 PM, Distinct Soul said:

And how do I go about doing that @Animefan8888?

Expand  

https://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
  On 8/4/2019 at 2:33 AM, Distinct Soul said:

Ngl; but I have no clue what that's asking for me to do. I get the example (I think); but that's about it.

Expand   
// Instead of...
@ObjectHolder("modid")
public class ModItems {
  
  public static final Item SOME_ITEM = null;
  
}

// Do it on every field.
public class ModItems {
  
  @ObjectHolder("modid:registry_name")
  public static final Item SOME_ITEM = null;
  
}

It's not that hard.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted

Alright, so now that errors been fixed; however, now I have a new error:

  Reveal hidden contents

I get that it's located at line 41 of my EventSubscriber class; but I have no idea what the error means.

 

Here is that class again: 

@EventBusSubscriber (modid = Main.MODID)
public class EventSubscriber {
	
	@SubscribeEvent
	public static void registerBlocks(Register<Block> event) {
		
		final Block[] blocks = {
						new BlockBase(Material.ROCK).setRegistryName("igrian_ore").setTranslationKey(Main.MODID + "." + "igrian_ore"),
						new BlockBase(Material.ROCK).setRegistryName("shard_fuser").setTranslationKey(Main.MODID + "." + "shard_fuser"),
		};
		
		event.getRegistry().registerAll(blocks);
	}
	
	@SubscribeEvent
	public static void registerItems(Register<Item> event) {
			
			final Item[] items = {
						new ItemBase().setRegistryName("tainted_soul").setTranslationKey(Main.MODID + "." + "tainted_soul"),
						new ItemBase().setRegistryName("igrian_shards").setTranslationKey(Main.MODID + "." + "igrian_shards"),
						new ItemBase().setRegistryName("igrian_ingot").setTranslationKey(Main.MODID + "." + "igrian_ingot"),
						new ItemBase().setRegistryName("igrian_sword").setTranslationKey(Main.MODID + "." + "igrian_sword"),	
			};
			
			final Item[] itemBlocks = {
			new ItemBlock(ModBlocks.IGRIAN_ORE).setRegistryName(ModBlocks.IGRIAN_ORE.getRegistryName()),
			new ItemBlock(ModBlocks.SHARD_FUSER).setRegistryName(ModBlocks.SHARD_FUSER.getRegistryName()),
		};
			
			event.getRegistry().registerAll(items);
			event.getRegistry().registerAll(itemBlocks);
		}
	
}

 

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

Draco18s Reality Controller

Draco18s

Posted
Posted

which line is line 41?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Distinct Soul Stone Miner

Distinct Soul

Posted
  • Author
Posted

I hope this is what you mean, because in all my mess of trying to fix things, I don't even remember anymore: 

public class BlockBase extends Block implements IHasModel {
	
	public BlockBase() {
		
		super(Material.ROCK);
		setCreativeTab(ModItems.SOUL_FORGERY);
	}
	
	@Override
	public void registerModels() {
		
		IProxy.registerItemRenderer(Item.getItemFromBlock(this), 0, "inventory");
	}

	public TileEntity createNewTileEntity(World worldIn, int meta) {
		return null;
	}
}

 

If this does not include initializing them, then I would like to know how to do it. Because I've tried looking it up, and it just makes me more confused, as it just results in me getting different errors.

Soul Forgery - https://github.com/DistinctSoul/SoulForgery/tree/DistinctSoul-SoulForgery

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 8/6/2019 at 2:16 PM, Distinct Soul said:

IHasModel

Expand  

You don't need this. Remove all references to it and nuke the file. It does nothing helpful.

 

  On 8/6/2019 at 2:16 PM, Distinct Soul said:

BlockBase

Expand  

BlockBase already exists, its called Block.

 

  On 8/6/2019 at 2:16 PM, Distinct Soul said: 
	public TileEntity createNewTileEntity(World worldIn, int meta) {
		return null;
	}
Expand  

So you overrode a method to...return the same thing as base?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept