[1.14.4][Solved] Create recipes for machine with json

[Tieso2001]

I have a machine that has an input fluidstack, an input itemstack and an output itemstack. Currently I can add recipes with the following code:

RecipeRegistrySteeping.addRecipe("recipe_name", new FluidStack(Fluids.WATER, 1000), new ItemStack(Items.STICK), new ItemStack(Items.DIAMOND));

Where water is the input fluid, the stick the input item and the diamond the output item.

 

I would like to be able to add and remove recipes like vanilla does this with crafting recipes and furnace recipes, through jsons. How can I implement this for my own machine? I want players to add their own recipes through data packs like how it is done in vanilla right now.

 

I took a look at the CookingRecipeSerializer class but I have no idea how to do it myself.

Edited October 2, 2019 by Tieso2001

[Tieso2001]

Btw here's my github repository with the current code: https://github.com/Tieso2001/BoneAppleTea/tree/1.14.4-dev

[Draco18s]

You'd have to write your own (de)serializers and deal with reading the resources yourself. There's likely a good chunk you don't have to rewrite, but there's a lot you will.

[Yanny7]

its not so hard, this is how I created recipes for crusher:

 

Just implement own IRecipe<IInventory>,

Spoiler

public class CrusherRecipe implements IRecipe<IInventory> {
    public static final IRecipeType<CrusherRecipe> crushing = IRecipeType.register("crushing");

    private final IRecipeType<?> type;
    private final ResourceLocation id;
    final String group;
    final Ingredient ingredient;
    final ItemStack result;
    final float experience;
    final int crushingTime;

    CrusherRecipe(ResourceLocation resourceLocation, String group, Ingredient ingredient, ItemStack result, float experience, int crushingTime) {
        type = crushing;
        id = resourceLocation;
        this.group = group;
        this.ingredient = ingredient;
        this.result = result;
        this.experience = experience;
        this.crushingTime = crushingTime;
    }

    @Override
    public boolean matches(IInventory inv, @Nonnull World worldIn) {
        return this.ingredient.test(inv.getStackInSlot(0));
    }

    @Override
    @Nonnull
    public ItemStack getCraftingResult(@Nonnull IInventory inv) {
        return this.result.copy();
    }

    @Override
    public boolean canFit(int width, int height) {
        return true;
    }

    @Override
    @Nonnull
    public ItemStack getRecipeOutput() {
        return result;
    }

    @Override
    @Nonnull
    public ResourceLocation getId() {
        return id;
    }

    @Override
    @Nonnull
    public IRecipeSerializer<?> getSerializer() {
        return RecipeSubscriber.crusher;
    }

    @Override
    @Nonnull
    public IRecipeType<?> getType() {
        return type;
    }

    @Override
    @Nonnull
    public NonNullList<Ingredient> getIngredients() {
        NonNullList<Ingredient> nonnulllist = NonNullList.create();
        nonnulllist.add(this.ingredient);
        return nonnulllist;
    }

    @Override
    @Nonnull
    public ItemStack getIcon() {
        return new ItemStack(BlockSubscriber.crusher);
    }

    public int getCrushingTime() {
        return crushingTime;
    }
}

 

then extend recipe serializer,

Spoiler

public class CrusherRecipeSerializer<T extends CrusherRecipe> extends net.minecraftforge.registries.ForgeRegistryEntry<IRecipeSerializer<?>> implements IRecipeSerializer<T> {
    private final CrusherRecipeSerializer.IFactory<T> factory;

    CrusherRecipeSerializer(CrusherRecipeSerializer.IFactory<T> factory) {
        this.factory = factory;
    }

    @Override
    @Nonnull
    public T read(@Nonnull ResourceLocation recipeId, @Nonnull JsonObject json) {
        String s = JSONUtils.getString(json, "group", "");
        JsonElement jsonelement = JSONUtils.isJsonArray(json, "ingredient") ? JSONUtils.getJsonArray(json, "ingredient") : JSONUtils.getJsonObject(json, "ingredient");
        Ingredient ingredient = Ingredient.deserialize(jsonelement);
        ItemStack itemstack;

        if (!json.has("result")) {
            throw new com.google.gson.JsonSyntaxException("Missing result, expected to find a string or object");
        }

        if (json.get("result").isJsonObject()) {
            itemstack = ShapedRecipe.deserializeItem(JSONUtils.getJsonObject(json, "result"));
        } else {
            String s1 = JSONUtils.getString(json, "result");
            ResourceLocation resourcelocation = new ResourceLocation(s1);
            itemstack = new ItemStack(Registry.ITEM.getValue(resourcelocation).orElseThrow(() -> new IllegalStateException("Item: " + s1 + " does not exist")));
        }

        float f = JSONUtils.getFloat(json, "experience", 0.0F);
        int i = JSONUtils.getInt(json, "crushingTime", 200);

        return this.factory.create(recipeId, s, ingredient, itemstack, f, i);
    }

    @Nullable
    @Override
    public T read(@Nonnull ResourceLocation recipeId, PacketBuffer buffer) {
        String s = buffer.readString(32767);
        Ingredient ingredient = Ingredient.read(buffer);
        ItemStack itemstack = buffer.readItemStack();
        float f = buffer.readFloat();
        int i = buffer.readVarInt();

        return this.factory.create(recipeId, s, ingredient, itemstack, f, i);
    }

    @Override
    public void write(PacketBuffer buffer, T recipe) {
        buffer.writeString(recipe.group);
        recipe.ingredient.write(buffer);
        buffer.writeItemStack(recipe.result);
        buffer.writeFloat(recipe.experience);
        buffer.writeVarInt(recipe.crushingTime);
    }

    interface IFactory<T extends CrusherRecipe> {
        T create(ResourceLocation resourceLocation, String group, Ingredient ingredient, ItemStack result, float experience, int cookTime);
    }
}

 

dont forget to register it,

Spoiler

@ObjectHolder(MODID)
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class RecipeSubscriber {
    public static final CrusherRecipeSerializer<CrusherRecipe> crusher = null;

    @SubscribeEvent
    public static void registerTileEntity(RegistryEvent.Register<IRecipeSerializer<?>> event) {
        IForgeRegistry<IRecipeSerializer<?>> registry = event.getRegistry();
        registry.register(new CrusherRecipeSerializer<>(CrusherRecipe::new).setRegistryName(MODID, "crusher"));
    }
}

 

this is how JSON looks like,

Spoiler

{
  "type": "your_mod_id:crusher",
  "crushingTime": 200,
  "experience": 100.0,
  "ingredient": {
    "tag": "forge:ores/gold"
  },
  "result": {
    "item": "minecraft:gold_ingot",
    "count": 2
  }
}

 

and finally, get recipe in your machine:

Spoiler

 CrusherRecipe recipe = world.getRecipeManager().getRecipe(CrusherRecipe.crushing, inventory, world).orElse(null);

inventory is input slot(s) of your machine

 

 

[Tieso2001]

2 hours ago, Yanny7 said:

Just implement own IRecipe<IInventory>,

Spoiler

package mod.tieso2001.boneappletea.recipe;

import mod.tieso2001.boneappletea.init.ModBlocks;
import mod.tieso2001.boneappletea.init.ModRecipeSerializers;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.IRecipe;
import net.minecraft.item.crafting.IRecipeSerializer;
import net.minecraft.item.crafting.IRecipeType;
import net.minecraft.item.crafting.Ingredient;
import net.minecraft.util.NonNullList;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;

import javax.annotation.Nonnull;

public class SteepingRecipe implements IRecipe<IInventory> {

    public static final IRecipeType<SteepingRecipe> steeping = IRecipeType.register("steeping");

    private final IRecipeType<?> type;
    private final ResourceLocation id;
    final String group;
    final Ingredient ingredient;
    final ItemStack result;
    final int steepTime;

    SteepingRecipe(ResourceLocation resourceLocation, String group, Ingredient ingredient, ItemStack result, int steepTime) {
        type = steeping;
        id = resourceLocation;
        this.group = group;
        this.ingredient = ingredient;
        this.result = result;
        this.steepTime = steepTime;
    }

    @Override
    public boolean matches(IInventory inv, @Nonnull World worldIn) {
        return this.ingredient.test(inv.getStackInSlot(0));
    }

    @Override
    @Nonnull
    public ItemStack getCraftingResult(@Nonnull IInventory inv) {
        return this.result.copy();
    }

    @Override
    public boolean canFit(int width, int height) {
        return true;
    }

    @Override
    @Nonnull
    public ItemStack getRecipeOutput() {
        return result;
    }

    @Override
    @Nonnull
    public ResourceLocation getId() {
        return id;
    }

    @Override
    @Nonnull
    public IRecipeSerializer<?> getSerializer() {
        return ModRecipeSerializers.STEEPING;
    }

    @Override
    @Nonnull
    public IRecipeType<?> getType() {
        return type;
    }

    @Override
    @Nonnull
    public NonNullList<Ingredient> getIngredients() {
        NonNullList<Ingredient> nonnulllist = NonNullList.create();
        nonnulllist.add(this.ingredient);
        return nonnulllist;
    }

    @Override
    @Nonnull
    public ItemStack getIcon() {
        return new ItemStack(ModBlocks.OAK_CASK);
    }

    public int getSteepTime() {
        return steepTime;
    }
}

 

 

2 hours ago, Yanny7 said:

then extend recipe serializer,

Spoiler

package mod.tieso2001.boneappletea.recipe;

import com.google.gson.JsonElement;
import com.google.gson.JsonObject;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.IRecipeSerializer;
import net.minecraft.item.crafting.Ingredient;
import net.minecraft.item.crafting.ShapedRecipe;
import net.minecraft.network.PacketBuffer;
import net.minecraft.util.JSONUtils;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.registry.Registry;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;

public class SteepingRecipeSerializer<T extends SteepingRecipe> extends net.minecraftforge.registries.ForgeRegistryEntry<IRecipeSerializer<?>> implements IRecipeSerializer<T> {

    private final SteepingRecipeSerializer.IFactory<T> factory;

    SteepingRecipeSerializer(SteepingRecipeSerializer.IFactory<T> factory) {
        this.factory = factory;
    }

    @Override
    @Nonnull
    public T read(@Nonnull ResourceLocation recipeId, @Nonnull JsonObject json) {
        String s = JSONUtils.getString(json, "group", "");
        JsonElement jsonelement = JSONUtils.isJsonArray(json, "ingredient") ? JSONUtils.getJsonArray(json, "ingredient") : JSONUtils.getJsonObject(json, "ingredient");
        Ingredient ingredient = Ingredient.deserialize(jsonelement);
        ItemStack itemstack;

        if (!json.has("result")) {
            throw new com.google.gson.JsonSyntaxException("Missing result, expected to find a string or object");
        }

        if (json.get("result").isJsonObject()) {
            itemstack = ShapedRecipe.deserializeItem(JSONUtils.getJsonObject(json, "result"));
        } else {
            String s1 = JSONUtils.getString(json, "result");
            ResourceLocation resourcelocation = new ResourceLocation(s1);
            itemstack = new ItemStack(Registry.ITEM.getValue(resourcelocation).orElseThrow(() -> new IllegalStateException("Item: " + s1 + " does not exist")));
        }

        int i = JSONUtils.getInt(json, "steepTime", 200);

        return this.factory.create(recipeId, s, ingredient, itemstack, i);
    }

    @Nullable
    @Override
    public T read(@Nonnull ResourceLocation recipeId, PacketBuffer buffer) {
        String s = buffer.readString(32767);
        Ingredient ingredient = Ingredient.read(buffer);
        ItemStack itemstack = buffer.readItemStack();
        int i = buffer.readVarInt();

        return this.factory.create(recipeId, s, ingredient, itemstack, i);
    }

    @Override
    public void write(PacketBuffer buffer, T recipe) {
        buffer.writeString(recipe.group);
        recipe.ingredient.write(buffer);
        buffer.writeItemStack(recipe.result);
        buffer.writeVarInt(recipe.steepTime);
    }

    interface IFactory<T extends SteepingRecipe> {
        T create(ResourceLocation resourceLocation, String group, Ingredient ingredient, ItemStack result, int steepTime);
    }
}

 

 

2 hours ago, Yanny7 said:

dont forget to register it,

Spoiler

@ObjectHolder(BoneAppleTea.MOD_ID)
public class ModRecipeSerializers {

    public static final SteepingRecipeSerializer<SteepingRecipe> STEEPING = Null();
}

@SubscribeEvent
    public static void onRegisterRecipeSerializers(final RegistryEvent.Register<IRecipeSerializer<?>> event) {
        event.getRegistry().registerAll(
                new SteepingRecipeSerializer<>(SteepingRecipe::new).setRegistryName(BoneAppleTea.MOD_ID, "steeping")
        );
    }

 

Edited September 30, 2019 by Tieso2001

[Tieso2001]

I got everything working after I changed the IFactory interface in SteepingRecipeSerializer to public.

Now I try to add the recipes to my TileEntity but I get the following error: "Wrong 1st argument type. Found: 'crafting.IRecipeType<SteepingRecipe>', required: 'crafting.IRecipeType<T>'"

I tried changing it IRecipeType<T> but that doesn't work.

 

Spoiler

SteepingRecipe recipe = world.getRecipeManager().getRecipe(SteepingRecipe.steeping, this.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY), world).orElse(null);

 

 

[Animefan8888]

18 minutes ago, Tieso2001 said:

this.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)

First off you shouldn't use getCapability yourself. You should just be able to access the field in your TileEntity. Secondly the value getCapability returns is not applicable for this parameter. Use RecipeWrapper.

 

40 minutes ago, Tieso2001 said:

SteepingRecipe implements IRecipe<IInventory>

Might as well change this to RecipeWrapper as well.

[Draco18s]

Very helpful, Tieso2001, I probably won't end up using it (we'll see; a bunch of my machines shouldn't have exposed recipes, as it markedly impacts the intended balance).

[Tieso2001]

12 hours ago, Draco18s said:

Very helpful, Tieso2001, I probably won't end up using it (we'll see; a bunch of my machines shouldn't have exposed recipes, as it markedly impacts the intended balance). 

Well the reason I want to be able to add recipes through jsons is for modpack makers to easily customise my mod and balance it themself.

Edited October 1, 2019 by Tieso2001

[Draco18s]

2 hours ago, Tieso2001 said:

Well the reason I want to be able to add recipes through jsons is for modpack makers to easily customise my mod and balance it themself.

Oh sure. I just mean that one of my machines facilitates the bar -> block type recipes (9 iron ingots to an iron block, four snowballs to snow, etc). The latter is so deeply entwined with the usual crafting system that it doesn't make sense to expose it, because of the reversible nature of those recipes. Instead its inputs and outputs are based solely on what items make sense.

[Tieso2001]

17 hours ago, Animefan8888 said:

Might as well change this to RecipeWrapper as well.

If I change this:

public class SteepingRecipe implements IRecipe<IInventory> {

to:

public class SteepingRecipe extends RecipeWrapper {

than this class is no longer a recipe so it no longer works.

What is RecipeWrapper and how do I use it?

[Animefan8888]

3 minutes ago, Tieso2001 said:

What is RecipeWrapper and how do I use it?

Take a look at the class and you'll find out.

 

4 minutes ago, Tieso2001 said:

SteepingRecipe extends RecipeWrapper

I didnt mean change the whole thing just the thing that was bolded...

[Tieso2001]

4 minutes ago, Animefan8888 said:

I didnt mean change the whole thing just the thing that was bolded... 

Aha, got confused there for a sec, now I understand.

 

Still don't understand how to fix the issue with the first argument in getRecipe().

[Animefan8888]

18 minutes ago, Tieso2001 said:

Still don't understand how to fix the issue with the first argument in getRecipe().

Post all of your current code. Preferably as a github repo. But on here works too.

[Tieso2001]

2 minutes ago, Animefan8888 said:

Post all of your current code. Preferably as a github repo. But on here works too. 

Just pushed everything I currently have to here: https://github.com/Tieso2001/BoneAppleTea/tree/1.14.4-dev

[Animefan8888]

3 minutes ago, Tieso2001 said:

Just pushed everything I currently have to here:

You need to do the first part I said. You need to have a RecipeWrapper field in your TileEntity to use in getRecipe because it requires an IInventory.

[Tieso2001]

18 minutes ago, Animefan8888 said:

You need to do the first part I said. You need to have a RecipeWrapper field in your TileEntity to use in getRecipe because it requires an IInventory.

I don't think I understand how to do that.

I added this, but then?

private RecipeWrapper recipeWrapper;

 

[Animefan8888]

4 minutes ago, Tieso2001 said:

I added this, but then?

Use its constructor...

[Tieso2001]

2 minutes ago, Animefan8888 said:

Use its constructor...

Yes, but how do I return the RecipeWrapper from my SteepingRecipe class.

private RecipeWrapper recipeWrapper() {
        return 
    }

 

[Animefan8888]

2 minutes ago, Tieso2001 said:

Yes, but how do I return the RecipeWrapper from my SteepingRecipe class.

You don't. I never said anything like that.

 

30 minutes ago, Animefan8888 said:

getRecipe

When I said this I was talking about RecipeManager#getRecipe(the method you are having a problem with).

[Tieso2001]

2 minutes ago, Animefan8888 said:

When I said this I was talking about RecipeManager#getRecipe(the method you are having a problem with).

Okay let me explain what I have and what I don't understand.

 

You say that I need to add RecipeWrapper field to my TileEntity.

private RecipeWrapper recipeWrapper() {

    }

This needs to return RecipeWrapper.

 

I understand that I need RecipeWrapper in my TileEntity, because I can use that to pass the inventory to RecipeManager#getRecipe.

 

But I don't understand how to get RecipeWrapper into my TileEntity

[Animefan8888]

3 minutes ago, Tieso2001 said:

private RecipeWrapper recipeWrapper() {  }

This is a method. Not a field.

 

4 minutes ago, Tieso2001 said:

But I don't understand how to get RecipeWrapper into my TileEntity

Create a field, an instance, a variable. Then use its constructor to initialize it.

[Tieso2001]

7 minutes ago, Animefan8888 said:

This is a method. Not a field.

 

Create a field, an instance, a variable. Then use its constructor to initialize it.

private RecipeWrapper recipeWrapper;

    public RecipeWrapper getRecipeWrapper() {
        return recipeWrapper;
    }

Like this, don't I have to define it then?

Edited October 1, 2019 by Tieso2001

[Animefan8888]

1 minute ago, Tieso2001 said:

public RecipeWrapper getRecipeWrapper() { return recipeWrapper; }

You don't need this at all.

 

1 minute ago, Tieso2001 said:

private RecipeWrapper recipeWrapper;

Yes, but now you need to give it a value by initializing it.

[Tieso2001]

Just now, Animefan8888 said:

Yes, but now you need to give it a value by initializing it.

What value?

 

Sorry if I'm annoying you or anything, normally I can figure it out on my own by looking at vanilla classes but that's not the case here.