I am trying to add NBT to my item, I want it to store the int tankAir but I can't figure it out.. How would I go about adding this to the item.

 

package ronaldi2001.moreitems.Items;

import java.util.List;

import javax.annotation.Nullable;

import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.Entity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextFormatting;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraft.world.World;
import ronaldi2001.moreitems.MoreItems;

public class AirTank extends Item{
	
	public int playerAir;
	boolean Swimming;
	public int tankAir = 0;
	public int addAir;
	public int MaxtankAir;
	boolean active;

	public AirTank(String name, int Max, int Add) {
		
		super(new Item.Properties()
				.group(MoreItems.moreitemsitems)
				.maxStackSize(1)
				);

				setRegistryName(name);
				MaxtankAir = Max;
				addAir = Add;
   }
	
	@Override
	public void inventoryTick(ItemStack stack, World worldIn, Entity player, int itemSlot, boolean isSelected) {
	
		
		playerAir = player.getAir();
		Swimming = player.isInWater();
	
		if(Swimming == false && playerAir == 300) {
		
			active = false;
		
			if(tankAir != MaxtankAir) {
			
				tankAir = tankAir + addAir;	
			}
		
		} else {
		
			if(playerAir < 240 && tankAir > 0) {
			
			tankAir--;
			player.setAir(player.getAir() + 1);
			active = true;
			}
		
			if(tankAir == 0) {
			active = false;
			}
		}
	}
	
	

	@Override
	public void addInformation(ItemStack itemStack, @Nullable World world, List<ITextComponent> tooltip, ITooltipFlag flag) {

		 	tooltip.add(new TranslationTextComponent(TextFormatting.YELLOW + "Air: " + String.valueOf(Math.round((tankAir * 100) / MaxtankAir)) + "%"));
		
	}
	
	public boolean hasEffect(ItemStack par1ItemStack){
		return active;
	}
}

 

20 minutes ago, Ronaldi2001 said:

    public int playerAir;
    boolean Swimming;
    public int tankAir = 0;
    public int addAir;
    public int MaxtankAir;
    boolean active;

You can't do this.

What do you mean I can't do this? Like I can't store tankAir to not?

Items are singletons. You must store tankAir via NBT in an ItemStack.

Use ItemStack#setTag.

53 minutes ago, Ronaldi2001 said:

What do you mean I can't do this? Like I can't store tankAir to not?

All of those fields cannot be used. Items are singletons.

Problematic Code #9

Problem #9 says to make a tile entity. My understanding of a tile entity is a block not an item. So how would I make that just an item? I don't know if i'm understanding this correctly.

Cough:

1 hour ago, DavidM said:

Items are singletons. You must store tankAir via NBT in an ItemStack.

Use ItemStack#setTag.

1 minute ago, Ronaldi2001 said:

So how would I make that just an item?

You can't Item's are singletons. But there is something that stores Items which is not a singleton. It's called an ItemStack. You'll notice a lot of methods take ItemStack as a parameter you can use ItemStack::setTag and ItemStack::getTag to store stack based information.

Hi

Here's a working example of how to add NBT to an item, might give you some inspiration on how to do it for your air tank.

https://github.com/TheGreyGhost/MinecraftByExample/

mbe12, mbe11

 

-TGG

6 hours ago, TheGreyGhost said:

Hi

Here's a working example of how to add NBT to an item, might give you some inspiration on how to do it for your air tank.

https://github.com/TheGreyGhost/MinecraftByExample/

mbe12, mbe11

 

-TGG

Thank you!! This worked, one more question. Is there anyway to carry over NBT data with a crafting recipe? I have different tiers of Air Tanks and when crafting a lower one to get a higher one I want the air to carry over. I don't know if that is even possible??

Hi Ronaldi

 

Yes it's possible, although I've never done it.

You can add your own crafting recipe code to the game (by implementing IRecipe or ICraftingRecipe) which treats the NBT appropriately.  Based on a quick glance at vanilla, you may need a corresponding IRecipeSerializer as well, to handle reading a recipe json.

I don't know details of how to register a new recipe type, I suspect it will be the same style as

 

@SubscribeEvent public static void onBlocksRegistration(final RegistryEvent.Register<Block> blockRegisterEvent) {

but for RegistryEvent.Register<IRecipeSerializer<?>>

 

There is some bare bones forge docs here about recipes, it might have some extra clues although there's also a good chance it's out of date unfortunately.

 

https://mcforge.readthedocs.io/en/1.14.x/utilities/recipes/

 

-TGG