Jump to content

Recommended Posts

Posted

Nothing, actually. I thought I did change something, but I can't find it after comparing my 1.5.2 code with 758. Also, put everything in preInit, but remember that preInit is no longer called that. Instead, it should be:

@EventHandler
public void load(FMLPreInitializationEvent event) {}

It is still the FMLPreInitializationEvent, but this goes inside @EventHandler.

 

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

-sorash67 || Skorpio

  • Replies 93
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Posted

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

You would be correct.

 

But guess what, we're talking PRE init, not init.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

you're probably putting languageregistry before you declare your block!

What do you mean before I declared the block.  Shouldn't block declaration still be in Init?

 

Don't tell me to learn the basics of java, I already know.

Posted

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

You would be correct.

 

But guess what, we're talking PRE init, not init.

 

he called his preInit method load, that's all  i meant! jeez.

 

you're probably putting languageregistry before you declare your block!

What do you mean before I declared the block.  Shouldn't block declaration still be in Init?

 

 

the block should always be registered before its name, and now that the name is in preInit, then the block goes in preInit as well! anyways, the textures seem to be only working when the block is declared in preInit!

 

-sorash67 || Skorpio

Posted

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

You would be correct.

 

But guess what, we're talking PRE init, not init.

 

he called his preInit method load, that's all  i meant! jeez.

 

He can call his preInit method Ooh_Eeh_Ooh_Ah_Aah_Ting_Tang_Walla_Walla_Bing_Bang and have absolutely ZERO impact on the outcome.

 

As I mentioned before:

Function names and variable names are entirely irrelevant.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

You would be correct.

 

But guess what, we're talking PRE init, not init.

 

he called his preInit method load, that's all  i meant! jeez.

 

He can call his preInit method Ooh_Eeh_Ooh_Ah_Aah_Ting_Tang_Walla_Walla_Bing_Bang and have absolutely ZERO impact on the outcome.

 

As I mentioned before:

Function names and variable names are entirely irrelevant.

 

if i have to mention this again, i will! i am COMPLETELY AWARE of this. the reason for me saying that is to reduce confusion.

 

-sorash67 || Skorpio

Posted

I just said, I declared my blocks and items and it still gave me the error.

 

EDIT: Never mind, I got it.  The only thing that I can't figure out is that when I put on my mod's armor, it doesn't show up on my body.

Don't tell me to learn the basics of java, I already know.

Posted
if i have to mention this again, i will! i am COMPLETELY AWARE of this. the reason for me saying that is to reduce confusion.

 

You don't seem like it:

 

Him: "This is my preinit function"

You: "It's named wrong!!!!"

 

public void load(FMLPreInitializationEvent event) {}

 

    It is still the FMLPreInitializationEvent, but this goes inside @EventHandler.

 

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I just said, I declared my blocks and items and it still gave me the error.

 

EDIT: Never mind, I got it.  The only thing that I can't figure out is that when I put on my mod's armor, it doesn't show up on my body.

 

having the same problem, looking for a fix!

 

if i have to mention this again, i will! i am COMPLETELY AWARE of this. the reason for me saying that is to reduce confusion.

 

You don't seem like it:

 

Him: "This is my preinit function"

You: "It's named wrong!!!!"

 

public void load(FMLPreInitializationEvent event) {}

 

    It is still the FMLPreInitializationEvent, but this goes inside @EventHandler.

 

i don't think FMLPreInitializationEvent is the load method... the FMLInitialization is!

 

it would be really nice if you stopped talking about irrelevant topics and helped solve the problems that we all have instead.

 

-sorash67 || Skorpio

Posted
It would be really nice if you stopped talking about irrelevant topics and helped solve the problems that we all have instead.

 

Two things:

1) I can't solve the problem as I have the problem and you don't

2) Right back at you.  Stop telling people they named their functions wrong when it's completely and utterly irrelevant.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Alright guys, chill out. What problems do we still have?

 

All of them.

 

None of my block names are getting localized and I still don't have textures coming in.

 

And I've done fuckeverything mentioned in this thread and two others.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Interestingly enough, it appears that loading the block/items inside of your Init method will not initialize the textures/localizations. If you move them to the PreInit method, everything works perfectly fine. It appears that on the texture side of things, if you place them inside of your Init method then registerIcons(IconRegister) is never called.

Posted

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Interestingly enough, it appears that loading the block/items inside of your Init method will not initialize the textures/localizations. If you move them to the PreInit method, everything works perfectly fine. It appears that on the texture side of things, if you place them inside of your Init method then registerIcons(IconRegister) is never called.

 

seems like this is what's happening! but we've kinda figured that out since a while ago! x)

 

-sorash67 || Skorpio

Posted

Not sure what you did, but I put the code in, and then the textures in, and everything worked fine. Cool mod btw. Anyways, the only thing I can think of is that you put the textures in the wrong place. To try to make things easier, the destination of invisible.png is at forge/mcp/src/minecraft/assets/traps/textures/blocks/invisible.png. Hope I helped.

If you really want help, give that modder a thank you.

 

Modders LOVE thank yous.

Posted

Not sure what you did, but I put the code in, and then the textures in, and everything worked fine. Cool mod btw. Anyways, the only thing I can think of is that you put the textures in the wrong place. To try to make things easier, the destination of invisible.png is at forge/mcp/src/minecraft/assets/traps/textures/blocks/invisible.png. Hope I helped.

 

if you look at his assets folder, you can see he already did that... O.o

 

-sorash67 || Skorpio

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.