Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Textures and LanguageRegistry in preInit instead of Init


sorash67
 Share

Recommended Posts

Hello all modders and possibly, owners of forge! i have been messing around with code to figure out how to fix the issues related to block and item textures, and name registry being "tile.blockName.name" for every block after the 1.6.1 update! As i was modifying my code, i noticed that when the blocks and items are declared in the preInit section of the code rather than the usual place, the Init, textures actually show up! but when in Init, they don't! then i thought why don't i try this for LanguageRegistry as well? and sure enough, the names worked absolutely fine when moved from Init to preInit! If you have any suggestions or ideas about why this is happening, please share! And also, if you need any code, go right ahead and ask, and i will provide the related code! Thank you! :)

 

-sorash67 || Skorpio

Link to comment
Share on other sites

  • Replies 93
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Sorry bub, I think its a coincidence.  I've got all my code in preInit right now and no dice.

 

Code for one block:

@EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	//System.out.println("Loadnig Redstone Mod");
    	Configuration config = new Configuration(event.getSuggestedConfigurationFile());
    	config.load();
    	//load configs
        fakeID = config.getBlock("FakeBlock", 2000).getInt();
    	config.save();
    	fakeBlock = new FakeBlock(fakeID);

    		System.out.println("Registering Fake Block");
    		GameRegistry.registerBlock(fakeBlock, "Illusionary Block");
    		LanguageRegistry.addName(fakeBlock, "Illusionary Block");
    		GameRegistry.addShapelessRecipe(new ItemStack(fakeBlock), painting, stone);
    		
    		int r = RenderingRegistry.getNextAvailableRenderId();
    		ISimpleBlockRenderingHandler handler = new RenderFakeBlock(r);
    		RenderingRegistry.registerBlockHandler(handler);
       		((FakeBlock)fakeBlock).renderType = r;
    		System.out.println(" - " + fakeBlock.getUnlocalizedName());
    		LanguageRegistry.instance().addStringLocalization("tile.Illusionary Block.name", "Illusionary Block");

 

2013_07_03_09_38_07.png

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@PreInit
public void preInit(FMLPreInitializationEvent event){
	//Config file
	config = new Configuration(event.getSuggestedConfigurationFile());

	new MoreOresConfig();


	ingotOrange = new ItemGeneralIngot(MoreOresConfig.ingotOrangeID).setUnlocalizedName("ingotOrange").setCreativeTab(orangeTab);

LanguageRegistry.addName(ingotOrange, "Origum Ingot");
}

 

works perfectly fine! but when i move it over to

@Init
public void init(FMLInitializationEvent event){
}

bam, missing textures and name...

 

while in preInit:

uxkKM9m.png

 

and in init:

ZfbgCVB.png

 

what is going on???

 

-sorash67 || Skorpio

Link to comment
Share on other sites

Wouldn't that seem like that means they need to be setup during the pre-init and be ready Before the init method or else they will not be loaded in time for the methods which depend on them to make use of them? :P

 

Sounds like a simple solution, load them in the place they should and all is fine? :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

that's EXACTLY what i thought! xD the thing is, i tweeted LexManos himself, and he said this is the WRONG thing to do! and i know this too! but it works, and there doesn't seem to be any other solution! so i guess i'll go with it...

 

-sorash67 || Skorpio

Link to comment
Share on other sites

You are wrong it only fixes names not textures.

 

Then he must have changed more than he said between the screenshots then, since it shows the texture working in the first and not the second one?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

i tweeted LexManos himself, and he said this is the WRONG thing to do! and i know this too! but it works

 

Well that means there are far better ways to do this and that this way might break at a later build.

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I have learned to respect lex and I try to follow what he says, tough most is above my skill :P

Anyways it's so early in the development of this forge version and much is speculations instead of facts here on the boards. I guess one should go read the github commitments and code changes along with some re-reading of the src code to understand more.

 

Or one could wait for the dust to settle and use the time between to fix other stuff for the projects one is working on ;)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Its also possible that I need to get a newer version of Forge, as I've got...756 right now (from early yesterday trying to puzzle this stuff out).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

your texture folder should now be:

assets/yourModName/textures/blocks|items/###.png

 

rather than:

mods/yourModName/textures/blocks|items/###.png

 

Doesn't fix the problem for me.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

Aspergers is annoying sometimes :(

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

 

Replace all three with @EventHandler.  Leave everything else alone.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I'd suggest waiting then, if things don't work out. This is not a recommended release yet.

 

And about documentation, well you got javadocs and the commit log that's it I guess. That's not perfect but it's better than you can find many other places.

As a programmer you will need to learn not only to write documentation, but to study old code which has no such thing ;) Consider it a learning exercise or wait a week for the dust to settle ;)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

Replace all three with @EventHandler.  Leave everything else alone.

 

Just to make it more clear, with everything he means the parameter inputs as well, so don't change them either!

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

All I did was move my block name registry to preint and then nothing my texture code is what the tutiral on the wiki says.

 

Which tutorial?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share




  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • It worked thanks a lot ❤️ I'm gonna paste all of my code for anyone in the future looking to do capabilities package com.chickenwand3.rpgmod.core.capabilities.entity; import javax.annotation.Nullable; import net.minecraftforge.common.capabilities.Capability; import net.minecraftforge.common.capabilities.CapabilityManager; import net.minecraftforge.common.capabilities.CapabilityToken; import net.minecraftforge.common.capabilities.ICapabilityProvider; public class CapabilityMobLevel{ public static Capability<MobLevel> MOB_LEVEL_CAPABILITY = CapabilityManager.get(new CapabilityToken<>() {}); public static void register() { CapabilityManager.INSTANCE.register(MobLevel.class); } } package com.chickenwand3.rpgmod.core.capabilities.entity; public class DefaultMobLevel implements MobLevel { public int mobLevel; public float mobMaxHealth; public float mobCurrentHealth; public boolean crazy; public boolean isCrazy() { return crazy; } public float getMaxHealth() { return mobMaxHealth; } public float getCurrentHealth() { return mobCurrentHealth; } } package com.chickenwand3.rpgmod.core.capabilities.entity; public interface MobLevel { } package com.chickenwand3.rpgmod.core.capabilities.entity; import com.chickenwand3.rpgmod.RPGMod; import net.minecraft.resources.ResourceLocation; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Animal; import net.minecraft.world.entity.monster.Zombie; import net.minecraft.world.item.enchantment.Enchantments; import net.minecraftforge.common.capabilities.RegisterCapabilitiesEvent; import net.minecraftforge.event.AttachCapabilitiesEvent; import net.minecraftforge.event.entity.EntityJoinWorldEvent; import net.minecraftforge.event.entity.living.LivingDeathEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.common.Mod; @Mod.EventBusSubscriber(modid = RPGMod.MODID, bus = Mod.EventBusSubscriber.Bus.FORGE) public class MobLevelEventHandler { @SubscribeEvent public static void onAttachCapabilitiesEvent(AttachCapabilitiesEvent<Entity> event) { if (event.getObject() instanceof Mob && !event.getObject().getCommandSenderWorld().isClientSide) { MobLevelProvider providerMobLevel = new MobLevelProvider(); event.addCapability(new ResourceLocation(RPGMod.MODID, "moblevel"), providerMobLevel); event.addListener(providerMobLevel::invalidate); } } @SubscribeEvent public void registerCaps(RegisterCapabilitiesEvent event) { event.register(MobLevel.class); } @SubscribeEvent public static void OnSpawn(final EntityJoinWorldEvent event) { if (event.getEntity()instanceof Mob target && !event.getWorld().isClientSide) { target.getCapability(CapabilityMobLevel.MOB_LEVEL_CAPABILITY).ifPresent(mobLevel -> { DefaultMobLevel actualMobLevel = (DefaultMobLevel) mobLevel; if (actualMobLevel.mobLevel < 1) { actualMobLevel.mobLevel = (randomizeMobLevel()); } if (superCrazy(actualMobLevel.mobLevel)) { actualMobLevel.crazy = true; } if (actualMobLevel.crazy) { if (!target.getMainHandItem().isEmpty()) { target.getMainHandItem().enchant(Enchantments.FIRE_ASPECT, 1); } if (event.getEntity()instanceof Zombie zombie) { zombie.getAttribute(Attributes.SPAWN_REINFORCEMENTS_CHANCE).setBaseValue(0.99D); } System.out.println("Super Crazy " + target.getName() + " has spawned!"); } actualMobLevel.mobMaxHealth = (target.getMaxHealth() * actualMobLevel.mobLevel * 2); actualMobLevel.mobCurrentHealth = actualMobLevel.mobMaxHealth; target.getAttribute(Attributes.MOVEMENT_SPEED) .setBaseValue(target.getAttributeValue(Attributes.MOVEMENT_SPEED) * (1 + (actualMobLevel.mobLevel - 1.0) / 10.0)); if (target.getAttribute(Attributes.ATTACK_DAMAGE) != null) { target.getAttribute(Attributes.ATTACK_DAMAGE) .setBaseValue(target.getAttributeValue(Attributes.ATTACK_DAMAGE) * (1 + (actualMobLevel.mobLevel - 1.0) / 2.0)); } }); } } private static int randomizeMobLevel() { boolean roll = true; int level = 1; while (roll) { if (Math.random() > .5) { level += 1; roll = true; } else { roll = false; } } return level; } private static boolean superCrazy(int level) { boolean result = false; if (level >= 5) { if (Math.random() < .25) { result = true; } else result = false; } return result; } } package com.chickenwand3.rpgmod.core.capabilities.entity; import net.minecraft.core.Direction; import net.minecraft.nbt.CompoundTag; import net.minecraftforge.common.capabilities.Capability; import net.minecraftforge.common.capabilities.ICapabilitySerializable; import net.minecraftforge.common.util.LazyOptional; import javax.annotation.Nonnull; import javax.annotation.Nullable; public class MobLevelProvider implements ICapabilitySerializable<CompoundTag> { private final DefaultMobLevel mobLevel = new DefaultMobLevel(); private final LazyOptional<MobLevel> mobLevelOptional = LazyOptional.of(() -> mobLevel); public void invalidate() { mobLevelOptional.invalidate(); } @Nonnull @Override public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) { return mobLevelOptional.cast(); } @Override public CompoundTag serializeNBT() { System.out.println("It serialized"); if (CapabilityMobLevel.MOB_LEVEL_CAPABILITY == null) { System.out.println("It made a new compound"); return new CompoundTag(); } else { System.out.println("It serialized the values"); CompoundTag compoundNBT = new CompoundTag(); compoundNBT.putInt("mobLevel", mobLevel.mobLevel); compoundNBT.putFloat("mobCurrentHealth", mobLevel.mobCurrentHealth); compoundNBT.putFloat("mobMaxHealth", mobLevel.mobMaxHealth); compoundNBT.putBoolean("crazy", mobLevel.crazy); return compoundNBT; } } @Override public void deserializeNBT(CompoundTag nbt) { System.out.println("It deserialized"); if (CapabilityMobLevel.MOB_LEVEL_CAPABILITY != null) { System.out.println("It deserialized the values"); mobLevel.mobLevel = (nbt.getInt("mobLevel")); float mobCurrentHealth = nbt.getFloat("mobCurrentHealth"); mobLevel.mobCurrentHealth = (mobCurrentHealth); float mobMaxHealth = nbt.getFloat("mobMaxHealth"); mobLevel.mobMaxHealth = (mobMaxHealth); boolean crazy = nbt.getBoolean("crazy"); mobLevel.crazy = (crazy); } } }  
    • Just uploaded the correct installer from win machine to ubuntu via winscp. Sorry, didn't check the checksum. Very strange behavior :( Thank you!
    • I just tried it with both 36.2.0 and 36.2.19 using wget and the direct downloads. Both worked fine for me, giving me the correct MD5 sum. This is something on your machine.
    • And it's very strange, that if I try to download several times, this md5sum stays the same (6ecbb611d38ecd2c7bed8e1900e5dfc7).  
    • Wow! md5sum forge-1.16.5-36.2.0-installer.jar 6ecbb611d38ecd2c7bed8e1900e5dfc7  forge-1.16.5-36.2.0-installer.jar which doesn't align with original f2e0b8b9c7634fc854ce566f392dcded *forge-1.16.5-36.2.0-installer.jar and which is in my win download... Can you suggest what to use instead of wget?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.