Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Recommended Posts

I've been making some blocks in my mod, and I need the blocks to face a certain direction when placed, in a similar way to how a column/pillar will allow you to place it sideways so its top is facing the player. I've found some tutorials online, but they either don't work, or I'm given errors that I can't resolve. I'll post the code of what I've got so far.

 

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.HorizontalBlock;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.data.BlockModelFields.Rotation;
import net.minecraft.item.BlockItemUseContext;
import net.minecraft.state.DirectionProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.util.Mirror;
import net.minecraftforge.common.ToolType;

public class CoralPillar extends Block {
	
	private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING;
	
	public CoralPillar() {
		super(Block.Properties.create(Material.CORAL)
				.hardnessAndResistance(1.0f, 6.0f)
				.sound(SoundType.STONE)
				.harvestLevel(1)
				.harvestTool(ToolType.PICKAXE));
	}
	
	@Override
	public BlockState getStateForPlacement(BlockItemUseContext context) {
		return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite());
	}
	
	public BlockState rotate(BlockState state, Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}
	
	@Override
	public BlockState mirror(BlockState state, Mirror mirrorIn) {
		return state.rotate(mirrorIn.toRotation(state.get(FACING)));
	}
	
	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		builder.add(FACING);
	}
}

 

The error I'm getting is on line 34, reading "The method rotate(state.get(FACING)) is undefined for the type BlockModelFields.Rotation". I feel like the solution is simple, but I can't figure it out,

Link to post
Share on other sites
19 minutes ago, ehbean said:

The error I'm getting is on line 34, reading "The method rotate(state.get(FACING)) is undefined for the type BlockModelFields.Rotation". I feel like the solution is simple, but I can't figure it out,

the method is wrong yes you have to change it to this one (edit: the reason why you get the error you are using the wrong import)

	@Override
	public BlockState rotate(BlockState state, net.minecraft.util.Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}

and you never set the default state in the block constructor

you have to add:

this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

Edited by Luis_ST
Link to post
Share on other sites
31 minutes ago, Luis_ST said:

the method is correct but you never set the default state in the block constructor

you have to add:


this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

So adding that line "this.setDefaultState...." to the public BlockState rotate method doesn't seem to get ride of that error there, but I can avoid even needing to override those four methods by changing "CoralPillar extends Blocks" to "CoralPillar extends RotatedPillarBlock"? Wouldn't I need to change how that is loaded during registry so it doesn't crash?

Link to post
Share on other sites

you can look at how vanilla blocks that can be oriented implement that, I've looked at the furnace implementation when I learned it. in this case you should look at the quartz pillar block, or any log block

Edited by kiou.23
Link to post
Share on other sites
Just now, ehbean said:

Wouldn't I need to change how that is loaded during registry so it doesn't crash?

what do you mean? we don't have your registration code, so we can't tell

Link to post
Share on other sites
36 minutes ago, Luis_ST said:

the method is wrong yes you have to change it to this one (edit: the reason why you get the error you are using the wrong import)


	@Override
	public BlockState rotate(BlockState state, net.minecraft.util.Rotation rot) {
		return state.with(FACING, rot.rotate(state.get(FACING)));
	}

and you never set the default state in the block constructor

you have to add:


this.setDefaultState(this.stateContainer.getBaseState().with(FACING, Direction.NORTH));

and if you want to create a block that works like the quartz pillar,

then change the class that your block extends to RotatedPillarBlock so you don't have to overwrite the methods for the rotation

don't give people copy'n'paste code, especially without any explanation as to way they should copy and paste

  • Sad 1
Link to post
Share on other sites
5 minutes ago, kiou.23 said:

you can look at how vanilla blocks that can be oriented implement that, I've looked at the furnace implementation when I learned it. in this case you should look at the quartz pillar block, or any log block

I feel like looking at those files would be greatly beneficial. Where would I find those?

Link to post
Share on other sites
18 minutes ago, ehbean said:

I feel like looking at those files would be greatly beneficial. Where would I find those?

in your own IDE you can search for the blocks.

in IntelliJ you can use Ctrl + N, and type the name of the class you're looking for (RotatedPillarBlock, it's the class the logs use)

in Eclipse I think it is Ctrl + Shift + T, but I'm not sure

 

note that the vanilla and forge classes we'll be read-only, you can't edit them

  • Thanks 1
Link to post
Share on other sites

(Eclipse) F4 on any class name will open the type hierarchy (so if you did it on Block, you'd see all the subclasses, and if you did it on HorizontalBlock, you'd only see the subclasses of that). I can never remember the "go to definition" hotkey (it's F12 in Visual Studio, because of course I can remember that one), but hovering over a thing will give you an intellisense popup and clicking on the class identifier in that will do the same thing.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
25 minutes ago, kiou.23 said:

in your own IDE you can search for the blocks.

in IntelliJ you can use Ctrl + N, and type the name of the class you're looking for (RotatedPillarBlock, it's the class the logs use)

in Eclipse I think it is Ctrl + Shift + T, but I'm not sure

 

note that the vanilla and forge classes we'll be read-only, you can't edit them

I'm using Eclipse, and that is the right key shortcut. Just gotta figure out how to get this to work now. Copy pasting the variables, and methods doesn't' seem to work outright so I'll need to do some tweaking. 

Link to post
Share on other sites
4 hours ago, ehbean said:

I'm using Eclipse, and that is the right key shortcut. Just gotta figure out how to get this to work now. Copy pasting the variables, and methods doesn't' seem to work outright so I'll need to do some tweaking. 

That's usually the case, always try to understand the code before copy and pasting, or else you'll get a lot of headaches later in the code's life ;)

  • Thanks 1
Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • So I had no clue what topic to put this under because its not really modding with forge but modding forge itself. So I have terrain generation mods that are only server side and Bungeecord that has Geyser packet translator so people on bedrock edition can play as well, but when a bedrock player connects it gets a unknown packet error. I tested the proxy on a Spigot server verifying it was forge. With no mods installed I still get the error. I got a wireshark log of it all and I found the packet where it aborts the connection due to the invalid packet but I have no clue how to stop it. When I still had the mods installed I disabled the forge handshake protocol but it did not fix the issue. If you know what part of forge is doing this or a way to fix it all together that would be awesome. I know modifying forge can end really baddy (definitely the handshake protocol) but I think that is my only fix here. Im open to any suggestions tho. I have run out of ideas to fix it so any help would be nice. Also it seems the packet id causing the connection error is 0xFE but im not sure cause the client also sends back a packet with that ID. I have a whole bunch of info collected so if you need any more information on the issue, I willing to give it, just not the ips on the wireshark log.
    • Okay, I got it working correctly now, but I'm not sure how to make it work with multiple blocks.   My Block Code:   package expanded.blocks; import javax.annotation.Nullable; import expanded.VanillaBuildingBlocks; import net.minecraft.block.BlockState; import net.minecraft.block.RotatedPillarBlock; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.item.ItemStack; import net.minecraft.util.math.BlockPos; import net.minecraft.world.World; import net.minecraftforge.common.ToolType; public class CustomLog extends RotatedPillarBlock {            public CustomLog(Properties properties) {         super(properties);     }      @Override     @Nullable     public BlockState getToolModifiedState(BlockState state, World world, BlockPos pos, PlayerEntity player, ItemStack stack, ToolType toolType) {         return toolType == ToolType.AXE ? VanillaBuildingBlocks.acacia_log.defaultBlockState() : null;     } }
    • ? Registering the block and overriding a function inside the class are two completely different things
    • Ya but I'm not sure how I would actually add/implement it into the class correctly, and then registering the block correctly in my register class.
    • This tutorial from 1.12.2 is as easy as anyone could possibly explain it, it hasn't changed much til now except some slight changes here and there for you to figure out, it's pretty straightforward (https://www.planetminecraft.com/blog/forge-tutorial-capability-system/). Obviously instead of mana you'd just replace it with whatever else you're doing. All a capability is in essence is the ability to serialize/deserialize standard data types to an entity. When the player dies the game creates a new instance of a PlayerEntity object so your data won't automatically "transfer" over to that new object unless as you say, you copy the data over in an event hook. After you have this set up, if you want to access the data you store in player capabilities you create a class with a static get function that retrieves it.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.