1.16.5 ore generation not working

[djofox]

So basically I tried updating my 1.12.2 ore generation to 1.16.5, long story short theres a massive change. I finally got it without eclipse problems through looking at a couple githubs, but it doesnt work. I feel like im overlooking an obvious problem but I cant see it. If someone could help me out that'd be great.

Heres my code for the ore gen.

@Mod.EventBusSubscriber(modid = Main.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)

public class ModOreGen {

	public static void generateOres(final BiomeLoadingEvent event) {
		if (!(event.getCategory().equals(Biome.Category.NETHER) || event.getCategory().equals(Biome.Category.THEEND))) {
			buildOreFeature(BlockInit.BERYLORE.get(), Blocks.GRASS, 10, 0, 100, 20);
		}
	}
	
    private static ConfiguredFeature<?, ?> buildOreFeature(Block ore, Block filler, int maxVeinSize, int minVeinLevel, int maxVeinLevel, int spawnRate) {
        ConfiguredFeature<?, ?> feature = Feature.ORE.configured(new OreFeatureConfig(new BlockMatchRuleTest(filler), ore.defaultBlockState(), maxVeinSize));
        feature = minMaxRange(feature, minVeinLevel, maxVeinLevel).squared();
        feature = feature.count(spawnRate);
        return feature;
    }
	    private static IDecoratable<ConfiguredFeature<?,?>> minMaxRange(IDecoratable<ConfiguredFeature<?,?>> f, int min, int max) {
	        return f.decorated(Placement.RANGE.configured(new TopSolidRangeConfig(min, min, max)));
	    }
}

And heres where I call it

	public Main() {
		IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
		bus.addListener(this::setup);
		
		ItemInit.ITEMS.register(bus);
		BlockInit.BLOCKS.register(bus);
		MinecraftForge.EVENT_BUS.register(this);
		MinecraftForge.EVENT_BUS.register(FuelHandler.instance);
		PotionList.EFFECTS.register(bus);
		PotionList.POTIONS.register(bus);
		MinecraftForge.EVENT_BUS.addListener(EventPriority.HIGH, ModOreGen::generateOres);
		
	}

 

[kiou.23]

	public static void generateOres(final BiomeLoadingEvent event) {
		if (!(event.getCategory().equals(Biome.Category.NETHER) || event.getCategory().equals(Biome.Category.THEEND))) {
			buildOreFeature(BlockInit.BERYLORE.get(), Blocks.GRASS, 10, 0, 100, 20);
		}
	}

you're not actually adding the features to the biome, the return value of your method is just getting ignored, in mcp the method that you call is BiomeGenerationSettingsBuilder#withFeature, in mojmaps I don't know

 

    private static ConfiguredFeature<?, ?> buildOreFeature(Block ore, Block filler, int maxVeinSize, int minVeinLevel, int maxVeinLevel, int spawnRate) {
        ConfiguredFeature<?, ?> feature = Feature.ORE.configured(new OreFeatureConfig(new BlockMatchRuleTest(filler), ore.defaultBlockState(), maxVeinSize));
        feature = minMaxRange(feature, minVeinLevel, maxVeinLevel).squared();
        feature = feature.count(spawnRate);
        return feature;
    }

this is not how you should create a ConfiguredFeature

1- I suggest you keep each feature in a static field

2- you need to actually Register the feature, or the game won't know about it, you can do so by calling Registry.register, and registering your feature to the Configured Features registry which can be found under the class WorldGenRegistries

3- you can chain the count, squared and so on methods, it'll make your code look cleaner

 

MinecraftForge.EVENT_BUS.addListener(EventPriority.HIGH, ModOreGen::generateOres);

There's no need set it to a high priority, and you're registering the listener to the wrong event bus

[wforte6]

Question? where are you getting the minMaxRange function from

is that a custom written function

Edited May 26, 2021 by wforte6

[Draco18s]

On 4/16/2021 at 12:47 PM, djofox said:

@Mod.EventBusSubscriber(modid = Main.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)

public class ModOreGen {

    public static void generateOres(final BiomeLoadingEvent event) {

Your event handler method will not be called because it is not annotated with @SubscribeEvent

[Luis_ST]

57 minutes ago, wforte6 said:

Question? where are you getting the minMaxRange function from

is that a custom written function

create your own thread

23 minutes ago, Draco18s said:

Your event handler method will not be called because it is not annotated with @SubscribeEvent

you should look again, at the first post from the author of this thread

Edited May 26, 2021 by Luis_ST

[Draco18s]

1 hour ago, Luis_ST said:

you should look again, at the first post from the author of this thread

You mean this part?

On 4/16/2021 at 12:47 PM, djofox said:

MinecraftForge.EVENT_BUS.addListener(EventPriority.HIGH, ModOreGen::generateOres);

Then why did you annotate the class for automatic registration if you were just going to fuckoff and register its only method manually?