Jump to content

Recommended Posts

Posted

I want players to teleport to there spawn point this is the code I've use (it crashes with a null Point exception):

 

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

EntityPlayer player = (EntityPlayer) entityIn;

entityIn.setPosition(player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getX(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getY(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

  • Replies 77
  • Created
  • Last Reply

Top Posters In This Topic

Posted

Updated code:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Posted

You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase...

 

While this is true it wouldn't produce NPE, but CCE.

 

Question is - what is null there? My bet is on #getBedSpawnLocation. Also - this method might be called on both sides - it is worth checking that and place proper server side-check if that is a case (maybe its null on client and present on server and client is crashing?).

 

If you can't figure it out - please say at which line it crashes.

1.7.10 is no longer supported by forge, you are on your own.

Posted

Changed to:

@Override

@SideOnly(Side.SERVER)

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Posted

What if this code is going to be run in a SinglePlayer world wouldn't it crash because the method doesn't exist

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Are you talking about in the case of

@SideOnly

?

If so: no, because the method is never directly referred to, Minecraft only refers to the overridden method (the one in Block). It would simply not work in SinglePlayer.

If not: Please clarify.

Well you were correct so it won't crash, but it won't work. That just changes the reason to not use it. Unless the OP wants it to only work on a dedicated server.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

This is how the codes looks like now:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

}

Posted

Yes,

@SideOnly

should not be used (unless you really know what you are doing). Which is why I linked both an article called "Why not to use

@SideOnly

" and a tutorial about the concept of sides in Minecraft.

Yes I understood what they do, but once I get some sleep and my brain is working "better" than it is currently I will read all of what you posted to understand it better. Thank you again diesieben.

 

This is how the codes looks like now:

@Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
	if (!worldIn.isRemote) {
		if (entityIn instanceof EntityLivingBase) {
			if (entityIn instanceof EntityPlayer) {
				EntityPlayer player = (EntityPlayer) entityIn;
				BlockPos spawnPosition = player.getBedLocation();
				entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			} else {
				entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),
						worldIn.getSpawnPoint().getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			}
		}
	}
}

Can I assume it is still not working? Also if your code for the TeleportCommand is not "readable" then you should update forge to its most recent version and see if it is readable then.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

I have removed one of the instanceof checks:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

But I still don't know how to use the commandteleport code

Posted

Changed it to this:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

((EntityPlayerMP) entityIn).connection.setPlayerLocation(spawnPosition.getX(), spawnPosition.getY(),

spawnPosition.getZ(), player.getRotationYawHead(), player.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),

worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),

entityIn.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

Testing now

Posted

Why are you casting the entity to an EntityPlayer if it is not an instanceof EntityPlayer

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),
                  worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),
                  entityIn.getRotationYawHead());
            entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
            worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
                  entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
         }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried do download the essential mod to my mod pack but i didnt work. I paly on 1.21 and it should work. I use neoforge for my modding. The weird things is my friend somehow added the mod to his modpack and many others that I somehow can´t. Is there anything i can do? 
    • Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.