Jump to content

MC 1.10+ returning an item with metadata


winnetrie

Recommended Posts

I'm trying to get an item from a stack but with the metadata.

If i do this:

ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite,1,3);
Item item= stack.getItem();

 

It does not give me the item with metadata 3, but instead give me always the 0.

Here an example why i need this:

@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite,1,3);
	Item item= stack.getItem();

	return item;
}

And here another example why i need this:

	List<IRecipe> recipes = CraftingManager.getInstance().getRecipeList();
    	Iterator<IRecipe> Leash = recipes.iterator();
    			         
    		while (Leash.hasNext()) {
    			ItemStack is = Leash.next().getRecipeOutput();
    			
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.SANDSTONE_STAIRS))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.RED_SANDSTONE_STAIRS))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.BRICK_BLOCK))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.STONEBRICK))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.STONE_BRICK_STAIRS))
    				Leash.remove();
    			ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
    			Item item = stack.getItem();
    			if (is != null && is.getItem() == item){
    				Leash.remove();
    			}
    		};

I want in the recipe remover only removing that subblock, but it removes them all.

So how do i get the right item for it?

Link to comment
Share on other sites

if (is != null && is.getItem() == Items.APPLE && is.getMetadata() == 1) {
     // Do stuff
}

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I love how this code:

    			ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
    			Item item = stack.getItem();
    			if (is != null && is.getItem() == item){
    				Leash.remove();
    			}

Sets up a variant item stack, then ignores the shit out of it.

 

Also, dude, seriously, wrap all of this in a single if(is != null) check. Simplify your life.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

if (is != null && is.getItem() == Items.APPLE && is.getMetadata() == 1) {
     // Do stuff
}

 

Oh right, it looks like i did it wrong before.

 

@Draco

You mean because i make variables for it while it isn't needed? I know this, i change it later. I do it for testing purpose only.

 

Also for the creative tabs i still can't get it working.

 

This is what i have now:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite);
	Item item = stack.getItem();
	return item;
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

I looked into the creativetabs class and found this getIconItemDamage() method wich i hoped it would do what i needed, but insetad i now have a black/purple square icon in my creative tab.

Link to comment
Share on other sites

I made it cleaner now (i think  :D)

 

	List<IRecipe> recipes = CraftingManager.getInstance().getRecipeList();
    	Iterator<IRecipe> Leash = recipes.iterator();
    			         
    		while (Leash.hasNext()) {
    			ItemStack is = Leash.next().getRecipeOutput();
    			if (is !=null){
    				if (is.getItem() == Item.getItemFromBlock(Blocks.SANDSTONE_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.RED_SANDSTONE_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.BRICK_BLOCK))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONEBRICK))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONE_BRICK_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONE_SLAB) && is.getMetadata()==5){
    					Leash.remove();
    				}
    			}
    		};

 

and:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	return new ItemStack(ModBlocks.bricksstairwhite).getItem();
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

Link to comment
Share on other sites

@Draco

You mean because i make variables for it while it isn't needed? I know this, i change it later. I do it for testing purpose only.

 

No, I mean you create an item stack with an item and metadata value, then discard the stack for the item.

 

This:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
Item item = stack.getItem();

And this:

Item item = Item.getItemForBlock(Blocks.STONE_SLAB);

Are identical.

As would:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,14);
Item item = stack.getItem();

And:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,0);
Item item = stack.getItem();

As well as:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,123456789);
Item item = stack.getItem();

 

Your updated code handles it correctly, of course.  Even if it was "just for testing" it should have been apparent that an Item (which has no concept of metadata) isn't magically different after wrapping it into, then extracting it from, an ItemStack.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

No, I mean you create an item stack with an item and metadata value, then discard the stack for the item.

 

Oh yes, true. I do understand now. Sorry... :P

 

Edit:

Sometimes i wonder why things aren't working and after a while i realize i have been stupid lol! this happens to often

Ofc this isn't working:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite);
	Item item = stack.getItem();
	return item;
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

Why? because ModBlocks.bricksstairwhite has no subtypes....

That's why it is called bricksstairwhite

 

Just tried this method getIconItemDamage() with the other tabs and it's all working fine!

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.