Adding textures to items?

Animus_Surge · July 25, 2018

I've been looking over the forge documentation for adding models and textures to items in 1.12.2, and I feel like it's not really giving me a clear answer. I'm making a test item to see if it would work so I can add crafting components to my mod with no special abilities of their own. I scroll down to the item part of this page, and look over the instructions three times, and it still isn't clear. Can someone help me figure this out?

_Cruelar_ · July 25, 2018

Try this guide

McJty:Render your Item

Animus_Surge · July 25, 2018

I do that and it gives me an error with the [email protected] line in my code. Heres what the code for the ModItems class looks like:

package net.overgrownportal.item;

import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ModItems{
	
    //gives me error on the line below...
    @GameRegistry.ObjectHolder("overgrownportal:itemlightbridge")
    public static ItemLightBridge itemLightBridge;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
        itemLightBridge.initModel();
    }
}

And the code for the item:

package net.overgrownportal.item;

import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.overgrownportal.mod.OvergrownPortal;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.client.renderer.texture.SimpleTexture;
import net.minecraft.creativetab.*;

public class ItemLightBridge extends Item{
	public ItemLightBridge() {
        setRegistryName("hardlightbridge");
        setUnlocalizedName(OvergrownPortal.MODID + ".hardlightbridge");
    }

    @SideOnly(Side.CLIENT)
    public void initModel() {
        ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
    }
}

_Cruelar_ · July 25, 2018

Please post the log for more help but have you registered it in your common code.(In the guide it's a CommonProxy which would be false. refer to Code Style #1)

Animefan8888 · July 25, 2018

28 minutes ago, Animus_Surge said:

Can someone help me figure this out?

Simply put you need an item instance so new Item(...). Then you need to subscribe to the RegistryEvent.Register<Item> and register your item. Then subscribe to ModelRegistryEvent and call ModelLoader.setCustomModelResourceLocation(yourItemInstance, the metadata, and then the model location). The model location is a ModelResourceLocation. Typically it is instantiated by passing in your items registry name and then a string called inventory.

DaemonUmbra · July 25, 2018

Objectholder takes the registry name, in yours they do not match.

Animus_Surge · July 25, 2018

3 minutes ago, DaemonUmbra said:

Objectholder takes the registry name, in yours they do not match.

Can you tell me how to make them match?

_Cruelar_ · July 25, 2018

Simply use the String you typed in in setRegistryName() after your modid in your case hardlightbridge

So complete it would be modid:registryName

Edited July 25, 2018 by _Cruelar_

Animus_Surge · July 25, 2018

It looks like this now:

package net.overgrownportal.item;

import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ModItems{

    @GameRegistry.ObjectHolder("overgrownportal:hardlightbridge")
    public static ItemLightBridge itemLightBridge;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
        itemLightBridge.initModel();
    }
		
}

but it still gives me the same error

Animus_Surge · July 25, 2018

and I forget to change the modid from the original when I got the MDK for 1.12.2. So that explains the mismatch with the modid, but still the same error

Edited July 25, 2018 by Animus_Surge
did not fix the error after all...

_Cruelar_ · July 25, 2018

As I said logs would help to find the problem

_Cruelar_ · July 25, 2018

Do you register it some where with this:

event.getRegistry().register(new Triforce());

(Triforce is a normal Item in my mod)

Animefan8888 · July 25, 2018

6 minutes ago, Animus_Surge said:

but it still gives me the same error

Do you have the import?

Animus_Surge · July 25, 2018

2 minutes ago, Animefan8888 said:

Do you have the import?

I do

I fixed it by looking through the net.minecraftforge.fml.common.registry package, so I have no code errors anymore. The ModItems class now looks like this:

package net.overgrownportal.item;

import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class ModItems{

    @GameRegistry.ObjectHolder("overgrownportal:hardlightbridge")
    public static ItemLightBridge itemLightBridge;

    @SideOnly(Side.CLIENT)
    public static void initModels() {
        itemLightBridge.initModel();
    }
		
}

so now I need to figure out how to call on the itemlightbridge.json file.

Draco18s · July 25, 2018

1 minute ago, Animus_Surge said:

so now I need to figure out how to call on the itemlightbridge.json file.

Well, you have an initModels method. Are you calling it from anywhere?

Also, please do not go marking methods with @SideOnly unless you know what you are doing

_Cruelar_ · July 25, 2018

Simply insert the json at the right place, it should work then.

BTW: Is this a Portalgun expansion of a kind. Like adding lightbridges, fizzlers etc.

Animefan8888 · July 25, 2018

1 minute ago, Animus_Surge said:

so now I need to figure out how to call on the itemlightbridge.json file.

If you use

ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(getRegistryName(),...) then it will look for a file at assets/modid/models/item/registryname.json

Animus_Surge · July 25, 2018

Just now, _Cruelar_ said:

Simply insert the json at the right place, it should work then.

BTW: Is this a Portalgun expansion of a kind. Like adding lightbridges, fizzlers etc.

pretty much, because IDK when the real mod's fizzler will come back and that actually works in the newer versions

Animus_Surge · July 25, 2018

1 minute ago, Animefan8888 said:

If you use

ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(getRegistryName(),...) then it will look for a file at assets/modid/models/item/registryname.json

what do I replace "meta" with?

DaemonUmbra · July 25, 2018

~~The ObjectHolder annotation is described on this page of the Forge Documentation, please read it.~~

~~Also your registry name setup right now is broken, I recommend~~

setRegistryName(MODID,"ItemName")

~~otherwise using getRegistryName() within setCustomModelResourceLocation() will be telling Minecraft to look within itself for your model files.~~

It appears I am behind the times.

Edited July 25, 2018 by DaemonUmbra

_Cruelar_ · July 25, 2018

4 minutes ago, Animus_Surge said:

pretty much, because IDK when the real mod's fizzler will come back and that actually works in the newer versions

I think the fizzlers wil never come. As I know the mod is dead/in a zombie-like state getting only ported to new versions.

I would really like to see the things out of 1.7.10 Portalgun mod into 1.12.2 or 1.13.

1 minute ago, DaemonUmbra said:
The ObjectHolder annotation is described on this page of the Forge Documentation, please read it.

Also your registry name setup right now is broken, I recommend
setRegistryName(MODID,"ItemName")
otherwise using getRegistryName() within setCustomModelResourceLocation() will be telling Minecraft to look within itself for your files.

Wait why broken? I use it quite the same way and he registers it as stuff of my mod.

Animefan8888 · July 25, 2018

1 minute ago, Animus_Surge said:

what do I replace "meta" with?

In your case 0, but some items have a magical number that allows you to differentiate between different states, or in some cases a "new item".

Also dont disregard the advice of the other people especially DaemonUmbra. They know what they are talking about a lot of the time.

Animefan8888 · July 25, 2018

3 minutes ago, DaemonUmbra said:

otherwise using getRegistryName() within setCustomModelResourceLocation() will be telling Minecraft to look within itself for your files.

This isn't true forge will automatically append your mods modid as long as it is your mod that it is constructing, aka dont use static initializers.

DaemonUmbra · July 25, 2018

~~Checking the GitHub it looks like that's relatively new,~~ I did not know that was a thing.

Edit: Nope I'm just a massive derp, I could've sworn I had an issue with this in the past.

Edited July 25, 2018 by DaemonUmbra

Animus_Surge · July 25, 2018

No code errors after fixing a bunch of errors, and my game crashes with the following:

[15:00:09] [main/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:629]: ---- Minecraft Crash Report ----
// Shall we play a game?

Time: 7/25/18 3:00 PM
Description: Initializing game

java.lang.NullPointerException: Initializing game
	at net.minecraftforge.client.model.ModelLoader.setCustomModelResourceLocation(ModelLoader.java:1090)
	at net.overgrownportal.item.ItemLightBridge.<init>(ItemLightBridge.java:19)
	at net.overgrownportal.mod.CommonProxy.registerItems(CommonProxy.java:16)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_5_CommonProxy_registerItems_Register.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:757)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:628)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:246)
	at net.minecraft.client.Minecraft.init(Minecraft.java:513)
	at net.minecraft.client.Minecraft.run(Minecraft.java:421)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Client thread
Stacktrace:
	at net.minecraftforge.client.model.ModelLoader.setCustomModelResourceLocation(ModelLoader.java:1090)
	at net.overgrownportal.item.ItemLightBridge.<init>(ItemLightBridge.java:19)
	at net.overgrownportal.mod.CommonProxy.registerItems(CommonProxy.java:16)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_5_CommonProxy_registerItems_Register.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:757)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:628)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:246)
	at net.minecraft.client.Minecraft.init(Minecraft.java:513)

-- Initialization --
Details:
Stacktrace:
	at net.minecraft.client.Minecraft.run(Minecraft.java:421)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)

-- System Details --
Details:
	Minecraft Version: 1.12.2
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_172, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 746705472 bytes (712 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
	JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
	IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
	FML: MCP 9.42 Powered by Forge 14.23.4.2739 7 mods loaded, 7 mods active
	States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

	| State | ID              | Version      | Source                           | Signature |
	|:----- |:--------------- |:------------ |:-------------------------------- |:--------- |
	| UCH   | minecraft       | 1.12.2       | minecraft.jar                    | None      |
	| UCH   | mcp             | 9.42         | minecraft.jar                    | None      |
	| UCH   | FML             | 8.0.99.99    | forgeSrc-1.12.2-14.23.4.2739.jar | None      |
	| UCH   | forge           | 14.23.4.2739 | forgeSrc-1.12.2-14.23.4.2739.jar | None      |
	| UCH   | overgrownportal | 1.0          | bin                              | None      |
	| UCH   | ichunutil       | 7.0.2        | iChunUtil-1.12.2-7.0.2.jar       | None      |
	| UCH   | portalgun       | 7.0.2        | PortalGun-1.12.2-7.0.2.jar       | None      |

	Loaded coremods (and transformers): 
	GL info: ' Vendor: 'Intel' Version: '4.5.0 - Build 22.20.16.4836' Renderer: 'Intel(R) HD Graphics 620'
	Launched Version: 1.12.2
	LWJGL: 2.9.4
	OpenGL: Intel(R) HD Graphics 620 GL version 4.5.0 - Build 22.20.16.4836, Intel
	GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'fml,forge'
	Type: Client (map_client.txt)
	Resource Packs: 
	Current Language: English (US)
	Profiler Position: N/A (disabled)
	CPU: 4x Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
[15:00:09] [main/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:629]: #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\swag100107\Desktop\forge 1.12.2\run\.\crash-reports\crash-2018-07-25_15.00.09-client.txt

Sign In

Adding textures to items?

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information