[1.14.4] Worldgen issues

[Crack3dC0d3]

I'm trying to let some structures spawn via vanilla worldgen. I have a class implementing IWorldGenerator and added stuff to generate the structure. I think i have to register it somewhere but i dont know where and how. Can someone help?

[Crack3dC0d3]

Alright, I've found out the existence of the Feature class but i dont know how to use it. Please help

 

[Crack3dC0d3]

Update again, i think i setup the feature correctly and registered it. But it didnt spawn. Not at all. Any help?

[Animefan8888]

4 minutes ago, Crack3dC0d3 said:

But it didnt spawn. Not at all. Any help?

Huh? Help with what I don't see what I could help with. You've provided no way for me to provide actual assistance.

[Crack3dC0d3]

Alright, I''m trying to spawn trees in my normal world. I already got the nbt files but i cant seem to fix how the "Feature" class works. (If i'm actually supposed to use that one) heres my code now

 

public class SilverwoodFeature extends Feature<NoFeatureConfig> {
    public SilverwoodFeature(Function<Dynamic<?>, ? extends NoFeatureConfig> configFactoryIn) {
        super(configFactoryIn);
    }

    @Override
    public boolean place(IWorld world, ChunkGenerator<? extends GenerationSettings> generator, Random random, BlockPos spawnPos, NoFeatureConfig config) {
        ServerWorld worldserver = (ServerWorld) world;
        TemplateManager templatemanager = worldserver.getStructureTemplateManager();
        Template template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/greatwoodtree"));
        int h = ThreadLocalRandom.current().nextInt(0, 7);
        switch(h) {
            case 1: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood1")); break;
            case 2: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood2")); break;
            case 3: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood3")); break;
            case 4: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood4")); break;
            case 5: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood5")); break;
            case 6: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood6")); break;
            case 7: template = templatemanager.getTemplate(new ResourceLocation("arcana", "trees/silverwood/silverwood7")); break;
        }

        if(random.nextInt(1) != 0 || world.getBiome(spawnPos) != Biomes.PLAINS) {
            return false;
        }

        if(template == null) {
            Constants.LOGGER.error("Could not find structure at " + new ResourceLocation("arcana:structures/trees/greatwood"));
            return false;
        }
        PlacementSettings placementsettings = (new PlacementSettings()).setMirror(Mirror.NONE)
                .setRotation(Rotation.NONE).setIgnoreEntities(false).setChunk(null);

        template.addBlocksToWorld(world, spawnPos.add(-4, 0, -4), placementsettings);
        return true;
    }

[Animefan8888]

11 hours ago, Crack3dC0d3 said:

.setChunk(null);

You may want to set the chunk to the chunk you are in.You can get it from the IWorld parameter using the BlockPos parameter you were given.

 

11 hours ago, Crack3dC0d3 said:

I already got the nbt files

Where are they located?

[Crack3dC0d3]

11 hours ago, Animefan8888 said:

Where are they located?

Thats not the problem since saplings work with the same files. But they are located in resources/data/arcana/structures.. Oh wait thats not right


EDIT: It is right, Nevermind. But still, they dont spawn in the world. The saplings do work though

 

 

11 hours ago, Animefan8888 said:

You may want to set the chunk to the chunk you are in.You can get it from the IWorld parameter using the BlockPos parameter you were given.

Tried that, Doesnt change anything.

I got no errors in the console

Edited August 21, 2019 by Crack3dC0d3

[Animefan8888]

10 hours ago, Crack3dC0d3 said:

But still, they dont spawn in the world. The saplings do work though

So then are the features getting called? Is the template returning null? Are you adding the feature to a biomes list of features?

[Crack3dC0d3]

2 hours ago, Animefan8888 said:

Are you adding the feature to a biomes list of features?

See, I forgot something. How can i do that? 

[Animefan8888]

28 minutes ago, Crack3dC0d3 said:

See, I forgot something. How can i do that? 

Biome#addFeature

[Crack3dC0d3]

Alright thanks, which parameters do i use? i got the first 2 but i dont understand the last 2

 

[Animefan8888]

21 minutes ago, Crack3dC0d3 said:

Alright thanks, which parameters do i use? i got the first 2 but i dont understand the last 2

Biome#addFeature only has two parameters.

[Crack3dC0d3]

Sorry, wrong method. I meant Biome#createDecoratedFeature

[Animefan8888]

24 minutes ago, Crack3dC0d3 said:

Sorry, wrong method. I meant Biome#createDecoratedFeature

I'm not sure to be honest look for where the trees are added in vanilla.

[Crack3dC0d3]

I figured it out thanks a lot!

[hohserg]

Did anyone found how to port IWorldGenerator to Feature? I still wander in the dark. Help plz

[Ugdhar]

3 minutes ago, hohserg said:

Did anyone found how to port IWorldGenerator to Feature? I still wander in the dark. Help plz

Please start a new thread for your issue instead of posting in a nearly year old one, you'll get a better response

 

Also, include a description of what you are trying to do (from the gameplay standpoint; not HOW you want to do it), what you have tried (code is good, a github repo link is best), and logs (debug.log posted as a github gist is best)

Doing these things will ensure you get the best possible response. An incomplete post is an invitation to just have it skipped over!! ?

Edited June 15, 2020 by Ugdhar

[Draco18s]

2 hours ago, hohserg said:

Did anyone found how to port IWorldGenerator to Feature? I still wander in the dark. Help plz

TLDR: you don't. You rewrite it from scratch.