Knockback event...

[Scholler]

Can't find a way to reopen thread.

This problem still persists, using 1.15.2!

[Ugdhar]

Post your code, preferrably as a github repo, and debug.log as well, it should give us enough info to figure out why it's not working

[Scholler]

9 minutes ago, Ugdhar said:

Post your code, preferrably as a github repo, and debug.log as well, it should give us enough info to figure out why it's not working

https://pastebin.com/5VUf4rXC

I hope you can see how it should be working, but its not.
Also, idk debug.log, but it just doesn't do the System.out.println() at all. Nothing.
And in this thread again: This event is supposed to call when I get knockback, right? So e.g a player punch me?

[Draco18s]

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        public void onKb (LivingKnockBackEvent e) {

 

So, two problems.

1) You're using the wrong bus
2) your method isn't static

[Scholler]

11 hours ago, Draco18s said:

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        public void onKb (LivingKnockBackEvent e) {

 

So, two problems.

1) You're using the wrong bus
2) your method isn't static

So what should I use? Basically every other events work perfectly in that class, except for that one.

[Boy132]

25 minutes ago, Scholler said:

So what should I use? Basically every other events work perfectly in that class, except for that one.

There are basically two buses to choose from: https://mcforge.readthedocs.io/en/1.15.x/events/intro/

You can figure it out.  

[Scholler]

8 hours ago, Boy132 said:

There are basically two buses to choose from: https://mcforge.readthedocs.io/en/1.15.x/events/intro/

You can figure it out.  

Didn't test it yet, but why wouldn't this event bus work? ._.

[Draco18s]

36 minutes ago, Scholler said:

Didn't test it yet, but why wouldn't this event bus work? ._.

Think of an event bus like an email address.

If you only get work related emails at your work address, then write a bot to tell you when you have new messages from your boss, but tell it to check your personal email address.

Would you expect it to work?
No?

Why not?

[Scholler]

32 minutes ago, Draco18s said:

Think of an event bus like an email address.

If you only get work related emails at your work address, then write a bot to tell you when you have new messages from your boss, but tell it to check your personal email address.

Would you expect it to work?
No?

Why not?

OK I GET IT

[Scholler]

Not working.

[Scholler]

22 hours ago, Scholler said:

And in this thread again: This event is supposed to call when I get knockback, right? So e.g a player punch me?

Can someone confirm this?

[Draco18s]

I said you had two problems.

Did you fix both?

[Scholler]

7 minutes ago, Draco18s said:

I said you had two problems.

Did you fix both?

Where am I supposed to put ,,static'' ?

[Draco18s]

23 hours ago, Draco18s said:

2) your method isn't static

https://lmgtfy.com/?q=java+static+method

[Scholler]

1 hour ago, Draco18s said:

https://lmgtfy.com/?q=java+static+method

Not working.

[Scholler]

34 minutes ago, diesieben07 said:

Post updated code instead of just barking "not working, spoonfeed me more code".

I'm trying to get this to work, been trying for more than one day now, and I'm not asking for any code. Probably you think I'm stupid, well, I'm not. Actually you still didn't answer my question, where I asked if this event should get called when I get hit in game, so I take knockback, because I don't see why wouldn't this work. If you want the code, there: https://pastebin.com/EuZkaUUe.
AND if you really want to reply, you should help, not insult me or think that I'm so stupid I don't even know what's static method, or if you can't reply normally, then just don't, dear Forum Team member.

Edited April 30, 2020 by Scholler
Added important detail

[loordgek]

17 minutes ago, Scholler said:

I don't even know what's static method

you need to learn java first before modding

and if you dont know something use google most of the time it has a good answer

[Draco18s]

So. When I said you needed static, your code looked like this:

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        public void onKb (LivingKnockBackEvent e) {

using an annotation.

 

Now it looks like this:

    MinecraftForge.EVENT_BUS.register(new KnockbackR());
...
    public static class KnockbackR { //Tried without static, tried with only the class static.
        public static void onKb(LivingKnockBackEvent e) {
            System.out.println("Called");
            no, not called
        }
    }

Why did you change something I didn't tell you to change? Now the fact that your method is static is the problem.

(The class being static is basically irrelevant, but it should be static anyway, but that's not the method its the class).

 

You HAVE THIS for godsake.

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        a normal void WHICH STILL WORKING
    }

Although it appears you couldn't be arsed to show the method signature of a working event, because you also have this for some reason:

        MinecraftForge.EVENT_BUS.register(new RegistryEvents());

So who knows which one of the two registrations is working for the handlers that are working correctly.

Edited April 30, 2020 by Draco18s

[Scholler]

12 hours ago, loordgek said:

you need to learn java first before modding

and if you dont know something use google most of the time it has a good answer

lmao.

 

13 hours ago, Scholler said:

you should help, not insult me or think that I'm so stupid I don't even know what's static method

I see you dont get it

[Scholler]

12 hours ago, Draco18s said:

So. When I said you needed static, your code looked like this:

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        public void onKb (LivingKnockBackEvent e) {

using an annotation.

 

Now it looks like this:

    MinecraftForge.EVENT_BUS.register(new KnockbackR());
...
    public static class KnockbackR { //Tried without static, tried with only the class static.
        public static void onKb(LivingKnockBackEvent e) {
            System.out.println("Called");
            no, not called
        }
    }

Why did you change something I didn't tell you to change? Now the fact that your method is static is the problem.

(The class being static is basically irrelevant, but it should be static anyway, but that's not the method its the class).

 

You HAVE THIS for godsake.

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        a normal void WHICH STILL WORKING
    }

Although it appears you couldn't be arsed to show the method signature of a working event, because you also have this for some reason:

        MinecraftForge.EVENT_BUS.register(new RegistryEvents());

So who knows which one of the two registrations is working for the handlers that are working correctly.

 

12 hours ago, Draco18s said:

So. When I said you needed static, your code looked like this:

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        public void onKb (LivingKnockBackEvent e) {

using an annotation.

 

Now it looks like this:

    MinecraftForge.EVENT_BUS.register(new KnockbackR());
...
    public static class KnockbackR { //Tried without static, tried with only the class static.
        public static void onKb(LivingKnockBackEvent e) {
            System.out.println("Called");
            no, not called
        }
    }

Why did you change something I didn't tell you to change? Now the fact that your method is static is the problem.

(The class being static is basically irrelevant, but it should be static anyway, but that's not the method its the class).

 

You HAVE THIS for godsake.

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public class RegistryEvents {
        @SubscribeEvent
        a normal void WHICH STILL WORKING
    }

Although it appears you couldn't be arsed to show the method signature of a working event, because you also have this for some reason:

        MinecraftForge.EVENT_BUS.register(new RegistryEvents());

So who knows which one of the two registrations is working for the handlers that are working correctly.

OK.
Gonna test.

[loordgek]

1 hour ago, Scholler said:

you should help, not insult me or think that I'm so stupid I don't even know what's static method

i am not insulting you or call you stupid

i am just telling you to learn java, it will help you in the long run

everybody here needed to learn at some point

[Draco18s]

3 hours ago, Scholler said:

lmao.

 

I see you dont get it

Quote

Modder Support

This is the support section for those modding with Forge. Help with modding goes in here, however, please keep in mind that this is not a Java school. You are expected to have basic knowledge of Java before posting here.

 

[Scholler]

no

I have never said I don't even know what a static method is
I said you shouldn't think that I don't know what a static method is
I see you quote the part where I said what you shouldn't think about me, no problem.
I still haven't figured it out, nothing worked, so at this point I'm just kinda searching the internet, and I'm spending less time on coding this mod

[Draco18s]

46 minutes ago, Scholler said:

I have never said I don't even know what a static method is

Right:

 

On 4/30/2020 at 1:44 PM, Scholler said:

Where am I supposed to put ,,static'' ?

[Turtledove]

Rule 1 of asking a question: don't get butthurt when someone points out you don't know shit, that's what you're here to supposedly solve.

 

Rule 2, nobody is even obligated to help you, be courteous.

 

Everything in that doc is plenty to solve your issue, registering an event handler, and subscribing to an event is less than 5 lines of code. That doc outlines what to do depending on the functionality you want, in this case Draco thoroughly explained your method must be static. So when you register your event handler, you must pass in an instance of the class, or you can annotate your class.