[1.16.5] Help with Tileentity/Register TileEntityType

[Luis_ST]

i just want to add to my custom block (lightning rod) a tile entity but i got an error and i know there is an error in registration but i dont know where

code: (code is frome the documentation

package net.luis.cave.init;

import ;

@Mod.EventBusSubscriber(modid = Cave.Mod_Id, bus = Mod.EventBusSubscriber.Bus.MOD)
public class CaveTileEntityType {
	
	public static final TileEntityType<LightningRodTileEntity> LIGHTNING_ROD = null;
	
	@SubscribeEvent
	public static void registerTE(RegistryEvent.Register<TileEntityType<?>> event) {
		
		TileEntityType<?> type = TileEntityType.Builder
				.create(LightningRodTileEntity::new, CaveBlocks.LIGHTNING_ROD.get())
				.build(null);
		type.setRegistryName(Cave.Mod_Id, "lightminig_rod_tileentity");
		event.getRegistry().register(type);
		
	}

}

 

and the error log:

net.minecraft.crash.ReportedException: Ticking block entity
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:888) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:820) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:84) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:663) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:233) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:832) [?:?] {}
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.tileentity.TileEntityType.isValidBlock(net.minecraft.block.Block)" because the return value of "net.minecraft.tileentity.TileEntity.getType()" is null
	at net.minecraft.world.World.tickBlockEntities(World.java:537) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.server.ServerWorld.tick(ServerWorld.java:374) ~[forge:?] {re:classloading}
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:884) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	... 5 more
[13:52:48] [Server thread/ERROR] [minecraft/Chunk]: A TileEntity type net.luis.cave.blocks.tileentity.LightningRodTileEntity has thrown an exception trying to write state. It will not persist, Report this to the mod author
java.lang.RuntimeException: class net.luis.cave.blocks.tileentity.LightningRodTileEntity is missing a mapping! This is a bug!
	at net.minecraft.tileentity.TileEntity.writeInternal(TileEntity.java:71) ~[forge:?] {re:classloading}
	at net.minecraft.tileentity.TileEntity.write(TileEntity.java:65) ~[forge:?] {re:classloading}
	at net.minecraft.world.chunk.Chunk.getTileEntityNBT(Chunk.java:438) ~[forge:?] {re:classloading}
	at net.minecraft.world.chunk.storage.ChunkSerializer.write(ChunkSerializer.java:287) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ChunkManager.chunkSave(ChunkManager.java:699) ~[forge:?] {re:classloading}
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:176) ~[?:?] {}
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) ~[?:?] {}
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) ~[?:?] {}
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?] {}
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?] {}
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?] {}
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?] {}
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?] {}
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] {}
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497) ~[?:?] {}
	at net.minecraft.world.server.ChunkManager.save(ChunkManager.java:354) ~[forge:?] {re:classloading}
	at net.minecraft.world.server.ServerChunkProvider.save(ServerChunkProvider.java:310) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.server.ServerWorld.save(ServerWorld.java:710) ~[forge:?] {re:classloading}
	at net.minecraft.server.MinecraftServer.save(MinecraftServer.java:544) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:583) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:186) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:700) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:233) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:832) [?:?] {}

 

and my tileentity class:

package net.luis.cave.blocks.tileentity;

import java.util.Random;

import ;

public class LightningRodTileEntity extends TileEntity implements ITickableTileEntity {
	
	Random rng = this.getWorld().rand;
	
	public LightningRodTileEntity() {
		
		super(CaveTileEntityType.LIGHTNING_ROD);
		
	}
	
	

	@Override
	public void tick() {
		
		LightningBoltEntity lightning = new LightningBoltEntity(EntityType.LIGHTNING_BOLT, this.getWorld());
		lightning.setLocationAndAngles(this.getPos().getX(), this.getPos().getY(), this.getPos().getZ(), rng.nextFloat() * 360, 0);
		
		if (this.getWorld().isThundering()) {
			
			if (this.getWorld().getGameTime() % (350 - rng.nextInt(200)) == 0) {
				
				this.getWorld().addEntity(lightning);
				
			}
			
		}
		
	}

}

 

[Luis_ST]

  On 1/29/2021 at 1:26 PM, diesieben07 said:

You never assign a value to LIGHTNING_ROD. When using registry events manually you need to use @ObjectHolder.

Expand  

what do you mean with "manually" is there another way to register TileEntitys

[Draco18s]

DeferredRegister is the other way.

[Luis_ST]

  On 1/29/2021 at 7:38 PM, Draco18s said:

DeferredRegister is the other way.

Expand  

I kown but DefferredRegister will not work/I got an error which i don't understand:

	public static final DeferredRegister<TileEntityType<?>> TILE_ENTITIES = DeferredRegister.create(ForgeRegistries.TILE_ENTITIES, Cave.Mod_Id);
	
	public static final RegistryObject<TileEntityType<LightningRodTileEntity>> LIGHTNING_ROD = TILE_ENTITIES.register("lightminig_rod_tileentity", 
			() -> new TileEntityType<>(LightningRodTileEntity::new, CaveBlocks.LIGHTNING_ROD.get(), null));

 

1. what should i add at "null"

2. when i add the Block which the TileEntity is vaild i got this error/ my ide say there is an error: "Cannot infer type arguments for TileEntityType<>"

[kiou.23]

  On 1/29/2021 at 8:01 PM, Luis_ST said:

I kown but DefferredRegister will not work/I got an error which i don't understand:

	public static final DeferredRegister<TileEntityType<?>> TILE_ENTITIES = DeferredRegister.create(ForgeRegistries.TILE_ENTITIES, Cave.Mod_Id);
	
	public static final RegistryObject<TileEntityType<LightningRodTileEntity>> LIGHTNING_ROD = TILE_ENTITIES.register("lightminig_rod_tileentity", 
			() -> new TileEntityType<>(LightningRodTileEntity::new, CaveBlocks.LIGHTNING_ROD.get(), null));

 

1. what should i add at "null"

2. when i add the Block which the TileEntity is vaild i got this error/ my ide say there is an error: "Cannot infer type arguments for TileEntityType<>"

Expand  

instead of a supplier, use the TileEntityType Builder

[loordgek]

		LightningBoltEntity lightning = new LightningBoltEntity(EntityType.LIGHTNING_BOLT, this.getWorld());
		lightning.setLocationAndAngles(this.getPos().getX(), this.getPos().getY(), this.getPos().getZ(), rng.nextFloat() * 360, 0);
		
		if (this.getWorld().isThundering()) {
			
			if (this.getWorld().getGameTime() % (350 - rng.nextInt(200)) == 0) {
				
				this.getWorld().addEntity(lightning);
				
			}
			
		}
		
	

you first create a new LightningBoltEntity and after that you check if you need to, dont do that

[Luis_ST]

  On 1/29/2021 at 9:02 PM, loordgek said:

you first create a new LightningBoltEntity and after that you check if you need to, dont do that

Expand  

thanks but i have already fixed this problem

 

  On 1/29/2021 at 8:34 PM, kiou.23 said:

instead of a supplier, use the TileEntityType Builder

Expand  

i tried a bit but i don't understand how replace the Supplier with TileEntityType Builder

[Beethoven92]

Have you tried looking whats inside the TileEntityType.Builder class? Then it will be very obvious which method you have to use to create you tile entity type

[Luis_ST]

  On 1/30/2021 at 2:17 PM, Beethoven92 said:

Then it will be very obvious which method you have to use to create you tile entity type

Expand  

it works thank you