Jump to content

Recommended Posts

Posted

Hello all modders and possibly, owners of forge! i have been messing around with code to figure out how to fix the issues related to block and item textures, and name registry being "tile.blockName.name" for every block after the 1.6.1 update! As i was modifying my code, i noticed that when the blocks and items are declared in the preInit section of the code rather than the usual place, the Init, textures actually show up! but when in Init, they don't! then i thought why don't i try this for LanguageRegistry as well? and sure enough, the names worked absolutely fine when moved from Init to preInit! If you have any suggestions or ideas about why this is happening, please share! And also, if you need any code, go right ahead and ask, and i will provide the related code! Thank you! :)

 

-sorash67 || Skorpio

  • Replies 93
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Posted

Sorry bub, I think its a coincidence.  I've got all my code in preInit right now and no dice.

 

Code for one block:

@EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	//System.out.println("Loadnig Redstone Mod");
    	Configuration config = new Configuration(event.getSuggestedConfigurationFile());
    	config.load();
    	//load configs
        fakeID = config.getBlock("FakeBlock", 2000).getInt();
    	config.save();
    	fakeBlock = new FakeBlock(fakeID);

    		System.out.println("Registering Fake Block");
    		GameRegistry.registerBlock(fakeBlock, "Illusionary Block");
    		LanguageRegistry.addName(fakeBlock, "Illusionary Block");
    		GameRegistry.addShapelessRecipe(new ItemStack(fakeBlock), painting, stone);
    		
    		int r = RenderingRegistry.getNextAvailableRenderId();
    		ISimpleBlockRenderingHandler handler = new RenderFakeBlock(r);
    		RenderingRegistry.registerBlockHandler(handler);
       		((FakeBlock)fakeBlock).renderType = r;
    		System.out.println(" - " + fakeBlock.getUnlocalizedName());
    		LanguageRegistry.instance().addStringLocalization("tile.Illusionary Block.name", "Illusionary Block");

 

2013_07_03_09_38_07.png

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

@PreInit
public void preInit(FMLPreInitializationEvent event){
	//Config file
	config = new Configuration(event.getSuggestedConfigurationFile());

	new MoreOresConfig();


	ingotOrange = new ItemGeneralIngot(MoreOresConfig.ingotOrangeID).setUnlocalizedName("ingotOrange").setCreativeTab(orangeTab);

LanguageRegistry.addName(ingotOrange, "Origum Ingot");
}

 

works perfectly fine! but when i move it over to

@Init
public void init(FMLInitializationEvent event){
}

bam, missing textures and name...

 

while in preInit:

uxkKM9m.png

 

and in init:

ZfbgCVB.png

 

what is going on???

 

-sorash67 || Skorpio

Posted

Wouldn't that seem like that means they need to be setup during the pre-init and be ready Before the init method or else they will not be loaded in time for the methods which depend on them to make use of them? :P

 

Sounds like a simple solution, load them in the place they should and all is fine? :)

If you guys dont get it.. then well ya.. try harder...

Posted

You are wrong it only fixes names not textures.

 

Then he must have changed more than he said between the screenshots then, since it shows the texture working in the first and not the second one?

If you guys dont get it.. then well ya.. try harder...

Posted

i tweeted LexManos himself, and he said this is the WRONG thing to do! and i know this too! but it works

 

Well that means there are far better ways to do this and that this way might break at a later build.

 

If you guys dont get it.. then well ya.. try harder...

Posted

I have learned to respect lex and I try to follow what he says, tough most is above my skill :P

Anyways it's so early in the development of this forge version and much is speculations instead of facts here on the boards. I guess one should go read the github commitments and code changes along with some re-reading of the src code to understand more.

 

Or one could wait for the dust to settle and use the time between to fix other stuff for the projects one is working on ;)

If you guys dont get it.. then well ya.. try harder...

Posted

Its also possible that I need to get a newer version of Forge, as I've got...756 right now (from early yesterday trying to puzzle this stuff out).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

your texture folder should now be:

assets/yourModName/textures/blocks|items/###.png

 

rather than:

mods/yourModName/textures/blocks|items/###.png

 

Doesn't fix the problem for me.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

Aspergers is annoying sometimes :(

Posted

that is odd! pm me and explain exactly what you did and how your files and the code look like and i will try to help you! :)

 

-sorash67 || Skorpio

Who is this directed to?

Aspergers is annoying sometimes :(

Posted

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

 

Replace all three with @EventHandler.  Leave everything else alone.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I'd suggest waiting then, if things don't work out. This is not a recommended release yet.

 

And about documentation, well you got javadocs and the commit log that's it I guess. That's not perfect but it's better than you can find many other places.

As a programmer you will need to learn not only to write documentation, but to study old code which has no such thing ;) Consider it a learning exercise or wait a week for the dust to settle ;)

If you guys dont get it.. then well ya.. try harder...

Posted

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

Replace all three with @EventHandler.  Leave everything else alone.

 

Just to make it more clear, with everything he means the parameter inputs as well, so don't change them either!

If you guys dont get it.. then well ya.. try harder...

Posted

All I did was move my block name registry to preint and then nothing my texture code is what the tutiral on the wiki says.

 

Which tutorial?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.