Jump to content

Textures and LanguageRegistry in preInit instead of Init


sorash67

Recommended Posts

Hello all modders and possibly, owners of forge! i have been messing around with code to figure out how to fix the issues related to block and item textures, and name registry being "tile.blockName.name" for every block after the 1.6.1 update! As i was modifying my code, i noticed that when the blocks and items are declared in the preInit section of the code rather than the usual place, the Init, textures actually show up! but when in Init, they don't! then i thought why don't i try this for LanguageRegistry as well? and sure enough, the names worked absolutely fine when moved from Init to preInit! If you have any suggestions or ideas about why this is happening, please share! And also, if you need any code, go right ahead and ask, and i will provide the related code! Thank you! :)

 

-sorash67 || Skorpio

Link to comment
Share on other sites

  • Replies 93
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Sorry bub, I think its a coincidence.  I've got all my code in preInit right now and no dice.

 

Code for one block:

@EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	//System.out.println("Loadnig Redstone Mod");
    	Configuration config = new Configuration(event.getSuggestedConfigurationFile());
    	config.load();
    	//load configs
        fakeID = config.getBlock("FakeBlock", 2000).getInt();
    	config.save();
    	fakeBlock = new FakeBlock(fakeID);

    		System.out.println("Registering Fake Block");
    		GameRegistry.registerBlock(fakeBlock, "Illusionary Block");
    		LanguageRegistry.addName(fakeBlock, "Illusionary Block");
    		GameRegistry.addShapelessRecipe(new ItemStack(fakeBlock), painting, stone);
    		
    		int r = RenderingRegistry.getNextAvailableRenderId();
    		ISimpleBlockRenderingHandler handler = new RenderFakeBlock(r);
    		RenderingRegistry.registerBlockHandler(handler);
       		((FakeBlock)fakeBlock).renderType = r;
    		System.out.println(" - " + fakeBlock.getUnlocalizedName());
    		LanguageRegistry.instance().addStringLocalization("tile.Illusionary Block.name", "Illusionary Block");

 

2013_07_03_09_38_07.png

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@PreInit
public void preInit(FMLPreInitializationEvent event){
	//Config file
	config = new Configuration(event.getSuggestedConfigurationFile());

	new MoreOresConfig();


	ingotOrange = new ItemGeneralIngot(MoreOresConfig.ingotOrangeID).setUnlocalizedName("ingotOrange").setCreativeTab(orangeTab);

LanguageRegistry.addName(ingotOrange, "Origum Ingot");
}

 

works perfectly fine! but when i move it over to

@Init
public void init(FMLInitializationEvent event){
}

bam, missing textures and name...

 

while in preInit:

uxkKM9m.png

 

and in init:

ZfbgCVB.png

 

what is going on???

 

-sorash67 || Skorpio

Link to comment
Share on other sites

Wouldn't that seem like that means they need to be setup during the pre-init and be ready Before the init method or else they will not be loaded in time for the methods which depend on them to make use of them? :P

 

Sounds like a simple solution, load them in the place they should and all is fine? :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

that's EXACTLY what i thought! xD the thing is, i tweeted LexManos himself, and he said this is the WRONG thing to do! and i know this too! but it works, and there doesn't seem to be any other solution! so i guess i'll go with it...

 

-sorash67 || Skorpio

Link to comment
Share on other sites

You are wrong it only fixes names not textures.

 

Then he must have changed more than he said between the screenshots then, since it shows the texture working in the first and not the second one?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

i tweeted LexManos himself, and he said this is the WRONG thing to do! and i know this too! but it works

 

Well that means there are far better ways to do this and that this way might break at a later build.

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I have learned to respect lex and I try to follow what he says, tough most is above my skill :P

Anyways it's so early in the development of this forge version and much is speculations instead of facts here on the boards. I guess one should go read the github commitments and code changes along with some re-reading of the src code to understand more.

 

Or one could wait for the dust to settle and use the time between to fix other stuff for the projects one is working on ;)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Its also possible that I need to get a newer version of Forge, as I've got...756 right now (from early yesterday trying to puzzle this stuff out).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

your texture folder should now be:

assets/yourModName/textures/blocks|items/###.png

 

rather than:

mods/yourModName/textures/blocks|items/###.png

 

Doesn't fix the problem for me.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

Aspergers is annoying sometimes :(

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

 

(Resolved - I was not using FMLPreInitializationEvent)

Edit2: @PreInit makes my item non-existant?

Edit3:

2013-07-03 16:44:14 [sEVERE] [DrewLemmy_DontStarveMod] The mod DrewLemmy_DontStarveMod appears to have an invalid method annotation PreInit. This annotation can only apply to methods with argument types [class cpw.mods.fml.common.event.FMLPreInitializationEvent] -it will not be called

 

 

Replace all three with @EventHandler.  Leave everything else alone.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I'd suggest waiting then, if things don't work out. This is not a recommended release yet.

 

And about documentation, well you got javadocs and the commit log that's it I guess. That's not perfect but it's better than you can find many other places.

As a programmer you will need to learn not only to write documentation, but to study old code which has no such thing ;) Consider it a learning exercise or wait a week for the dust to settle ;)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

The lack of documentation on this is a shame. Hopefully someone will get round to doing it.

Edit: @PreInit and @Init are now deprecated. Not sure what to do now.

 

Replace all three with @EventHandler.  Leave everything else alone.

 

Just to make it more clear, with everything he means the parameter inputs as well, so don't change them either!

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

All I did was move my block name registry to preint and then nothing my texture code is what the tutiral on the wiki says.

 

Which tutorial?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.