Event "setSecondsOnFire" won't connect to SwordItem

[Skullblade]

I've been stuck on this for three days now, and I can't find any answer online that makes sense. I'm creating a sword that, among other things, sets mobs and players on fire upon damage. I wrote the following code, and it doesn't seem to apply to the sword.

@SubscribeEvent

public static void setOnFire(final LivingDamageEvent event)

{

if (event.getSource().equals(ItemInit.EMBERCLEAVE))

{

event.getEntity().setSecondsOnFire(10);

}

}

"EMBERCLEAVE" is what the sword is registered as. I have tried removing the setSecondsOnFire code from the If statement and having it run regardless, and it works (it just means that any source of damage sets things on fire for 10 seconds, including its own fire ticks, leading to infinite seconds on fire).

When hovering above equals, my IDE says "'equals' between objects of inconvertible types 'DamageSource' and 'RegistryObject<SwordItem>'." I'm guessing that this is the issue, and the event can't figure out how to convert the values, but I don't know how to fix this issue.

 

Edited May 5, 2021 by Skullblade

[poopoodice]

I don't think ItemInit.EMBERCLEAVE is a type of DamageSource.

You should be checking if the item of the attacker is holding is the sword (DamageSource#getTrueSource gives you the entity).

However this can be abused in multiple ways, such as swap to the sword as soon as the shot arrow hits the target, or even a thrown splash poison potion will be able to burn the target to death.

Try AttackEntityEvent instead.

[Skullblade]

I took a swing at both solutions, but it wasn't working for me. Could you give me an example of how you would implement those suggestions?

[Luis_ST]

1 hour ago, Skullblade said:

I took a swing at both solutions, but it wasn't working for me.

show what you create

 

1 hour ago, Skullblade said:

Could you give me an example of how you would implement those suggestions?

and this is basic java, not really complicated
you have already used an event so change the event to AttackEntityEvent
and use this to get the DamagSource as an entity (you should then test whether the entity is a LivingEntity)

Entity entity = event.getSource().getTrueSource();

and then

10 hours ago, poopoodice said:

You should be checking if the item of the attacker is holding is the sword

 

[Skullblade]

I don't understand where to put or how to use DamageSource.

I tried replacing LivingDamageEvent with AttackEntityEvent, but it still gives me the warning about ItemInit.EMBERCLEAVE is inconvertible to Entity.

[Draco18s]

23 minutes ago, Skullblade said:

where to put or how to use DamageSource

23 minutes ago, Skullblade said:

ItemInit.EMBERCLEAVE is inconvertible

 

I WONDER IF THESE THINGS ARE RELATED

[Skullblade]

I would like help, not to get yelled at.

[MonkeyKnight]

I know this might be stupid but for deferedRegisters, that error normally goes away when you put .get() at the end. Something like this:

if (event.getSource().equals(ItemInit.EMBERCLEAVE.get()))

I have only coded blocks and potions in 1.16 so I am a little rusty on items but this might work.

[poopoodice]

Unfortunately no, you can't ever compare a DamageSource to an Item.

In fact instead of using an event, if it's your own item you can just override onLeftClickEntity (or named something similar, where is called on the item after AttackEntityEvent) and set the target on fire there.

Edited May 5, 2021 by poopoodice

[eggpasta]

12 minutes ago, Skullblade said:

I would like help, not to get yelled at.

What MonkeyKnight just said will work just fine, because the items in ItemInit are stored as RegistryObjects you have to use .get() to get the actual item

[Skullblade]

I tried MonkeyKnight's suggestion, but I think what PooPooDice said also applies. I can't compare Embercleave to DamageSource. So when I tried it, it didn't work. I'll keep that one in my pocket though, thanks

Could I get a more in depth explanation about onLeftClickEntity? Like, what class does it go in? Do I use @Override?

Lastly, thank you everyone for helping me this far. It means a lot, as I'm new at this, and I didn't want this to be another of my abandoned projects.

 

[MonkeyKnight]

The only further suggestion I would have is to check Minecraft's code for the fire aspect enchantment. You may find what you are looking for there.

[eggpasta]

38 minutes ago, Skullblade said:

I tried MonkeyKnight's suggestion, but I think what PooPooDice said also applies. I can't compare Embercleave to DamageSource. So when I tried it, it didn't work. I'll keep that one in my pocket though, thanks

Could I get a more in depth explanation about onLeftClickEntity? Like, what class does it go in? Do I use @Override?

Lastly, thank you everyone for helping me this far. It means a lot, as I'm new at this, and I didn't want this to be another of my abandoned projects.

 

If you are using SwordItem it has a method

public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {

which you could override but make sure to add the lines of code that were previously there as well as your extra code

 p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
 });

 

[poopoodice]

In the Item class, (Item#hitEntity seems to be better than IForgeItem#onLeftClickEntity)

@Override is just an annotation that is not necessary, but highly recommended to make sure you are actually overriding the method.

DamageSource is a class that contains the information of the attack, such as the type of the attack (fire? explosion? where blast protection checks for this), the attacker, and even the direct attacker like arrows (IndirectDamageSource). Therefore the DamageSource will never match to a single item, where you can only obtain the information of the weapon from the attacker stored.

[Skullblade]

This is getting confusing. What do I put where?

If I need to show my classes I can.

[poopoodice]

Override hitEntity() in your item class and set target on fire there.

[eggpasta]

8 hours ago, Skullblade said:

This is getting confusing. What do I put where?

If I need to show my classes I can.

In your item class override the hitEntity()(might be called something else depending on your version) method 

If you don't understand share your item class and i will show you 

[Skullblade]

8 hours ago, eggpasta said:

In your item class override the hitEntity()(might be called something else depending on your version) method 

If you don't understand share your item class and i will show you 

Okay, so the tutorial I was watching wasn't super clear which one was my item class, so here's the four main ones I have been working with.

ItemInit.java:

package com.skullblade.planeswalkermod.core.init;

 

import com.skullblade.planeswalkermod.ModItemTier;

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import net.minecraft.item.Item;

import net.minecraft.item.ItemGroup;

import net.minecraft.item.SwordItem;

import net.minecraftforge.fml.RegistryObject;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

public class ItemInit

{

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

}

 

PlaneswalkerMod.java:

package com.skullblade.planeswalkermod;

 

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraft.item.Item;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.eventbus.api.IEventBus;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;

import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

import org.apache.logging.log4j.LogManager;

import org.apache.logging.log4j.Logger;

@Mod("planeswalker")

public class PlaneswalkerMod

{

public static final Logger LOGGER = LogManager.getLogger();

public static final String MOD_ID = "planeswalker";

public PlaneswalkerMod()

{

IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();

bus.addListener(this::setup);

ItemInit.ITEMS.register(bus);

MinecraftForge.EVENT_BUS.register(this);

}

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

private void setup(final FMLCommonSetupEvent event)

{

}

}

 

EventHandler.java:

package com.skullblade.planeswalkermod.core.event;

 

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraftforge.event.entity.player.AttackEntityEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = PlaneswalkerMod.MOD_ID, bus = Bus.FORGE)

public class EventHandler

{

@SubscribeEvent public static void setOnFire(final AttackEntityEvent event)

{

if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10);

}

}

}

 

ModItemTier.java:

package com.skullblade.planeswalkermod;

 

import mcp.MethodsReturnNonnullByDefault;

import net.minecraft.item.IItemTier;

import net.minecraft.item.Items;

import net.minecraft.item.crafting.Ingredient;

import java.util.function.Supplier;

@MethodsReturnNonnullByDefault

public enum ModItemTier implements IItemTier

{

EMBERCLEAVE(1, 1000, 4.0f, 3.0f, 5, () -> Ingredient.of(Items.IRON_INGOT));

private final Supplier<Ingredient> repairmaterial;

private final int enchantability;

private final float attackDamage;

private final float efficiency;

private final int maxUses;

private final int harvestLevel;

ModItemTier(int harvestLevel, int maxUses, float efficiency, float attackDamage, int enchantability, Supplier<Ingredient> repairmaterial)

{

this.harvestLevel = harvestLevel;

this.maxUses = maxUses;

this.efficiency = efficiency;

this.attackDamage = attackDamage;

this.enchantability = enchantability;

this.repairmaterial = repairmaterial;

}

@Override public int getUses() { return 1000; }

@Override public float getSpeed() { return 1.2f; }

@Override public float getAttackDamageBonus() { return 14; }

@Override public int getLevel() { return 1; }

@Override public int getEnchantmentValue() { return 5; }

@Override public Ingredient getRepairIngredient() { return Ingredient.of(Items.IRON_INGOT); } }

 

Edited May 6, 2021 by Skullblade

[eggpasta]

21 minutes ago, Skullblade said:

Okay, so the tutorial I was watching wasn't super clear which one was my item class, so here's the four main ones I have been working with.

ItemInit.java:

package com.skullblade.planeswalkermod.core.init;

 

import com.skullblade.planeswalkermod.ModItemTier;

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import net.minecraft.item.Item;

import net.minecraft.item.ItemGroup;

import net.minecraft.item.SwordItem;

import net.minecraftforge.fml.RegistryObject;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

public class ItemInit

{

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

}

 

PlaneswalkerMod.java:

package com.skullblade.planeswalkermod;

 

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraft.item.Item;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.eventbus.api.IEventBus;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;

import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

import org.apache.logging.log4j.LogManager;

import org.apache.logging.log4j.Logger;

@Mod("planeswalker")

public class PlaneswalkerMod

{

public static final Logger LOGGER = LogManager.getLogger();

public static final String MOD_ID = "planeswalker";

public PlaneswalkerMod()

{

IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();

bus.addListener(this::setup);

ItemInit.ITEMS.register(bus);

MinecraftForge.EVENT_BUS.register(this);

}

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

private void setup(final FMLCommonSetupEvent event)

{

}

}

 

EventHandler.java:

package com.skullblade.planeswalkermod.core.event;

 

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraftforge.event.entity.player.AttackEntityEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = PlaneswalkerMod.MOD_ID, bus = Bus.FORGE)

public class EventHandler

{

@SubscribeEvent public static void setOnFire(final AttackEntityEvent event)

{

if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10);

}

}

}

 

ModItemTier.java:

package com.skullblade.planeswalkermod;

 

import mcp.MethodsReturnNonnullByDefault;

import net.minecraft.item.IItemTier;

import net.minecraft.item.Items;

import net.minecraft.item.crafting.Ingredient;

import java.util.function.Supplier;

@MethodsReturnNonnullByDefault

public enum ModItemTier implements IItemTier

{

EMBERCLEAVE(1, 1000, 4.0f, 3.0f, 5, () -> Ingredient.of(Items.IRON_INGOT));

private final Supplier<Ingredient> repairmaterial;

private final int enchantability;

private final float attackDamage;

private final float efficiency;

private final int maxUses;

private final int harvestLevel;

ModItemTier(int harvestLevel, int maxUses, float efficiency, float attackDamage, int enchantability, Supplier<Ingredient> repairmaterial)

{

this.harvestLevel = harvestLevel;

this.maxUses = maxUses;

this.efficiency = efficiency;

this.attackDamage = attackDamage;

this.enchantability = enchantability;

this.repairmaterial = repairmaterial;

}

@Override public int getUses() { return 1000; }

@Override public float getSpeed() { return 1.2f; }

@Override public float getAttackDamageBonus() { return 14; }

@Override public int getLevel() { return 1; }

@Override public int getEnchantmentValue() { return 5; }

@Override public Ingredient getRepairIngredient() { return Ingredient.of(Items.IRON_INGOT); } }

 

Oh ok you don't have an item class so you will need to make one,

So create a new class called FlamingSword

inside it put 

public class FlamingSword extends SwordItem{

	public FlamingSword() {
		super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));
		// TODO Auto-generated constructor stub
	}
	@Override
	  public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {
	      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
	         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
	         //Put your fire method here on p_77644_3
	      });
	      return true;
	   }

}

and then in ItemInit replace

 new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

with

 FlamingSword::new);

and then it should work

Edited May 6, 2021 by eggpasta
fix code

[Skullblade]

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

[eggpasta]

9 minutes ago, Skullblade said:

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

Remove this just make it

p_77644_3_.setSecondsOnFire(10);

 

so that the method look like this:

	@Override
	  public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {
	      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
	         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
	         p_77644_3_.setSecondsOnFire(10)
	      });
	      return true;
	   }

As the checking has already been done

What other errors are you getting?

[Draco18s]

17 minutes ago, Skullblade said:

p_77644_3_.if(

This isn't valid Java.

Also name your locals with nice names so you know what they are. You don't have to use the obfuscated decompiled names.

20 minutes ago, Skullblade said:

super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)",

Yes, because:

20 minutes ago, Skullblade said:

public class FlamingSword {

Your FlamingSword is not a subclass of anything.

[eggpasta]

23 minutes ago, Skullblade said:

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

As @Draco18s was saying, your FlamingSword class needs to extend SwordItem

[Skullblade]

Ok, that got rid of some errors. super is fine now, along with some clearer labels. public class FlamingSword now extends SwordItem (I forgot to do that part, sorry eggpasta). I'm still having an issue with p_220045_0_. It says it can't resolve it. Also, I'm not exactly sure where to put my code, and what changes to make. (I'm more of a visual learner, so an example like the last one would be sweet.) Lastly, ItemInit is saying the following about "() -> FlamingSword::new);"

Required type:
RegistryObject
<SwordItem>
Provided:
RegistryObject
<I>
I is not a functional interface

[eggpasta]

1 minute ago, Skullblade said:

Ok, that got rid of some errors. super is fine now, along with some clearer labels. public class FlamingSword now extends SwordItem (I forgot to do that part, sorry eggpasta). I'm still having an issue with p_220045_0_. It says it can't resolve it. Also, I'm not exactly sure where to put my code, and what changes to make. (I'm more of a visual learner, so an example like the last one would be sweet.) Lastly, ItemInit is saying the following about "() -> FlamingSword::new);"

Required type:
RegistryObject
<SwordItem>
Provided:
RegistryObject
<I>
I is not a functional interface

For the iteminit error get rid of

() ->

so it's just

FlamingSword::new

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos