Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12] Item texture not working

Corgam

By Corgam
in Modder Support

 Share

Recommended Posts

MrBendelScrolls Creeper Killer

MrBendelScrolls

Posted
Posted
1 minute ago, Animefan8888 said:

I don't believe the crash will happen in a development environment possibly because the classes marked with @SIdeOnly(Side.CLIENT) still get compiled though that may just be me thinking wildly.

Neither inside IDE, nor outside. Never.

Jacky2611 Diamond Finder

Jacky2611

Posted
Posted (edited)

 

What exactly did you try to do? When I run the dedicated server and move some of the stuff from my client proxy to my common proxy I get something like this:

  

java.io.FileNotFoundException: minecraft.jar (Das System kann die angegebene Datei nicht finden)
	at java.util.zip.ZipFile.open(Native Method) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at net.minecraftforge.fml.server.FMLServerHandler.addModAsResource(FMLServerHandler.java:256) [FMLServerHandler.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.addModToResourcePack(FMLCommonHandler.java:542) [FMLCommonHandler.class:?]
	at net.minecraftforge.fml.common.LoadController.buildModList(LoadController.java:129) [LoadController.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) [guava-21.0.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) [guava-21.0.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) [guava-21.0.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) [guava-21.0.jar:?]
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:337) [LoadController.class:?]
	at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:546) [Loader.class:?]
	at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:97) [FMLServerHandler.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:335) [FMLCommonHandler.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:125) [DedicatedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:549) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_92]

 

 

Are you sure that you ran the server configuration? Cause it should crash...

Edited by Jacky2611

Here could be your advertisement!

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
2 minutes ago, winnetrie said:

I don't think this is entirely true. If i understand the manual correctly.

forge manual

It when you are using the @Mod.EventBusSubscriber which I believe is required for the RegistryEvents.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Choonster Reality Controller

Choonster

Posted
Posted
Just now, Animefan8888 said:

It when you are using the @Mod.EventBusSubscriber which I believe is required for the RegistryEvents.

 

It's not required, but it's easier than manually registering the event handler.

 

In 1.12, registry events are fired between preInit and init rather than before preInit as they were in 1.10.2-1.11.2.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
1 minute ago, Choonster said:

In 1.12, registry events are fired between preInit and init rather than before preInit as they were in 1.10.2-1.11.2.

Ahhh, thanks. I knew there was a reason behind me believing that.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)

Probably because ModelLoader itself (while in a client package) isn't marked SideOnly, but its parent class is.

This means the JVM can find ModelLoader and the server is fine. 

But! There's no guarantee that that won't change suddenly and unexpectedly in the future. 

You're safest assuming that client stuff only happens on the client than saying "works for me." Because at some point, it suddenly won't, and you won't know why.

Edited by Draco18s
  • Like 2

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Jacky2611 Diamond Finder

Jacky2611

Posted
Posted

@Draco18s Are you talking about registering the rendering stuff on the server side? Cause I tried that a few minutes ago and my minecraft DID crash. Not sure why it worked for MrBendelScrolls.

Here could be your advertisement!

Draco18s Reality Controller

Draco18s

Posted
Posted

If you ACTUALLY register models on the server it will crash, yes. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted

Dunno then. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Corgam Tree Puncher

Corgam

Posted
  • Author
Posted

Ok, thanks to your help I made this: 

 

_Items class:

Spoiler

package corgam.slavicraft.items;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class _Items {
    
    public static Item blank_rune;
    public static Item rune_eho;

    public static void preInit(){  //Initialized in CommonProxy
        
        
        blank_rune = new ItemBlankRune("blank_rune");
        rune_eho = new ItemBlankRune("rune_eho");
    
    }    

    @EventBusSubscriber    
    public static class RegisterAndModelHandler {
        
        @SubscribeEvent
        public static void registerItems(RegistryEvent.Register<Item> event) {
            
            final Item[] Items = {
                    blank_rune,
                    rune_eho
            };
            
            for (Item x : Items){
                event.getRegistry().register(x);
            };
            
            
        }
        
        @SideOnly(Side.CLIENT)
        @SubscribeEvent
        public static void registerRenders(ModelRegistryEvent event){
            
            final Item[] Items = {
                    blank_rune,
                    rune_eho
            };
            for (Item x : Items){
                ModelLoader.setCustomModelResourceLocation(x, 0, new ModelResourceLocation(x.getRegistryName(), "inventory"));
            };
        }
            
        
    }    
        
}
        

And my question is if I can get it working with only one Array?

And it will be also ideal to only leave array in this class and the rest of the code for register and models in other classes, but I don't know exactly how :v

Jacky2611 Diamond Finder

Jacky2611

Posted
Posted

move the array to the top of your class? And if your BlankRunes parent class is a custom one you could add somthing like this to its constructor: _Items.items.add(this); To avoid filing the list by hand.

And read the java coding conventions.   Variables are lowerCamelCase or UPPERCASE.

Here could be your advertisement!

Corgam Tree Puncher

Corgam

Posted
  • Author
Posted (edited)

I tried this before:

Spoiler

package corgam.slavicraft.items;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class _Items {
    
    public static Item BLANK_RUNE;
    public static Item RUNE_EHO;
    
    final static Item[] Items = {
            BLANK_RUNE,
            RUNE_EHO
    };

    public static void preInit(){  //Initialized in CommonProxy
        
        
        BLANK_RUNE = new ItemBlankRune("blank_rune");
        RUNE_EHO = new ItemBlankRune("rune_eho");
    
    }    

    @EventBusSubscriber    
    public static class RegisterAndModelHandler {
        
        @SubscribeEvent
        public static void registerItems(RegistryEvent.Register<Item> event) {
                
            for (Item x : Items){
                event.getRegistry().register(x);
            };
            
            
        }
        
        @SideOnly(Side.CLIENT)
        @SubscribeEvent
        public static void registerRenders(ModelRegistryEvent event){
            
            for (Item x : Items){
                ModelLoader.setCustomModelResourceLocation(x, 0, new ModelResourceLocation(x.getRegistryName(), "inventory"));
            };
        }
            
        
    }    
        
}
        

But the game crashes with error: java.lang.NullPointerException: Can't use a null-name for the registry, object null.

 

Edit1: Solved! I used set instead of array (public static final Set<Item> ITEMS = new HashSet<>(); ) and than in my mod items parent class I added RegisterHandler.ITEMS.add(this); and everything works as I wanted

Edited by Corgam

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept