1 minute ago, Animefan8888 said:

I don't believe the crash will happen in a development environment possibly because the classes marked with @SIdeOnly(Side.CLIENT) still get compiled though that may just be me thinking wildly.

Neither inside IDE, nor outside. Never.

 

What exactly did you try to do? When I run the dedicated server and move some of the stuff from my client proxy to my common proxy I get something like this:

 

java.io.FileNotFoundException: minecraft.jar (Das System kann die angegebene Datei nicht finden)
	at java.util.zip.ZipFile.open(Native Method) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at java.util.zip.ZipFile.<init>(Unknown Source) ~[?:1.8.0_92]
	at net.minecraftforge.fml.server.FMLServerHandler.addModAsResource(FMLServerHandler.java:256) [FMLServerHandler.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.addModToResourcePack(FMLCommonHandler.java:542) [FMLCommonHandler.class:?]
	at net.minecraftforge.fml.common.LoadController.buildModList(LoadController.java:129) [LoadController.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) [guava-21.0.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) [guava-21.0.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) [guava-21.0.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) [guava-21.0.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) [guava-21.0.jar:?]
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:337) [LoadController.class:?]
	at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:546) [Loader.class:?]
	at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:97) [FMLServerHandler.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:335) [FMLCommonHandler.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:125) [DedicatedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:549) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_92]

 

 

Are you sure that you ran the server configuration? Cause it should crash...

Edited July 18, 20178 yr by Jacky2611

3 hours ago, MrBendelScrolls said:

1. Register methods must be static.

I don't think this is entirely true. If i understand the manual correctly.

forge manual

2 minutes ago, winnetrie said:

I don't think this is entirely true. If i understand the manual correctly.

forge manual

It when you are using the @Mod.EventBusSubscriber which I believe is required for the RegistryEvents.

Just now, Animefan8888 said:

It when you are using the @Mod.EventBusSubscriber which I believe is required for the RegistryEvents.

 

It's not required, but it's easier than manually registering the event handler.

 

In 1.12, registry events are fired between preInit and init rather than before preInit as they were in 1.10.2-1.11.2.

1 minute ago, Choonster said:

In 1.12, registry events are fired between preInit and init rather than before preInit as they were in 1.10.2-1.11.2.

Ahhh, thanks. I knew there was a reason behind me believing that.

Probably because ModelLoader itself (while in a client package) isn't marked SideOnly, but its parent class is.

This means the JVM can find ModelLoader and the server is fine. 

But! There's no guarantee that that won't change suddenly and unexpectedly in the future. 

You're safest assuming that client stuff only happens on the client than saying "works for me." Because at some point, it suddenly won't, and you won't know why.

Edited July 18, 20178 yr by Draco18s

@Draco18s Are you talking about registering the rendering stuff on the server side? Cause I tried that a few minutes ago and my minecraft DID crash. Not sure why it worked for MrBendelScrolls.

If you ACTUALLY register models on the server it will crash, yes. 

Only moved the function over, renamed it and removed the Event annotation. Shouldn't have been executed.

Dunno then. 

Ok, thanks to your help I made this: 

 

_Items class:

Spoiler

package corgam.slavicraft.items;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class _Items {
    
    public static Item blank_rune;
    public static Item rune_eho;

    public static void preInit(){  //Initialized in CommonProxy
        
        
        blank_rune = new ItemBlankRune("blank_rune");
        rune_eho = new ItemBlankRune("rune_eho");
    
    }    

    @EventBusSubscriber    
    public static class RegisterAndModelHandler {
        
        @SubscribeEvent
        public static void registerItems(RegistryEvent.Register<Item> event) {
            
            final Item[] Items = {
                    blank_rune,
                    rune_eho
            };
            
            for (Item x : Items){
                event.getRegistry().register(x);
            };
            
            
        }
        
        @SideOnly(Side.CLIENT)
        @SubscribeEvent
        public static void registerRenders(ModelRegistryEvent event){
            
            final Item[] Items = {
                    blank_rune,
                    rune_eho
            };
            for (Item x : Items){
                ModelLoader.setCustomModelResourceLocation(x, 0, new ModelResourceLocation(x.getRegistryName(), "inventory"));
            };
        }
            
        
    }    
        
}
        

And my question is if I can get it working with only one Array?

And it will be also ideal to only leave array in this class and the rest of the code for register and models in other classes, but I don't know exactly how :v

move the array to the top of your class? And if your BlankRunes parent class is a custom one you could add somthing like this to its constructor: _Items.items.add(this); To avoid filing the list by hand.

And read the java coding conventions.   Variables are lowerCamelCase or UPPERCASE.

I tried this before:

Spoiler

package corgam.slavicraft.items;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class _Items {
    
    public static Item BLANK_RUNE;
    public static Item RUNE_EHO;
    
    final static Item[] Items = {
            BLANK_RUNE,
            RUNE_EHO
    };

    public static void preInit(){  //Initialized in CommonProxy
        
        
        BLANK_RUNE = new ItemBlankRune("blank_rune");
        RUNE_EHO = new ItemBlankRune("rune_eho");
    
    }    

    @EventBusSubscriber    
    public static class RegisterAndModelHandler {
        
        @SubscribeEvent
        public static void registerItems(RegistryEvent.Register<Item> event) {
                
            for (Item x : Items){
                event.getRegistry().register(x);
            };
            
            
        }
        
        @SideOnly(Side.CLIENT)
        @SubscribeEvent
        public static void registerRenders(ModelRegistryEvent event){
            
            for (Item x : Items){
                ModelLoader.setCustomModelResourceLocation(x, 0, new ModelResourceLocation(x.getRegistryName(), "inventory"));
            };
        }
            
        
    }    
        
}
        

But the game crashes with error: java.lang.NullPointerException: Can't use a null-name for the registry, object null.

 

Edit1: Solved! I used set instead of array (public static final Set<Item> ITEMS = new HashSet<>(); ) and than in my mod items parent class I added RegisterHandler.ITEMS.add(this); and everything works as I wanted

Edited July 22, 20178 yr by Corgam