Jump to content

Recommended Posts

Posted

So what I would like to do is make it so when you touch a block (click on it)

then the block will say something like "what are you doing!" or "hello"

in the chat

but I seem to be getting stuck at the printing it to the chat.

I looked around and I found

    protected Minecraft minecraft;

@Override
    public boolean onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult result) {
        if (!world.isRemote) {
            TileEntity tileEntity = world.getTileEntity(pos);
            if (tileEntity instanceof INamedContainerProvider) {
                NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos());
            } else {
                throw new IllegalStateException("Our named container provider is missing!");
            }
            return true;
        }

      //THIS SENDS THE MESSAGE
        this.minecraft.player.sendChatMessage("hello I am a COMPUTER");
      //THAT SENDS THE MESSAGE

        return super.onBlockActivated(state, world, pos, player, hand, result);
    }

But that does not work, instead, the game crashes.

Posted

@diesieben07

thanks, now I am doing

player.sendMessage(new TranslationTextComponent("computerTalk.hello"));

but it now prints it twice and throughs an error:

[16:40:24.467] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.IllegalStateException: Our named container provider is missing!
	at com.runningmanstudios.harrysmod.blocks.Computer.onBlockActivated(Computer.java:62) ~[?:?] {}
	at net.minecraft.block.BlockState.onBlockActivated(BlockState.java:296) ~[?:?] {}
	at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:366) ~[?:?] {}
	at net.minecraft.network.play.ServerPlayNetHandler.processTryUseItemOnBlock(ServerPlayNetHandler.java:896) ~[?:?] {}
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:42) ~[?:?] {}
	at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:12) ~[?:?] {}
	at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:14) ~[?:?] {}
	at net.minecraft.util.concurrent.TickDelayedTask.run(TickDelayedTask.java:20) ~[?:?] {}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.run(ThreadTaskExecutor.java:131) [?:?] {pl:accesstransformer:B}
	at net.minecraft.util.concurrent.RecursiveEventLoop.run(RecursiveEventLoop.java:22) [?:?] {}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.driveOne(ThreadTaskExecutor.java:106) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:713) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.driveOne(MinecraftServer.java:707) [?:?] {pl:accesstransformer:B}
	at net.minecraft.util.concurrent.ThreadTaskExecutor.drainTasks(ThreadTaskExecutor.java:93) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.runScheduledTasks(MinecraftServer.java:692) [?:?] {pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:637) [?:?] {pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_221] {}

 

Posted

@diesieben07

that is correct but my excuse is that I am new to this whole modding thing and there was only one tutorial I could find on youtube.

but...

I did make it work, and although it is probably inefficient it does work.

 

so what I found was that when clicking the block it would run the method twice(before you ask I couldn't find a reason) so I coded it to only say something every other time the method is run.

    
    protected int conversation = 1;
    protected boolean isTalking = false;
    protected boolean canTalk = true;

@Override
    public boolean onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult result) {
        if (canTalk) {
            isTalking = true;
            canTalk = false;
        } else {
            canTalk = true;
        }

        if (isTalking) {
            if (conversation == 1) {
                player.sendMessage(new TranslationTextComponent("computerTalk.hello"));
                isTalking = false;
                conversation++;
            } else if (conversation == 2) {
                player.sendMessage(new TranslationTextComponent("computerTalk.whatdoyouneed"));
                isTalking = false;
                conversation++;
            } else if (conversation == 3) {
                player.sendMessage(new TranslationTextComponent("computerTalk.goodbye"));
                isTalking = false;
                conversation = 1;
            }
        }

        return true;
    }

witch works perfectly.

Posted
31 minutes ago, MrNoodles75 said:

@diesieben07

that is correct but my excuse is that I am new to this whole modding thing and there was only one tutorial I could find on youtube.

but...

I did make it work, and although it is probably inefficient it does work.

 

so what I found was that when clicking the block it would run the method twice(before you ask I couldn't find a reason) so I coded it to only say something every other time the method is run.


    
    protected int conversation = 1;
    protected boolean isTalking = false;
    protected boolean canTalk = true;

@Override
    public boolean onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult result) {
        if (canTalk) {
            isTalking = true;
            canTalk = false;
        } else {
            canTalk = true;
        }

        if (isTalking) {
            if (conversation == 1) {
                player.sendMessage(new TranslationTextComponent("computerTalk.hello"));
                isTalking = false;
                conversation++;
            } else if (conversation == 2) {
                player.sendMessage(new TranslationTextComponent("computerTalk.whatdoyouneed"));
                isTalking = false;
                conversation++;
            } else if (conversation == 3) {
                player.sendMessage(new TranslationTextComponent("computerTalk.goodbye"));
                isTalking = false;
                conversation = 1;
            }
        }

        return true;
    }

witch works perfectly.

I think if you put this in your block class, every instance of this block will share the same values.

Posted

Judging from your package naming you are following a HarryTalks tutorial, throw the whole thing out and start with a tutorial that's not garbage

  • Like 1

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Posted (edited)
40 minutes ago, MrNoodles75 said:

well it does

 

No, it does not.

Your block will break once there are multiple instance of your blocks in your world, as all of them use the same value stored in a singleton of your block.

Use TileEntity instead.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Posted
3 hours ago, MrNoodles75 said:

@DaemonUmbra

I actually followed Jorrit Tyberghein

Not the worst stuff I've seen, but I didn't watch all of it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.