Override Vanilla Blocks class

[CaptainDoge]

What is the best method for overriding a vanilla blocks class? Is there a way to modify a vanilla class to add or change functionality?

[TheThorneCorporation]

  On 5/24/2020 at 2:09 AM, CaptainDoge said:

What is the best method for overriding a vanilla blocks class? Is there a way to modify a vanilla class to add or change functionality?

Expand  

Overriding a vanilla block class...? Most vanilla blocks are instances of Block, and those with special functionality use a subclass of Block with the required methods.

Do you mean changing the functionality of a vanilla block? I know nothing about this. Maybe the "reflection" I've been hearing so much about may be useful to you.

[CaptainDoge]

Yes I do mean changing the functionality of a vanilla block by changing this \/ to my own block class

                            "public static final Block STONE = register("stone", new Block(Block.Properties.create(Material.ROCK, MaterialColor.STONE).hardnessAndResistance(1.5F, 6.0F)));"

[LexManos]

No that is not what you're wanting to do.

You just need to use registry replacements.

Just register your block, using vanilla's name. And it'll be overriden in the game.

[CaptainDoge]

oh that sounds a lot easier thanks

[CaptainDoge]

  On 5/24/2020 at 3:38 AM, LexManos said:

Just register your block, using vanilla's name. And it'll be overriden in the game.

Expand  

Does my block class have to share the same name as the vanilla class?

[Draco18s]

  On 5/24/2020 at 4:26 AM, CaptainDoge said:

Does my block class have to share the same name as the vanilla class?

Expand  

No, but it should (must? Not sure if Forge type-checks) extend the original's class, or Bad Things will happen.

Edited May 24, 2020 by Draco18s

[CaptainDoge]

I have registered the block like this

public static final RegistryObject<Block> OAK_LEAVES = BLOCKS.register("oak_leaves", WildLeavesBlock::new);

and it is not replacing the vanilla leaves do I have register the block differently?

[sciwhiz12]

Because you haveRegistryObject there, then you're using DeferredRegister. Please check if the second parameter to the DeferredRegister constructor is correct. If you intend to replace "minecraft:oak_leaves", the modid to be passed to that constructor should be "minecraft".

 

If you're replacing vanilla blocks and registering your own custom blocks, I suggest either:

• making two DeferredRegister objects and naming them seperately (preferrably in seperate classes); or
• registering your vanilla replacements in RegistryEvent.Register (see the docs or a tutorial), and your own blocks in DeferredRegister.

[CaptainDoge]

import com.blocks.exampletest;

import net.minecraft.block.Block;

import net.minecraft.block.SoundType;

import net.minecraft.block.material.Material;

import net.minecraftforge.event.RegistryEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(modid = "minecraft", bus = Mod.EventBusSubscriber.Bus.FORGE)

public class OverrideRegistryHandler

{

     @SubscribeEvent

     public void registerBlocks(RegistryEvent.Register<Block> event)

     {

          event.getRegistry().registerAll 

          ( 

               new exampletest(Block.Properties.create(Material.ANVIL).hardnessAndResistance(0.2F).tickRandomly().sound(SoundType.PLANT).notSolid()) 

          );

     }

}

I tried this syntax. this is what I interpret the docs to be saying is correct, but I don't see how to convey the name of the block I intend to replace

[sciwhiz12]

event.getRegistry().registerAll( 
           new LeafReplacementBlock(Block.Properties.create(Material.LEAVES)).setRegistryName("minecraft:oak_leaves")
      );

You need to call setRegistryName with the registry name of the block you want to replace.

I suggest assigning the new LeafReplacementBlock(...) to a public static field in your class, and then caliing registerAll.

[Draco18s]

  On 5/24/2020 at 8:55 AM, sciwhiz12 said:

I suggest assigning the new LeafReplacementBlock(...) to a public static field in your class, and then caliing registerAll.

Expand  

Do not do this. Do not create registry entities in a static location.

You want a static field referencing a block?
Use @ObjectHolder.

[CaptainDoge]

package com.dev.examplemod.util;

import com.blocks.exampletest;
import com.dev.examplemod.ExampleMod;
import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(modid = ExampleMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE)
public class OverrideRegistryHandler
{

    public Block OAK_LEAVES = new exampletest(Block.Properties.create(Material.ANVIL).hardnessAndResistance(0.2F).tickRandomly().sound(SoundType.ANVIL).notSolid());

    @SubscribeEvent
    public void registerBlocks(RegistryEvent.Register<Block> event)
    {
        event.getRegistry().registerAll
        (
            OAK_LEAVES.setRegistryName("minecraft","oak_leaves")

        );
    }

}

I have read the docs and these posts as thoroughly as my reading comprehension will allow, this code is the result of that. Yet my leaves don't sound like anvils, my only guesses for what the issue might be is the EventBusSubscriber that I copied and pasted from another class. I am not sure what changes I would have to make to the event structure to fire off of the correct event. exampletest extends LeavesBlock and that is all it does I'm not sure if this is important information

[sciwhiz12]

  On 5/24/2020 at 3:38 PM, Draco18s said:

Do not do this. Do not create registry entities in a static location.

You want a static field referencing a block?
Use @ObjectHolder.

Expand  

Woops. Forgot about @ObjectHolder. Won't happen again.

 

To @CaptainDoge,

• Your class is registering to the wrong bus; use Bus.MOD.
  • RegistryEvents are fired on the mod-specific event bus.
• Change your event handling method to static.

  •   On 5/24/2020 at 6:30 PM, diesieben07 said:

    @EventBusSubscriber registers the Class object to the event bus, meaning only static subscriber methods will be registered.

    Expand  

     

• Move the code constructing the Block into the event registerAll, and make a public static final field annotated with @ObjectHolder.
  • Never put your block constructor in an instance field on your event handling class with @EventBusSubscriber. Since you're using @EventBusSubscriber, you'll never get the instance containing your registered block, and any further created instances will make additional, unregistered, and useless instances of your block.

Corrected code:

  Reveal hidden contents

@Mod.EventBusSubscriber(modid = ExampleMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class OverrideRegistryHandler
{
    @ObjectHolder("minecraft:oak_leaves")
    public static final Block OAK_LEAVES = null;

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event)
    {
        event.getRegistry().registerAll
        (
            new exampletest(Block.Properties.create(Material.ANVIL).hardnessAndResistance(0.2F).tickRandomly().sound(SoundType.ANVIL).notSolid()).setRegistryName("minecraft:oak_leaves")
        );
    }
}

 

 

[Draco18s]

  On 5/24/2020 at 6:40 PM, sciwhiz12 said:

@ObjectHolder("minecraft:oak_leaves")

public static final Block OAK_LEAVES = null;

Expand  

This is fine, just pointing out that Blocks.OAK_LEAVES will contain the same value, so it isn't really necessary.

[CaptainDoge]

I have implemented these fixes and applied the same logic to registering items and everything seems to work fine until I grow a tree. This suggests to me that the Block is not fully overridden by this method, unless there is a strange exception in the Tree or foliage placer class.

[CaptainDoge]

I have been experimenting a bit and replaced grass_blocks an stone and it causes strange errors

STONE: stone generates fine but caves don't spawn inside the stone

GRASS: grass blocks don't generate instead there is just a lighting glitch and when updated spawns a non-textured block that behaves like grass yet the block still shows up in the creative tab and can be placed like normal

LEAVES: behaves normally when placed by player but will not be generated by growing trees

 

this is the method I am using to register these blocks

 

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public class RegistryEvents
{
    @ObjectHolder("minecraft:stone")
    public static final Block STONE_BLOCK = null;

    @ObjectHolder("minecraft:grass_block")
    public static final Block GRASS_BLOCK = null;

    @SubscribeEvent
    public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent)
    {
        blockRegistryEvent.getRegistry().registerAll
        (
            new Block(Block.Properties.create(Material.ROCK, MaterialColor.STONE).hardnessAndResistance(5.0f, 6.0F).sound(SoundType.STONE)).setRegistryName("minecraft:stone"),
            new GrassBlock(Block.Properties.create(Material.ORGANIC).tickRandomly().hardnessAndResistance(1.5F).sound(SoundType.PLANT)).setRegistryName("minecraft:grass_block")
        );
    }

    @ObjectHolder("minecraft:stone")
    public static final Item STONE_ITEM = null;

    @ObjectHolder("minecraft:grass_block")
    public static final Block GRASS_ITEM = null;

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event)
    {
        event.getRegistry().registerAll
        (
            new BlockItemBase(STONE_BLOCK, ItemGroup.BUILDING_BLOCKS).setRegistryName("minecraft:stone"),
            new BlockItemBase(GRASS_BLOCK, ItemGroup.BUILDING_BLOCKS).setRegistryName("minecraft:grass_block")
        );
    }
}

This is the  definition of BlockItemBase

package com.Blocks;

import net.minecraft.block.Block;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;

public class BlockItemBase extends BlockItem
{
    public BlockItemBase( Block blockIn, ItemGroup itemGroupIn)
    {
        super(blockIn, new Item.Properties().group(itemGroupIn));
    }
}

 

It seems to me that there is another step in registration that I am missing, unless minecraft's generation code surrounding these blocks is inflexible which I hop isn't the case

[DavidM]

1. Don't use bases. They are an abuse of inheritance.

2. Try replacing the constant values of items and block in Items and Blocks class respectively with your custom instances. I haven't met this exact problem before, but I guess it is caused by vanilla's still trying to use the original values from those two classes.

[CaptainDoge]

Just to be sure this

  Reveal hidden contents

    public static final Block GRASS_BLOCK = new GrassBlock(Block.Properties.create(Material.ORGANIC).tickRandomly().hardnessAndResistance(1.5F).sound(SoundType.PLANT)).setRegistryName("minecraft:grass_block");

 

is what is meant by 

  On 5/26/2020 at 9:31 AM, DavidM said:

replacing the constant values of items and block in Items and Blocks class respectively with your custom instances

Expand  

either way didn't seem to make a difference

 

I have removed the use of base classes, this \/ is what I have replaced it with I am not sure if this is correct but the items seem to behave properly

  Reveal hidden contents

            new BlockItem(STONE, new Item.Properties().group(ItemGroup.BUILDING_BLOCKS)).setRegistryName("minecraft:stone"),

 

Despite all these changes I am still getting the same behavior, after some experimentation I have found that some world gen works properly

 

World gen that works:

Lakes-Lava and water above and under ground

Mine shafts

normal stone world gen

all ores

dirt, gravel, andesite, diorite, granite patches

 

World gen that doesn't work:

caves in stone 

grass blocks

sand

 

Attached picture displays strange behavior 

[LexManos]

This is expected due to Mojang's shitty worldgen statically locking everything.

Why the hell are you replacing stone/grass?

[DavidM]

  On 5/26/2020 at 4:46 PM, CaptainDoge said:

Just to be sure this

  Reveal hidden contents

    public static final Block GRASS_BLOCK = new GrassBlock(Block.Properties.create(Material.ORGANIC).tickRandomly().hardnessAndResistance(1.5F).sound(SoundType.PLANT)).setRegistryName("minecraft:grass_block");

 

is what is meant by 

either way didn't seem to make a difference

 

I have removed the use of base classes, this \/ is what I have replaced it with I am not sure if this is correct but the items seem to behave properly

  Reveal hidden contents

            new BlockItem(STONE, new Item.Properties().group(ItemGroup.BUILDING_BLOCKS)).setRegistryName("minecraft:stone"),

 

Despite all these changes I am still getting the same behavior, after some experimentation I have found that some world gen works properly

 

World gen that works:

Lakes-Lava and water above and under ground

Mine shafts

normal stone world gen

all ores

dirt, gravel, andesite, diorite, granite patches

 

World gen that doesn't work:

caves in stone 

grass blocks

sand

 

Attached picture displays strange behavior 

Expand  

(I can't seem to partially quote a post on mobile)

 

That is not what I meant. You'll have to replace the constants in Blocks class via reflection.

[DaemonUmbra]

Still won't work David, Mojang's generators cache their blocks.

What are you changing about stone and grass?

[DavidM]

  On 5/27/2020 at 12:37 AM, DaemonUmbra said:

Still won't work David, Mojang's generators cache their blocks.

Expand  

Oh oops. I thought they would use the constants in the Blocks class (since the access time is constant anyways) instead of caching. What is the reason for doing so on Mojang's side?

[CaptainDoge]

  On 5/26/2020 at 7:55 PM, LexManos said:

Why the hell are you replacing stone/grass?

Expand  

 

  On 5/27/2020 at 12:37 AM, DaemonUmbra said:

What are you changing about stone and grass?

Expand  

 

I am replacing stone and grass to change their hardness and resistance (I wouldn't be surprised if their was a better way). But I also wanted to change oak leaves to add my own features which I accomplished but I couldn't get trees to spawn my new leaves