Jump to content

Recommended Posts

Posted

Why are you guys dealing with the 'unlocalizedName' and substring shit anyways?

See Block.func_111023_E and Item.func_111208_A along with associated functions/fields

They exist for a reason -.-

 

Or, I dunno, using your own strings:

 

itemIcon = iconRegister.registerIcon("MyMod:MyItem");

 

Because holy shit its so much easier to read.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Replies 90
  • Created
  • Last Reply

Top Posters In This Topic

Posted

Why are you guys dealing with the 'unlocalizedName' and substring shit anyways?

See Block.func_111023_E and Item.func_111208_A along with associated functions/fields

They exist for a reason -.-

 

Or, I dunno, using your own strings:

 

itemIcon = iconRegister.registerIcon("MyMod:MyItem");

 

Because holy shit its so much easier to read.

 

Who cares if its easier to read if you lose flexibility?

 

Why are you guys dealing with the 'unlocalizedName' and substring shit anyways?

See Block.func_111023_E and Item.func_111208_A along with associated functions/fields

They exist for a reason -.-

 

Oh, of course! *Smacks my forehead* Good old Block.func_111023_E and Item.func_111208_A! I should have known. Its so obvious now.  ;D

Posted

Who cares if its easier to read if you lose flexibility?

 

Generally speaking, my modID doesn't change in the middle of a project.

 

So the flexibility is entirely unneeded.  I also tend not to want to change my filenames when I figure out a more clever name for my block.  As far as I care, the file name can stay the same even though the block's name has changed.  So again, unneeded flexibility.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Not sure if I'm doing this right but im using this line now:

 

this.itemIcon = iconRegister.registerIcon("blocksnmore:" + this.func_111208_A());

 

And now im getting this error in the console :/

 

[sEVERE] [Minecraft-Client] Using missing texture, unable to load: blocksnmore:textures/items/MISSING_ICON_ITEM_31742_StoneMallet.png

 

What is the way to register textures, which won't give out console spam?

Posted

Who cares if its easier to read if you lose flexibility?

 

Generally speaking, my modID doesn't change in the middle of a project.

 

So the flexibility is entirely unneeded.  I also tend not to want to change my filenames when I figure out a more clever name for my block.  As far as I care, the file name can stay the same even though the block's name has changed.  So again, unneeded flexibility.

 

Arguing against the intelligent use of variables to reduce the amount of time needed to edit code when/if I decided to change naming schemes? Really? I'm not going to add monotony to things just because you have a hard time reading it.

Posted

Why are you guys dealing with the 'unlocalizedName' and substring shit anyways?

See Block.func_111023_E and Item.func_111208_A along with associated functions/fields

They exist for a reason -.-

 

Because they're 'unnamed', which implies that we shouldn't use them.

I try to stick to functions that have been renamed into something resembling what they do.

In some cases that's not possible, of course, like func_110143_aJ(), which should

be getEntityHealth().

Thats retarded you do know that ALL 'renamed' stuff is done by crowdsourcing from modders right? It has NOTHING to do with if you should use it or not -.- EVERYTHING will be 'unnamed' for 1.6 as the shit is new, nobody has gone in and named them yet.

 

How about, we take a look what we have...

    /**
     * When this method is called, your block should register all the icons it needs with the given IconRegister. This
     * is the only chance you get to register icons.
     */
    public void registerIcons(IconRegister par1IconRegister)
    {
        this.blockIcon = par1IconRegister.registerIcon(this.func_111023_E());
    }

Pretty standard it tries to register a icon that is named the return value of fun_111023_E.. I wonder what that function could be....

    protected String func_111023_E()
    {
        return this.field_111026_f == null ? "MISSING_ICON_TILE_" + this.blockID + "_" + this.unlocalizedName : this.field_111026_f;
    }

Oh that's straight forward, if a field is null it returns a "MISSING_ICON_TILE" with the block id and unlocalized name... But if it's set it just returns that field...

I wonder if there is a place where we can SET that field...

    public Block func_111022_d(String par1Str)
    {
        this.field_111026_f = par1Str;
        return this;
    }

OMFG there is.

Lets try calling that function with what I want to name my icon and HOLY SHIT BALLS OF THE COW GOD MOOSUS IT WORKS!

 

That boys and girls is called troubleshooting/research/LEARNING. And ALL modders should know how to, and feel comfortable doing it.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted
Arguing against the intelligent use of variables to reduce the amount of time needed to edit code when/if I decided to change naming schemes? Really? I'm not going to add monotony to things just because you have a hard time reading it.

 

I'll just drop this here.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Okay I sorta understand the code now. But please don't kill me for asking but is this correct then? (This is for an item btw)

 

public class StoneMallet extends ItemAxe {
public StoneMallet(int par1, EnumToolMaterial par2EnumToolMaterial) {
    super((par1-256), par2EnumToolMaterial);
    this.setCreativeTab(BlocksNMore.BlocksNMoreTab);
    this.setUnlocalizedName(Strings.STONEMALLET);
    this.setMaxStackSize(1);
    
    this.func_111206_d("blocksnmore:stonemallet");
}
  
  @SideOnly(Side.CLIENT)
  public void registerIcons(IconRegister iconRegister) {
	  	this.itemIcon = iconRegister.registerIcon(this.func_111208_A());
	  }

 

Im setting the "func_111022_d" with my modname/item name and when I run it loads the texture no problem, but the console is still saying that it can't find it. Im using forge 9.10.0.786 if thats anything. But I think im calling it correctly now :)

Posted

This thread helped me.

Not only does the folder need to be lower case, but the code as well.

registerIcon(modid + ":" + this.getUnlocalizedName().substring(5).toLowerCase()

 

EDIT: actually, after realizing that doesn't make sense, because that refers to the file name, which doesn't need to be lower case, I removed that and it still worked.

So... it started working for me and I didn't change anything.

Posted

So... it started working for me and I didn't change anything.

 

Welcome to software development.

 

BCh-v51CAAA9HuT.jpg

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Why are you guys dealing with the 'unlocalizedName' and substring shit anyways?

See Block.func_111023_E and Item.func_111208_A along with associated functions/fields

They exist for a reason -.-

 

Because they're 'unnamed', which implies that we shouldn't use them.

I try to stick to functions that have been renamed into something resembling what they do.

In some cases that's not possible, of course, like func_110143_aJ(), which should

be getEntityHealth().

Thats retarded you do know that ALL 'renamed' stuff is done by crowdsourcing from modders right? It has NOTHING to do with if you should use it or not -.- EVERYTHING will be 'unnamed' for 1.6 as the shit is new, nobody has gone in and named them yet.

 

How about, we take a look what we have...

    /**
     * When this method is called, your block should register all the icons it needs with the given IconRegister. This
     * is the only chance you get to register icons.
     */
    public void registerIcons(IconRegister par1IconRegister)
    {
        this.blockIcon = par1IconRegister.registerIcon(this.func_111023_E());
    }

Pretty standard it tries to register a icon that is named the return value of fun_111023_E.. I wonder what that function could be....

    protected String func_111023_E()
    {
        return this.field_111026_f == null ? "MISSING_ICON_TILE_" + this.blockID + "_" + this.unlocalizedName : this.field_111026_f;
    }

Oh that's straight forward, if a field is null it returns a "MISSING_ICON_TILE" with the block id and unlocalized name... But if it's set it just returns that field...

I wonder if there is a place where we can SET that field...

    public Block func_111022_d(String par1Str)
    {
        this.field_111026_f = par1Str;
        return this;
    }

OMFG there is.

Lets try calling that function with what I want to name my icon and HOLY SHIT BALLS OF THE COW GOD MOOSUS IT WORKS!

 

That boys and girls is called troubleshooting/research/LEARNING. And ALL modders should know how to, and feel comfortable doing it.

See now i tried this but i need the game to point to my resource folder and then to my icons, how might one go about doing that?

Posted

See now i tried this but i need the game to point to my resource folder and then to my icons, how might one go about doing that?

 

By moving the resource directory to where it needs to be.  If you're using the Pahmir* setup, you'll have to import it the same way you would anything else.

 

*I forget how to spell his name and don't care to actually look it up

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

pahimar

 

Close enough.  At least I finally stopped trying to add an L to it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 2 weeks later...
Posted

Why do people call it a pahimar setup? I've been using it since long before he showed it to everyone ><

 

Then i don't know, if you read the readme that dinnerbone put in the assets folder inside of MCP it says that anything placed there will be deleted on start-up.

 

If you are using an external location for your mod's source like with a pahi-setup (whatever) outside of src/minecraft, minecraft will not load the textures. Have no idea why.  :o

"If A is a success in life, then A equals x plus y plus z. Work is x; y is play; and z is keeping your mouth shut." - Albert Einstein

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.