Resource loading in Forge 4

[Kinniken]

I've been working on updating Millénaire to MC 1.3/Forge 4 and I finally got it to run. I like the new APIs and the general setup, but the upgrade is a bit steep I really like the new event system though.

 

Anyway, I have a few questions linked to some stuff that's not working yet. The most important as the title say regards resource loading. In MC 1.2 I loaded my active textures that way:

 

ImageIO.read((net.minecraft.client.Minecraft.class).getResource("/graphics/item/ML_om_amulet.png"));

 

Where the PNG file is in mod/millenaire/graphics/item/ (not zipped). In 1.2 it worked fine, in 1.3 the resource is null. Has anything changed there? Same problem BTW with custom items, blocks and skins.

 

Otherwise, two bonus questions:

 

- is there a convenient way of knowing which side we are in in IConnectionHandler.connectionClosed()? And of getting the name of the user if it's server-side? It used to be possible to get it from the networkManager but that doesn't seem to work anymore.

- in MCP, if I make an Eclipse project with the code from common and minecraft it compiles fine (with the proper libraries in the build path of course). However if I make one with common and minecraftserver, I get 20 compile errors, the most common being due to BaseMod missing (in ASMModParser and ModLoaderModContainer for instance). Is this normal? Is there a way of configuring a server env in MCP?

 

Thanks!

 

K.

[LexManos]

If you use the install script that forge provides it replaces the eclipse workspace with a single project that is named 'Minecraft' and has two debug configs 'Client' and 'Server'

That is all you need its all configured properly to test the did server vs the client.

 

Aside from that, loading textures should work as it always has, as the Loading code has not changed to much between 1.2 and 1.3. It loads all the folders inside /mods/ to the classpath, so it should work. Not sure why it doesnt on that front.

[atrain99]

  On 8/19/2012 at 9:48 PM, LexManos said:

If you use the install script that forge provides it replaces the eclipse workspace with a single project that is named 'Minecraft' and has two debug configs 'Client' and 'Server'

That is all you need its all configured properly to test the did server vs the client.

 

Aside from that, loading textures should work as it always has, as the Loading code has not changed to much between 1.2 and 1.3. It loads all the folders inside /mods/ to the classpath, so it should work. Not sure why it doesnt on that front.

You're nice to people that know what they're talking about. 

 

[LexManos]

Yes I am, because they arnt pestering me with stupid questions that they can answer themselves with 10 seconds of looking.

So if i'm 'mean' to you, you know you are in the wrong.

[atrain99]

  On 8/19/2012 at 10:56 PM, LexManos said:

Yes I am, because they arnt pestering me with stupid questions that they can answer themselves with 10 seconds of looking.

So if i'm 'mean' to you, you know you are in the wrong.

I know how that works!

 

[Cutter]

  On 8/19/2012 at 11:36 PM, atrain99 said:

  Quote

Yes I am, because they arnt pestering me with stupid questions that they can answer themselves with 10 seconds of looking.

So if i'm 'mean' to you, you know you are in the wrong.

I know how that works!

well hes not called the 'Forge Code God' or 'Noob Slayer' for no reason lol

[etopsirhc]

  On 8/20/2012 at 12:33 AM, Cutter said:

  Quote

  Quote

Yes I am, because they arnt pestering me with stupid questions that they can answer themselves with 10 seconds of looking.

So if i'm 'mean' to you, you know you are in the wrong.

I know how that works!

well hes not called the 'Forge Code God' or 'Noob Slayer' for no reason lol

the only problem with the noob slayer part is when the person did spend time looking

like for my sound problem , i spent a good day before asking , then another day trying what ppl said to before a single sound loaded properly XP . and when i did get awnsers they were the kind where if you haven't been working with forge or haven't helped make forge you wouldn't have known to begin with. that said i did get a good answer in the end

[LexManos]

Or, you could of look in the code for sound related hooks and read, anyways this thread as gone way off topic, shutup if you're not on topic.

[Kinniken]

  On 8/19/2012 at 9:48 PM, LexManos said:

If you use the install script that forge provides it replaces the eclipse workspace with a single project that is named 'Minecraft' and has two debug configs 'Client' and 'Server'

That is all you need its all configured properly to test the did server vs the client.

 

Thanks, that works. I hadn't seen it because I do my own project configs due to wanting to use my existing workspace. This means BTW that the code in minecraftserver is no longer used at all?

 

  Quote

Aside from that, loading textures should work as it always has, as the Loading code has not changed to much between 1.2 and 1.3. It loads all the folders inside /mods/ to the classpath, so it should work. Not sure why it doesnt on that front.

 

Very strange. And I get the same error when running it with your Eclipse workspace. I also tried zipping it and same deal. I guess I'll try and see if I can get an other Forge mod to work.

 

Anyone has anything to suggest regarding this? :

 

  Quote

- is there a convenient way of knowing which side we are in in IConnectionHandler.connectionClosed()? And of getting the name of the user if it's server-side? It used to be possible to get it from the networkManager but that doesn't seem to work anymore.

[SanAndreaP]

  On 8/20/2012 at 12:55 PM, Kinniken said:

  Quote

- is there a convenient way of knowing which side we are in in IConnectionHandler.connectionClosed()? And of getting the name of the user if it's server-side? It used to be possible to get it from the networkManager but that doesn't seem to work anymore.

 

Did you try:

if(FMLCommonHandler.instance().getSide().isClient()) to check if it's on the client or

if(FMLCommonHandler.instance().getSide().isServer()) to check if it's on the server

?

[Kinniken]

Won't that always return client though if it's not a stand-alone server, even if the event is being triggered by a LAN player disconnecting, in which case it's really a "server-side" event?

[SanAndreaP]

  On 8/20/2012 at 2:08 PM, Kinniken said:

Won't that always return client though if it's not a stand-alone server, even if the event is being triggered by a LAN player disconnecting, in which case it's really a "server-side" event?

 

Huh, that's true. Then I have no idea

[Kinniken]

I figured out the resource problem, if anyone else is having the same. It's due to me splitting the Millénaire mod between a millenaire zip file that contains the classes and a millenaire folder with the content, including the textures. Forge 3 loaded the content of the folder as resources even if it wasn't a "mod" folder as such. Forge 4 doesn't. So I'll now package the textures in the zip file instead.

[cpw]

Fmlcommonhanlder.get environment side is a guess as to the side in an integrated server. Random files are no longer added to the class path. You can get stuff straight from your mod zip: I give you a file in pre unit that is your mod zip..

[Kinniken]

  On 8/24/2012 at 4:12 AM, cpw said:

Random files are no longer added to the class path.

 

I guess one guy's bug is an other guy's feature Any change of being able to request the loading of a directory in a future update? Maybe triggered by an info file at the root of the dir?

 

Otherwise, what is the status of Forge for Bukkit in MC 1.3? It works well? That's my next project.

[LexManos]

One thing I always hated about Millenair was how many folders it made in random place

[Kinniken]

Two of them in mods/ for easy user-modding. Nobody else ever complained

[LexManos]

Eah last time I used it it has a folder in the root of the MC dir.

And you could just setup those folders for yourself when the mod loads for the first time.

Anything more complicated then 'Put this zip in /mods/' is a bad idea

Instead of relying on on classpaths, you could write a little bit to load things from that folder first if they exist.

[cpw]

I would tend to agree with lex. You get given your zip distributable as a file in preinit event so if you want to open it up and deploy it somewhere and then do stuff, do it there. I don't want to add random paths. Mcpatcher is already annoying in that respect...

[Kinniken]

I'm not sure why it would be easier for users to install a zip instead of a zip and two folders in the same place And I want people to be aware that Millénaire comes with plenty of user-accessible content.

 

Otherwise cpw how is the situation regarding Bukkit and Forge? I'd like to tackle that once the current Millénaire version is stable.

[LexManos]

  On 8/27/2012 at 9:25 PM, Kinniken said:

I'm not sure why it would be easier for users to install a zip instead of a zip and two folders in the same place

You give WAY to much credit to the end user.

Hell, its a miracle they even understand how to put the mod in the right folder.

[OvermindDL1]

Yeah, often they do not even know that the 'mods' folder is the folder they put mods in, even when told to, you should make that explicit.  Many end users are about the least intelligent people that you will find.