Jump to content

[1.10.2] NPE on getRegistryName


KeeganDeathman
 Share

Recommended Posts

Post your code, we're not psychic.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Here's a sample block declaration

labstuffBlocks.add(blockAcceleratorPowerInput = new BlockAcceleratorPowerInput().setRegistryName("labstuff","blockAcceleratorPowerInput").setCreativeTab(tabLabStuff));

 

And my registry code

for(Block block : labstuffBlocks)
	{
		GameRegistry.register(block, block.getRegistryName());
		GameRegistry.register(Item.getItemFromBlock(block).setRegistryName(block.getRegistryName()), block.getRegistryName());
	}

[shadow=gray,left][glow=red,2,300]KEEGAN[/glow][/shadow]

Link to comment
Share on other sites

Betcha it's this part here:

Item.getItemFromBlock(block)

 

Just because you called GameRegistry.register on a block does not mean your block has an item.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Interesting, that must be new.

However, it also happened in this(now since reworked) functions in a block class

@Override
public boolean isOpaqueCube(IBlockState state)
{
	if(getRegistryName().getResourcePath().contains("Glass") || getRegistryName().getResourcePath().contains("Rotor"))
		return false;
	return true;
}

[shadow=gray,left][glow=red,2,300]KEEGAN[/glow][/shadow]

Link to comment
Share on other sites

Interesting, that must be new.

However, it also happened in this(now since reworked) functions in a block class

@Override
public boolean isOpaqueCube(IBlockState state)
{
	if(getRegistryName().getResourcePath().contains("Glass") || getRegistryName().getResourcePath().contains("Rotor"))
		return false;
	return true;
}

If you are getting a NPE just run a check to see if it is != null. Though I can not see the error report to give you anymore guidance.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

If the NPE is caused by

getRegistryName()

, then either the item/block you are trying to get the registry name of, does not have a registry name, or you are trying to access the registry name before you actually do set it.

 

If the NPE is caused by the, as mentioned,

Item.getItemFromBlock(block)

, then skip that method altogether. Instead, create an

ItemBlock

using the block as the passed parameter, and then register that.

ItemBlock is instantiated just like an ItemStack.

 

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

Also, DO NOT run fundemental aspects of your code based off string comparisons of registry names.

Seriously...

Set a field for the opaquenss and use that...

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Link to comment
Share on other sites

I switched to set and getRegistryName(), but now whenever i use the getter, I get an NPE.

Why?

You asked about an NPE without posting the crash report. Perhaps the forum needs a banner or sticky rules to warn against that again. As Draco says, we're not psychic.

 

Rerun your code in the debugger (setting a breakpoint ahead of the crash point). Examine the fields about to be used in the crash. See what is null. Fix it.

 

Further, since order of execution is often the cause of an NPE, we need to see whole classes, not just lines out of context. You could also put print statements in both your get and set to see which runs first (then use the debugger to examine the call stack).

 

Finally, when referring to a class's methods and fields that are not static, get into the habit of prefixing them with "this."

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Finally, when referring to a class's methods and fields that are not static, get into the habit of prefixing them with "this."

 

That's completely personal preference and doesn't have any affect on the compiled code (excepting overloaded parameters). I personally don't use

this

because I feel it's unnecessarily verbose and doesn't provide any valuable information.

Don't make mods if you don't know Java.

Check out my website: http://shadowfacts.net

Developer of many mods

Link to comment
Share on other sites

Actually, using "this" is a good habit because it will sometimes remind you when you that you have a static vs instance conflict (at least it will have you thinking about it). Well, you might never do anything that careless, but if I revisit code after months away doing something else, I sometimes break it, and I like having Eclipse tell me so sooner rather than later.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

I have an IDE that formats static in italics, so I don't have that problem.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • This is my first time making a pack and i just wanted to add mods that i know or that look interesting. So When making the pack i get this error with Refined Storage https://pastebin.com/DxtTbVZW
    • Hello! When I'm trying to get items by tag during the recipe serialization, I'm getting an empty list. I have a guess that item tags're not loaded by the time minecraft loads my recipes. Here's my code: Class that saves information about ingredient's count Recipe serializer with some aux methods: Registry: Example of the json recipe file:  
    • I tried to install client forge on my linux desktop. But after "installation" it's missing forge[version].jar file in .minecraft/versions. I tried java 11 and 8 environment with same result. Here link to log file from installation: https://drive.google.com/file/d/1vtg9NT-WX5ilb1aNUvZlOv54gKWJuaT1/view?usp=share_link. I don't know what to do. I give for every directory permissions that I don't think that is issue. I will try check older versions if universal file work. Debian 11 (kernel 5.10)
    • I recently got error 1 in the launcher, so I restarted the .minecraft. After restarting it, I can't get the Forge 1.19.2 - 43.1.1 installer to run, I tried other versions and I get the same result, it opens a black box that closes instantly and nothing happens. I already tried to restart my pc, minecraft, update and reinstall java, run vanilla 1.19.2 and more recent versions of the game, disable Windows Firewall and antivirus and I still haven't solved it. Many times I installed forge and never ran into this problem. If I could receive assistance I would be very grateful.  
    • Here's the default loot table for gravel block: { "type": "minecraft:block", "pools": [ { "rolls": 1.0, "bonus_rolls": 0.0, "entries": [ { "type": "minecraft:alternatives", "children": [ { "type": "minecraft:item", "conditions": [ { "condition": "minecraft:match_tool", "predicate": { "enchantments": [ { "enchantment": "minecraft:silk_touch", "levels": { "min": 1 } } ] } } ], "name": "minecraft:gravel" }, { "type": "minecraft:alternatives", "conditions": [ { "condition": "minecraft:survives_explosion" } ], "children": [ { "type": "minecraft:item", "conditions": [ { "condition": "minecraft:table_bonus", "enchantment": "minecraft:fortune", "chances": [ 0.1, 0.14285715, 0.25, 1.0 ] } ], "name": "minecraft:flint" }, { "type": "minecraft:item", "name": "minecraft:gravel" } ] } ] } ] } ] } This is a finicky loot table. If I add anything to it, nothing drops. I've added pools, entries, children ... you name it. Does anyone know the particulars about this table? I mean, periodically gravel drops flint instead of a gravel block. I understand the condition that could drop flint if the block survives an explosion. Otherwise, it drops the gravel block itself. I would like to further understand why the use of `children` and the set of `chance` values given in the explosion child entry. What I do understand is that `"type" : "minecraft:alternatives"` means that if this child/entry is successful, then it stops generating loot for this entry/pool. How often does the flint drop and is that taken care of in another location? Is that in a `"condition" : "minecraft:table_bonus"` loot table? Hmmm... I'll have to go take a look and see if there is something called table_bonus.json.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.