Jump to content

Recommended Posts

Posted

Why do people call it a pahimar setup? I've been using it since long before he showed it to everyone ><

 

Because he showed it to everyone.

Oh, and I tried to follow his tutorial to set myself up like that and I couldn't get it to work, so I said, "the hell with it, hard drive space is cheap" and just move things around as I need to.

 

Then i don't know, if you read the readme that dinnerbone put in the assets folder inside of MCP it says that anything placed there will be deleted on start-up.

 

I read the readme.  It's entirely unhelpful.  Because all it says (and you repeated it) is "don't put things here."  It does NOT say where they should go!

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Replies 90
  • Created
  • Last Reply

Top Posters In This Topic

Posted

I've been trying to update my NBTEdit mod, which has a couple of GUI textures.

 

I first tried "assets/nbtedit/textures/gui/..." and a similar ResourceLocator,

 

 

public static final ResourceLocation TEXTURE = new ResourceLocation("nbtedit", "textures/gui/widgets.png");

 

That of course didn't work, but, if I move my textures to "assets/minecraft/nbtedit/textures/gui/..." and use this code, it works.

 

public static final ResourceLocation TEXTURE = new ResourceLocation("nbtedit/textures/gui/widgets.png");

 

Now, I dug into the problem, and here are my findings. SimpleReloadableResourceManager attempts to load the texture with a call to func_110536_a(ResourceLocation), which then uses the first string (normally "minecraft", attempted to set for my mod "nbtedit") to locate a ResourceManager from its ResourceManager map. Of course, nothing is mapped to "nbtedit". The reason one is mapped to "minecraft" is because in a call to SimpleReloadableResourceManager.func_110545_a(ResourcePack), the default resource pack is loaded, which contains an immutable set of strings to map with a FallbackResourceManager. The set only contains "minecraft", and when it sees "nbtedit" later, it crashes instead of creating a new FallbackResourceManager. I believe we need to wait for a proper Forge implementation of "AbstractResourcePack" or an edit of SimpleReloadableResourceManager.

Posted

Why do people call it a pahimar setup? I've been using it since long before he showed it to everyone ><

 

Then i don't know, if you read the readme that dinnerbone put in the assets folder inside of MCP it says that anything placed there will be deleted on start-up.

i tryed to use your version but i get this error insted

2013-07-02 19:28:09 [sEVERE] [Minecraft-Client] Using missing texture, unable to load: minecraft:textures/items/MISSING_ICON_ITEM_7258_Steel-Ingot.png

Posted

As for locations, here is what's working for me at the moment:

 

1) Within Eclipse/Forge/MCP:

- Keep setup the same: {modid}\textures\{items/blocks}\name.png

 

2) After recompiling & obfuscation, ready for live play:

\assets\{modid}\textures\items\name.png

Unfortunately, blocks does not seem to be playing by the same rule for me *despite* the following:

 

3) After opening the 1.6.1 jar in .minecraft/versions/, this is what I'm finding:

\assets\{modid}\textures\blocks\

\assets\{modid}\textures\items\

\assets\{modid}\textures\entities\{mobtype}\name.png

GUI, paintings, items, misc, and all that is in that \textures\(subfolder)\ as well.

 

I'm wondering if the blocks' textures need to be coded differently, even though there's no apparent errors in Eclipse for my code.

Posted

As for locations, here is what's working for me at the moment:

 

1) Within Eclipse/Forge/MCP:

- Keep setup the same: {modid}/textures/{items/blocks}/name.png

 

And where does this folder go?

 

2) After recompiling & obfuscation, ready for live play:

- Items - assets/{modid}/{textures}/items/name.png

Unfortunately, blocks does not seem to be playing by the same rule.  assets/{modid}/{textures}/tiles/name.png does *not* work for me.

 

/tiles?  don't you mean /blocks?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

And where does this folder go?

 

My apologies.  Full file paths, for my setup; first set is with the .class files after recompilation, second set is with the .java files before recompilation:

C:\Files\forge\mcp\eclipse\Minecraft\bin\mods\minehack\textures\items\name.png

C:\Files\forge\mcp\eclipse\Minecraft\bin\mods\minehack\textures\blocks\name.png

 

C:\Files\forge\mcp\src\minecraft\mods\minehack\textures\items\name.png

C:\Files\forge\mcp\src\minecraft\mods\minehack\textures\blocks\name.png

 

/tiles?  don't you mean /blocks?

 

I mean both. :)  It was a random idea; on mouseover in live, the blocks have 'tile.Antigonite.name' for instance, so I figured it was worth checking to see if might have been changed to \tiles\ instead of \blocks\.  Not so, sadly.

Posted

mcp/eclipse/Minecraft/bin/assets/minecraft/ seems to be working if you're using ResourceLocation.

 

Ie...

 

new ResourceLocation("infection/textures/entity/walker.png");

 

=

 

mcp/eclipse/Minecraft/bin/assets/minecraft/infection/textures/entity/walker.png

 

If you want something that works for the time being without going in and editing the jar.

Posted

I have had the same problem as others and have found the solution.

 

Assets are loaded from the icon registry at a different time than they used to be. You must register your icons during the PRE INIT not during the INIT. Otherwise they will not be in the icon registry when the assets are loaded.

 

Hope that helps.  ;)

 

EDIT: Just to confirm, the directory is the same as before but "assets" instead of "mods".

Posted

Can you still use that in forge build 758, as they made this change...

 

"Resource packs, part two. FML mods are now resource packs. Vanilla will scan anything under 'assets' and turn it into a resource prefix. Use resourcelocations to look stuff up."

 

Edit: Never mind, that does work.

Posted
You must register your icons during the PRE INIT not during the INIT.

 

And how does one do that?

Forge calls registerIcons, not [my main mod file].

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

ResourcePacks *should* be refreashed after all mods are loaded.

Make sure you're using the latest version of Forge.

the proper place to pt your asses is in: /mcp/src/minecraft/assets/{modname}

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

Lex, I tried that but it wouldn't work. I tried outside of a /mcp/src/minecraft/assets/{modname}/textures and inside. Neither work. Where do I put the textures?

 

EDIT: I finally got to a live version of files.minecraftforge.net. I'm going to update and see what happens!

 

EDIT: Still didn't work.

-Mitchellbrine

 

Minecraft can do ANYTHING, it's coded in Java and you got the full power of Java behind you when you code. So nothing is impossible.

It may be freaking fucking hard though, but still possible ;)

 

If you create a topic on Modder Support, live by this motto:

I don't want your charity, I want your information
Posted

ResourcePacks *should* be refreashed after all mods are loaded.

Make sure you're using the latest version of Forge.

the proper place to pt your asses is in: /mcp/src/minecraft/assets/{modname}

 

It is not doing that in the latest version on the file server, you have to put all LanguageRegistry calls in preInit for the names and textures to be found correctly.  It might need more, my init method is basically LanguageRegistry, GameRegistry, OreDictionary, and instantiations, so I just grabbed most of it and moved it over.  I also added in pack.mcmeta file under assets/modname and almost all of my textures loaded with no other changes to the code.  The only one that didn't work after that was my hacked together test block, and that was because I used setUnlocalizedName as the texture reference.  My gui textures aren't loading though, so that's next on my list of stuff to fix tomorrow, probably a reference issue.  I have it updated on my Github (https://github.com/Malorolam/Carbonization) so there is a more complex example to look at for block and item textures.

Posted

I'm blaming Mojang for some of this nonsense.

 

If you take a look in FolderResourcePack.java

if (!s.equals(s.toLowerCase()))
{
    this.func_110594_c(s);
}

 

which roughly translates as:

if mod name contains upper case letters, then throw an error and refuse to do anything with it.

 

Anyone happen to know which string it uses in this function, eg is it Mod.modid, Mod.name or something else ?

Posted

I'm blaming Mojang for some of this nonsense.

 

If you take a look in FolderResourcePack.java

if (!s.equals(s.toLowerCase()))
{
    this.func_110594_c(s);
}

 

which roughly translates as:

if mod name contains upper case letters, then throw an error and refuse to do anything with it.

 

Anyone happen to know which string it uses in this function, eg is it Mod.modid, Mod.name or something else ?

 

String s is the return from a function that takes in two files, one of which appears to be the main directory to the assets folder, the other appears to be the mod specific file locations, i.e. the <modname>/textures/blah part, all of which should normally return all lowercase.

 

From what I see, if it throws the error it's because there is actually an error, and the basic Java file structure stuff broke somehow.

Posted

ResourcePacks *should* be refreashed after all mods are loaded.

Make sure you're using the latest version of Forge.

the proper place to pt your asses is in: /mcp/src/minecraft/assets/{modname}

 

It is not doing that in the latest version on the file server, you have to put all LanguageRegistry calls in preInit for the names and textures to be found correctly.  It might need more, my init method is basically LanguageRegistry, GameRegistry, OreDictionary, and instantiations, so I just grabbed most of it and moved it over.  I also added in pack.mcmeta file under assets/modname and almost all of my textures loaded with no other changes to the code.  The only one that didn't work after that was my hacked together test block, and that was because I used setUnlocalizedName as the texture reference.  My gui textures aren't loading though, so that's next on my list of stuff to fix tomorrow, probably a reference issue.  I have it updated on my Github (https://github.com/Malorolam/Carbonization) so there is a more complex example to look at for block and item textures.

I would like to know what a pack.mcmeta file is and what it should contain

Don't tell me to learn the basics of java, I already know.

Posted

I would like to know what a pack.mcmeta file is and what it should contain

 

Apparently this:

 

{
"pack": 1,
"description": "Forge Mod Defaults"
}
}

 

Not that adding it to my project made any difference what so ever.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

 

Which is, sadly, no more helpful than this thread.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

it has worked for alot of people! :P if you actually followed it correctly!

 

Please sir, inform me as to what I'm doing wrong.

https://dl.dropboxusercontent.com/u/7950499/src.zip

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.